cpufreq: Fix sysctl name conflict between hwpstate_intel and hwpstate_amd

[guest-seuros]

Summary

Both hwpstate_intel.c and hwpstate_amd.c were registering the same sysctl name (machdep.hwpstate_pkg_ctrl), causing a "can't re-use a leaf" error when both drivers are compiled into the kernel via the cpufreq option.

Rename the sysctls to be vendor-specific:

• machdep.hwpstate_pkg_ctrl => machdep.hwpstate_intel_pkg_ctrl
• machdep.hwpstate_pkg_ctrl => machdep.hwpstate_amd_pkg_ctrl

This allows both drivers to coexist and makes the sysctl naming more explicit about which driver they control.

[guest-seuros]

This looks like a breaking change. Not sure if the solution is to detect the cpu (since having both types in the same motherboard is not possible).

[olce]

I'm already working on it. May be what ShengYi proposed in D54528 already, but I'm trying a different, somewhat simpler approach.

I don't think it's reasonable to change the name of a knob that has existed for a relatively long time (in the Intel case) without proper deprecation and warning.

[guest-seuros]

Your approach is much more elegant..

Sorry for not doing another search before submitting. I had this change locally (before the diff was open).

Thanks.

[olce]

In D55139#1260674, @guest-seuros wrote:

Your approach is much more elegant..

Sorry for not doing another search before submitting. I had this change locally (before the diff was open).

Thanks.

No problem. That (unfortunately) happens from time to time, although here the changes are quite small, so hopefully there wasn't too much wasted effort.