hwpstate: Use dynamic sysctl initialization
Needs ReviewPublic
Actions

Authored by aokblast on Mon, Jan 5, 3:23 PM.

Details

Reviewers

markj
olce
khng

Summary

The AMD and Intel's pstate drives share the same sysctl node. To prevent
warning from module loader, we use dynami sysctl which will be allocated
and deallocated when module being load and unload.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69626
Build 66509: arc lint + arc unit

Event Timeline

aokblast created this revision.Mon, Jan 5, 3:23 PM

Herald added a subscriber: imp. · View Herald TranscriptMon, Jan 5, 3:23 PM

aokblast requested review of this revision.Mon, Jan 5, 3:23 PM

Harbormaster completed remote builds in B69626: Diff 169067.Mon, Jan 5, 3:23 PM

aokblast added reviewers: markj, olce, khng.Mon, Jan 5, 3:23 PM

markj added inline comments.Mon, Jan 5, 3:29 PM

sys/x86/cpufreq/hwpstate_amd.c
376	This definitely needs some comment explaining why we register the sysctls this way.

olce mentioned this in D49587: hwpstate: add CPPC support for pstate driver on AMD.Mon, Jan 5, 3:50 PM

olce added inline comments.Mon, Jan 5, 4:13 PM

sys/x86/cpufreq/hwpstate_amd.c
377–387	While it does not hurt per se, I would not move the above knobs here, as they do not exist in the Intel driver and my plan is to remove `machdep.hwpstate_pkg_ctrl` both here and in the Intel driver in favor of a common knob under `dev.hwpstate_*` to set all cores' EPP, which could later lead to removing `hwpstate_modevent()`.