hwpstate_amd: Fix autonomous mode
Needs RevisionPublic
Actions

Authored by aokblast on Feb 26 2026, 7:14 AM.

Tags

None

Referenced Files

	F154242536: D55527.id172756.diff
	Mon, Apr 27, 8:54 AM

	Unknown Object (File)
	Wed, Apr 15, 1:03 PM

	Unknown Object (File)
	Sun, Apr 12, 6:31 PM

	Unknown Object (File)
	Sat, Apr 11, 8:02 PM

	Unknown Object (File)
	Sat, Apr 11, 8:09 AM

	Unknown Object (File)
	Wed, Apr 8, 9:52 AM

	Unknown Object (File)
	Sat, Apr 4, 10:40 AM

	Unknown Object (File)
	Mar 24 2026, 5:52 AM

View All 31 Files

Subscribers

imp

Details

Reviewers

olce

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 71022
Build 67905: arc lint + arc unit

Event Timeline

aokblast created this revision.Feb 26 2026, 7:14 AM

Herald added a subscriber: imp. · View Herald TranscriptFeb 26 2026, 7:14 AM

aokblast requested review of this revision.Feb 26 2026, 7:14 AM

Harbormaster completed remote builds in B71022: Diff 172756.Feb 26 2026, 7:14 AM

aokblast added a reviewer: olce.Feb 26 2026, 7:14 AM

Mmm, this change from D55253 is deliberate. Autonomous mode does not work on some AMD CPUs, where setting "desired performance" to 0 actually causes lowest performance to be selected. As long as we do not have a user-understandable way to choose a better default, such as PM profile in ACPI's FADT, let's do like all other CPU freq/power drivers do (except hwpstate_intel(4)) and select maximum performance. Let's revise this only as part of actually implementing one.

This revision now requires changes to proceed.Mar 3 2026, 1:29 PM

IOW, that would mean reopening PR 292615.

Revision Contents
Changeset List

Path

Size

sys/

x86/

cpufreq/

hwpstate_amd.c

5 lines

Diff 172756

View Options

sys/x86/cpufreq/hwpstate_amd.c

hwpstate_amd: Fix autonomous modeNeeds RevisionPublicActions