Page MenuHomeFreeBSD
Differential D55527

hwpstate_amd: Fix autonomous mode
Needs RevisionPublic
Actions

Authored by aokblast on Thu, Feb 26, 7:14 AM.
Tags
None
Referenced Files
F146596885: D55527.diff
Tue, Mar 3, 11:26 PM
Unknown Object (File)
Mon, Mar 2, 1:42 PM
Unknown Object (File)
Mon, Mar 2, 9:13 AM
Unknown Object (File)
Mon, Mar 2, 4:17 AM
Unknown Object (File)
Sun, Mar 1, 6:24 AM
Unknown Object (File)
Sun, Mar 1, 6:01 AM
Unknown Object (File)
Sun, Mar 1, 3:33 AM
Unknown Object (File)
Thu, Feb 26, 4:57 PM
View All 13 Files
Subscribers
imp

Details

Reviewers
olce

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 71022
Build 67905: arc lint + arc unit

Event Timeline

aokblast created this revision.Thu, Feb 26, 7:14 AM
Herald added a subscriber: imp. · View Herald TranscriptThu, Feb 26, 7:14 AM
aokblast requested review of this revision.Thu, Feb 26, 7:14 AM
Harbormaster completed remote builds in B71022: Diff 172756.Thu, Feb 26, 7:14 AM
aokblast added a reviewer: olce.Thu, Feb 26, 7:14 AM
olce requested changes to this revision.Tue, Mar 3, 1:29 PM

Mmm, this change from D55253 is deliberate. Autonomous mode does not work on some AMD CPUs, where setting "desired performance" to 0 actually causes lowest performance to be selected. As long as we do not have a user-understandable way to choose a better default, such as PM profile in ACPI's FADT, let's do like all other CPU freq/power drivers do (except hwpstate_intel(4)) and select maximum performance. Let's revise this only as part of actually implementing one.

This revision now requires changes to proceed.Tue, Mar 3, 1:29 PM
olce added a comment.Tue, Mar 3, 1:33 PM

IOW, that would mean reopening PR 292615.

Revision Contents
Changeset List

PathSize
sys/
x86/
cpufreq/
5 lines

Diff 172756

View Options

sys/x86/cpufreq/hwpstate_amd.c

Loading...