Page MenuHomeFreeBSD
Differential D53918

bus: Add device_has_children predicate
ClosedPublic
Actions

Authored by des on Nov 26 2025, 9:08 AM.
Tags
None
Referenced Files
F160482316: D53918.id167114.diff
Wed, Jun 24, 11:38 PM
Unknown Object (File)
Mon, Jun 22, 5:44 PM
Unknown Object (File)
Thu, Jun 18, 10:10 PM
Unknown Object (File)
Thu, Jun 18, 10:02 PM
Unknown Object (File)
Sat, Jun 13, 7:00 PM
Unknown Object (File)
Sun, May 31, 10:47 PM
Unknown Object (File)
Apr 27 2026, 8:27 PM
Unknown Object (File)
Apr 27 2026, 3:26 PM
View All 72 Files
Subscribers
olce
ziaee

Details

Reviewers
imp
jhb
markj
Group Reviewers
Klara
manpages
Commits
rGc0aeb34d5044: bus: Add device_has_children predicate
rG3cbf6473fa1c: bus: Add device_has_children predicate
rG330d4437f210: bus: Add device_has_children predicate
Summary

Add a device_has_children() function which can be used to check if a
device has children without allocating a list of them which we aren't
going to use, or even counting them.

Also modify device_get_children() so it can be used to query the count
without allocating a list.

MFC after: 1 week
Sponsored by: Klara, Inc.
Sponsored by: NetApp, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68881
Build 65764: arc lint + arc unit

Event Timeline

des created this revision.Nov 26 2025, 9:08 AM
Herald added subscribers: ziaee, olce. · View Herald TranscriptNov 26 2025, 9:08 AM
des requested review of this revision.Nov 26 2025, 9:08 AM
Harbormaster completed remote builds in B68857: Diff 167112.Nov 26 2025, 9:08 AM
des updated this revision to Diff 167113.Nov 26 2025, 9:10 AM

spell EFAULT correctly

Harbormaster completed remote builds in B68858: Diff 167113.Nov 26 2025, 9:10 AM
des updated this revision to Diff 167114.Nov 26 2025, 9:13 AM

update doxygen

Harbormaster completed remote builds in B68859: Diff 167114.Nov 26 2025, 9:13 AM
markj accepted this revision as: markj.Nov 26 2025, 1:49 PM
This revision is now accepted and ready to land.Nov 26 2025, 1:49 PM
imp requested changes to this revision.Nov 26 2025, 3:10 PM

Why not

bool device_has_children(device_t dev) {return (!TAILQ_EMPTY(&dev->children))) }
This revision now requires changes to proceed.Nov 26 2025, 3:10 PM
des added a comment.Nov 27 2025, 8:51 AM

I'm too used to thinking in terms of the least minimum diff to achieve the objective...

des retitled this revision from bus: Allow use of device_get_children as a predicate to bus: Add device_has_children predicate.Nov 27 2025, 9:04 AM
des updated this revision to Diff 167169.Nov 27 2025, 9:05 AM

add device_has_children() like Warner suggested

Harbormaster completed remote builds in B68879: Diff 167169.Nov 27 2025, 9:05 AM
des updated this revision to Diff 167170.Nov 27 2025, 9:07 AM

tweak wording

Harbormaster completed remote builds in B68880: Diff 167170.Nov 27 2025, 9:07 AM
des updated this revision to Diff 167171.Nov 27 2025, 9:11 AM

reorder + style

Harbormaster completed remote builds in B68881: Diff 167171.Nov 27 2025, 9:11 AM
des edited the summary of this revision. (Show Details)Nov 27 2025, 12:23 PM
markj accepted this revision as: markj.Nov 27 2025, 2:24 PM
imp accepted this revision.Nov 28 2025, 6:58 AM

Looks like a lot of whitespace changes unrelated as noted.

sys/sys/bus.h
971

Are these intentional? If so, maybe a separate commit?

This revision is now accepted and ready to land.Nov 28 2025, 6:58 AM
des marked an inline comment as done.Nov 28 2025, 9:10 AM
des added inline comments.
sys/sys/bus.h
971

Yes, they were intentional, and I can drop them.

Closed by commit rG330d4437f210: bus: Add device_has_children predicate (authored by des). · Explain WhyNov 28 2025, 9:18 AM
This revision was automatically updated to reflect the committed changes.
des marked an inline comment as done.
des added a commit: rG330d4437f210: bus: Add device_has_children predicate.
des added a commit: rG3cbf6473fa1c: bus: Add device_has_children predicate.Dec 5 2025, 3:09 PM
des added a commit: rGc0aeb34d5044: bus: Add device_has_children predicate.Dec 5 2025, 6:29 PM

Revision Contents
Changeset List

PathSize
share/
man/
man9/
1 line
47 lines
sys/
kern/
18 lines
sys/
21 lines

Diff 167171

View Options

share/man/man9/Makefile

Loading...
View Options

share/man/man9/device_get_children.9

Loading...
View Options

sys/kern/subr_bus.c

Loading...
View Options

sys/sys/bus.h

Loading...