Page MenuHomeFreeBSD

iwx: don't log VHT rate lookups in iwx_tx_fill_cmd() for data frames
ClosedPublic

Authored by adrian on Sep 28 2025, 3:17 AM.
Referenced Files
F162631251: D52766.diff
Wed, Jul 15, 6:46 AM
F162631250: D52766.diff
Wed, Jul 15, 6:46 AM
Unknown Object (File)
Sun, Jul 12, 5:21 PM
Unknown Object (File)
Tue, Jul 7, 7:56 PM
Unknown Object (File)
Sun, Jul 5, 5:53 AM
Unknown Object (File)
Mon, Jun 29, 6:41 AM
Unknown Object (File)
Fri, Jun 26, 3:54 PM
Unknown Object (File)
Wed, Jun 24, 4:06 PM
Subscribers

Details

Summary

iwx is now logging a lot of stuff to the kernel when associated at VHT
rates. It's my fault; the replacement tx rate APIs print out a warning
when you're handing the legacy rate /HT rate APIs a VHT rate.

However all of the supported chipsets in iwx will be pushing the
rate control entirely into firmware. We don't need to do per-frame
TX rate control like in previous chips.

So for now, just put in an if (rate == VHT) into the path and
a TODO comment. A few lines later the function will just skip the
rate assignment stuff for data frames, thus saving us the logging.
The other paths (control traffic, multicast traffic) uses legacy
rates / HT rates by default and won't trigger a warning log.

Yes, iwx_tx_fill_cmd() really does deserve a rate control logic
rewrite, but I want to fix this particular issue first.

Locally tested:

  • AX210, STA mode, HT and VHT associations

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 67371
Build 64254: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Sep 30 2025, 10:10 AM