Page MenuHomeFreeBSD
Differential D45634

armv6: Remove support for building armv6
ClosedPublic
Actions

Authored by andrew on Jun 19 2024, 5:34 PM.
Tags
None
Referenced Files
F171649862: D45634.id140034.diff
Sat, Sep 12, 10:53 AM
Unknown Object (File)
Thu, Sep 10, 6:35 PM
Unknown Object (File)
Wed, Sep 9, 11:53 AM
Unknown Object (File)
Mon, Sep 7, 6:44 PM
Unknown Object (File)
Mon, Sep 7, 2:52 PM
Unknown Object (File)
Sun, Sep 6, 8:01 PM
Unknown Object (File)
Sat, Sep 5, 3:32 PM
Unknown Object (File)
Wed, Sep 2, 3:14 AM
View All Files
Subscribers
mmel

Details

Reviewers
imp
emaste
lwhsu
mmel
Group Reviewers
ARM
Commits
rG7818c2d37c2c: armv6: Remove support for building armv6
Summary

With it planned that armv7 will be the only 32-bit kernel when 15.0 is
released remove support for armv6.

Remove the top level build infrastructure. It was already removed from
universe, this just stops it from being built directly.

Sponsored by: Arm Ltd

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

andrew requested review of this revision.Jun 19 2024, 5:34 PM
andrew created this revision.
Harbormaster completed remote builds in B58236: Diff 139986.Jun 19 2024, 5:34 PM
mmel added a subscriber: mmel.Jun 19 2024, 5:43 PM
mmel added inline comments.
Makefile
534–535

Do we need both TOOLCHAINS_arm and TOOLCHAIN_armv7? It looks like it's not consistent with the other arches.

imp added a comment.Jun 19 2024, 6:08 PM

Looks good so far, with the one comnent addressed

andrew added a child revision: D45635: nanobsd: Remove armv6 support.Jun 19 2024, 6:12 PM
emaste accepted this revision.Jun 19 2024, 7:28 PM

LGTM; the duplication @mmel points out is curious, but it looks like it's consistent with powerpc

This revision is now accepted and ready to land.Jun 19 2024, 7:28 PM
andrew added a reviewer: lwhsu.Jun 20 2024, 8:28 AM
andrew updated this revision to Diff 140034.Jun 20 2024, 10:25 AM

Rebase + remove TOOLCHAIN_armv7

This revision now requires review to proceed.Jun 20 2024, 10:25 AM
Harbormaster completed remote builds in B58264: Diff 140034.Jun 20 2024, 10:25 AM
emaste accepted this revision.Jun 20 2024, 12:14 PM

Also make sure there's a Relnotes: Yes

This revision is now accepted and ready to land.Jun 20 2024, 12:14 PM
mmel accepted this revision.Jun 20 2024, 4:21 PM
andrew added a comment.Jun 21 2024, 12:17 PM

We should disable armv6-main in CI before committing, otherwise it will likely spam on each commit after this (cc @lwhsu)

lwhsu added a comment.Jun 30 2024, 6:10 PM
In D45634#1041813, @andrew wrote:

We should disable armv6-main in CI before committing, otherwise it will likely spam on each commit after this (cc @lwhsu)

Sorry for the delay, the the main-armv6 job is disabled and the related configurations are removed.

Closed by commit rG7818c2d37c2c: armv6: Remove support for building armv6 (authored by andrew). · Explain WhyJul 12 2024, 11:32 AM
This revision was automatically updated to reflect the committed changes.
andrew added a commit: rG7818c2d37c2c: armv6: Remove support for building armv6.

Revision Contents
Changeset List

PathSize
6 lines
1 line
3 lines
sys/
sys/
2 lines

Diff 140823

View Options

Makefile

Loading...
View Options

Makefile.inc1

Loading...
View Options

UPDATING

Loading...
View Options

sys/sys/param.h

Loading...