Page MenuHomeFreeBSD
Differential D34065

Install unwind.h into /usr/include.
ClosedPublic
Actions

Authored by jhb on Jan 27 2022, 7:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, May 2, 10:52 AM
Unknown Object (File)
Thu, May 2, 2:31 AM
Unknown Object (File)
Sat, Apr 27, 4:11 AM
Unknown Object (File)
Sat, Apr 27, 4:11 AM
Unknown Object (File)
Sat, Apr 27, 4:11 AM
Unknown Object (File)
Sat, Apr 27, 2:53 AM
Unknown Object (File)
Fri, Apr 19, 11:14 AM
Unknown Object (File)
Mar 22 2024, 9:09 PM
View All 43 Files
Subscribers
imp

Details

Reviewers
dim
emaste
brooks
pkubaj
Commits
rGb2127b6f1ae2: Install unwind.h into /usr/include
rGc00d34566536: Install unwind.h into /usr/include
Summary

Install headers from LLVM's libunwind in place of the headers from
libcxxrt and allow C applications to use the library.

As part of this, remove include/unwind.h and switch libthr over to
using the installed unwind.h.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Errors
SeverityLocationCodeMessage
Errorlib/libc++/Makefile:NAME1Bad Filename
Unit
No Test Coverage
Build Status
Buildable 44126
Build 41014: arc lint + arc unit

Event Timeline

jhb created this revision.Jan 27 2022, 7:37 PM
Herald added a subscriber: imp. · View Herald TranscriptJan 27 2022, 7:37 PM
jhb requested review of this revision.Jan 27 2022, 7:37 PM
Harbormaster completed remote builds in B44126: Diff 102011.Jan 27 2022, 7:37 PM
jhb added a comment.Jan 27 2022, 7:39 PM

This is just a small superset of D34005 in that it also deals with include/unwind.h.

emaste added a comment.Jan 27 2022, 7:45 PM

Note exp-run from D34005 is in https://bugs.freebsd.org/261412

emaste added a comment.Jan 27 2022, 7:46 PM

LGTM pending the exp-run

emaste accepted this revision.Feb 9 2022, 9:58 PM
This revision is now accepted and ready to land.Feb 9 2022, 9:58 PM
dim accepted this revision.Feb 10 2022, 5:57 PM

I'm going to commit this, with two minor cosmetic changes:

  • Fill in actual date in ObsoleteFiles.inc
  • Sort INCS list in lib/libgcc_eh/Makefile
This revision was landed with ongoing or failed builds.Feb 11 2022, 12:36 PM
Closed by commit rGc00d34566536: Install unwind.h into /usr/include (authored by jhb, committed by dim). · Explain Why
This revision was automatically updated to reflect the committed changes.
dim added a commit: rGc00d34566536: Install unwind.h into /usr/include.
pkubaj added a comment.Feb 16 2022, 4:54 PM

Could you also MFC this to stable/13?

pkubaj added a comment.Feb 16 2022, 4:55 PM

Nevermind, there is MFC note in the commit.

dim added a comment.Feb 16 2022, 8:21 PM
In D34065#776434, @pkubaj wrote:

Nevermind, there is MFC note in the commit.

Yeah, though this should bake a little longer than 3 days. I also wonder who is going to get the MFC reminder mail, the author (@jhb) or the committer (me) :)

dim added a commit: rGb2127b6f1ae2: Install unwind.h into /usr/include.May 22 2022, 3:56 PM

Revision Contents
Changeset List

PathSize
5 lines
include/
lib/
libc++/
3 lines
libgcc_eh/
4 lines
1 line
libthr/
1 line
tools/
build/
mk/
3 lines

Diff 102011

View Options

ObsoleteFiles.inc

Loading...
View Options

include/unwind.h

Loading...
View Options

lib/libc++/Makefile

Loading...
View Options

lib/libgcc_eh/Makefile

Loading...
View Options

lib/libgcc_eh/Makefile.inc

Loading...
View Options

lib/libthr/Makefile

Loading...
View Options

tools/build/mk/OptionalObsoleteFiles.inc

Loading...