In D53954#1239740, @kevans wrote:

Ok, thanks- to be clear, I'm still not against the idea of providing an abstraction layer to avoid some future headache for MAC modules when the core implementation changes. Did you have some sketch of what you're thinking in the area, by chance?

There's a compile error (missing parenthesis, see inline comment).

Feels much better like that. I have one more inline comment for a change in sysctl_epp_select_per_core(). With that, you can consider the changes reviewed!

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

**No Test Coverage**	<-- this

Build Status

Buildable 69414	
Build 66297: arc lint + arc unit

D54296: PR 291774: expand range of errors reported by libusb_open(3)
Kyua unit tests included in build

Added krb5/util/profile__L back in again. I have yet to test build.

In D54323#1241416, @kib wrote:

Can you pleas explain

1. how the list of missed symbols was obtained

If it's tested etc.
Approved: db

thanks @kib!

D54296: PR 291774: expand range of errors reported by libusb_open(3)
line too long

@jilles did I implement the changes you asked for correctly?

I have to keep sah tree rlocked much deeper, right until the if_input is called finally. Also, the same problem exists for all ESP/AH/IPCOMP processing callbacks.

Also the ports:misc/compat15x needs to be updated.

I have no idea about USB code

Since the module will be built for all arch why not adding the config to sys/conf/files directly ? It's already present in files.amd64 and files.powerpc and now you're adding this to files.arm64, it doesn't make sense.

Can you pleas explain

1. how the list of missed symbols was obtained
2. why do we need the internallib for krb5profile now