pf: Fix state handling when ICMP packets are diverted
ClosedPublic
Actions

Authored by markj on Dec 19 2025, 9:24 PM.

Details

Reviewers

Commits

rG3025957f6556: pf: Fix state handling when ICMP packets are diverted
rG15178d8ed290: pf: Fix state handling when ICMP packets are diverted

Summary

Commit 66f2f1c83247 ("pf: handle divert packets") missed a case that I
happened to hit while testing something.

Add a regression test for the ICMP case, based on the existing case.
Fix a buglet in the existing test (missing whitespace after "[").

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

markj created this revision.Dec 19 2025, 9:24 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptDec 19 2025, 9:24 PM

markj requested review of this revision.Dec 19 2025, 9:24 PM

Harbormaster completed remote builds in B69409: Diff 168461.Dec 19 2025, 9:24 PM

kp accepted this revision.Dec 20 2025, 3:17 PM

This revision is now accepted and ready to land.Dec 20 2025, 3:17 PM

Closed by commit rG15178d8ed290: pf: Fix state handling when ICMP packets are diverted (authored by markj). · Explain WhyDec 22 2025, 2:48 PM

This revision was automatically updated to reflect the committed changes.

markj added a commit: rG15178d8ed290: pf: Fix state handling when ICMP packets are diverted.

markj added a commit: rG3025957f6556: pf: Fix state handling when ICMP packets are diverted.Jan 6 2026, 3:57 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

10 lines

tests/

sys/

netpfil/

pf/

divert-to.sh

40 lines

Diff 168519

View Options

sys/netpfil/pf/pf.c