pf: Fix state handling when ICMP packets are diverted
AcceptedPublic
Actions

Authored by markj on Fri, Dec 19, 9:24 PM.

Details

Reviewers

Summary

Commit 66f2f1c83247 ("pf: handle divert packets") missed a case that I
happened to hit while testing something.

Add a regression test for the ICMP case, based on the existing case.
Fix a buglet in the existing test (missing whitespace after "[").

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 69409
Build 66292: arc lint + arc unit

Event Timeline

markj created this revision.Fri, Dec 19, 9:24 PM

Herald added subscribers: vegeta_tuxpowered.net, glebius, melifaro and 2 others. · View Herald TranscriptFri, Dec 19, 9:24 PM

markj requested review of this revision.Fri, Dec 19, 9:24 PM

Harbormaster completed remote builds in B69409: Diff 168461.Fri, Dec 19, 9:24 PM

kp accepted this revision.Sat, Dec 20, 3:17 PM

This revision is now accepted and ready to land.Sat, Dec 20, 3:17 PM

Revision Contents
Changeset List

Path

Size

sys/

netpfil/

pf/

pf.c

10 lines

tests/

sys/

netpfil/

pf/

divert-to.sh

40 lines

Diff 168461

View Options

sys/netpfil/pf/pf.c