sys/netipsec: ensure sah stability during input callback processing
ClosedPublic
Actions

Authored by kib on Dec 20 2025, 12:06 PM.

Details

Reviewers

Commits

rG183513d15f22: sys/netipsec: ensure sah stability during input callback processing

Summary

Reported by:    ae
Tested by:      ae, Daniel Dubnikov <ddaniel@nvidia.com>
Reviewed by:    Ariel Ehrenberg <aehrenberg@nvidia.com>
Sponsored by:   NVidia networking

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Dec 20 2025, 12:06 PM

Herald added subscribers: glebius, melifaro, imp. · View Herald TranscriptDec 20 2025, 12:06 PM

I have to keep sah tree rlocked much deeper, right until the if_input is called finally, but drop it right before going up to stack. Otherwise, we might recurse on the sah tree lock, since input sometimes needs to send packet, which also enters the ipsec for output. Also, the same problem exists for all ESP/AH/IPCOMP processing callbacks.

ae accepted this revision.Dec 22 2025, 12:22 PM

This revision is now accepted and ready to land.Dec 22 2025, 12:22 PM

I think you should note that this fixes some rare panics, that are reported in derived projects: panic: esp_input_cb: Unexpected address family

Closed by commit rG183513d15f22: sys/netipsec: ensure sah stability during input callback processing (authored by kib). · Explain WhyDec 22 2025, 12:34 PM

This revision was automatically updated to reflect the committed changes.

kib added a commit: rG183513d15f22: sys/netipsec: ensure sah stability during input callback processing.