Page MenuHomeFreeBSD
Differential D56556

arm64/vmm: Make remaining registers use hypctx_*_sys_reg
Needs ReviewPublic
Actions

Authored by kajetan.puchalski_arm.com on Apr 21 2026, 11:09 AM.
Tags
None
Referenced Files
F160667132: D56556.id179463.diff
Fri, Jun 26, 3:07 PM
F160643443: D56556.id180378.diff
Fri, Jun 26, 10:43 AM
F160620856: D56556.id179458.diff
Fri, Jun 26, 7:01 AM
F160607681: D56556.id179466.diff
Fri, Jun 26, 3:53 AM
Unknown Object (File)
Thu, Jun 25, 5:41 PM
Unknown Object (File)
Thu, Jun 25, 5:40 PM
Unknown Object (File)
Thu, Jun 25, 4:30 PM
Unknown Object (File)
Thu, Jun 25, 3:46 PM
View All 95 Files
Subscribers
emaste
imp
rgrimes

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

Move vgic, timer and trapframe registers into sys_regs to handle them
in the same way as all the other registers.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 74149
Build 71032: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B72415: Diff 175979.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a parent revision: D56555: arm64/vmm: Move host-side EL2 regs into sys_regs.
kajetan.puchalski_arm.com updated this revision to Diff 176101.Apr 22 2026, 1:00 PM

Update

Harbormaster completed remote builds in B72440: Diff 176101.Apr 22 2026, 1:00 PM
kajetan.puchalski_arm.com updated this revision to Diff 176107.Apr 22 2026, 1:24 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72446: Diff 176107.Apr 22 2026, 1:24 PM
kajetan.puchalski_arm.com updated this revision to Diff 176256.Apr 23 2026, 2:28 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72474: Diff 176256.Apr 23 2026, 2:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 176262.Apr 23 2026, 2:39 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72480: Diff 176262.Apr 23 2026, 2:39 PM
kajetan.puchalski_arm.com updated this revision to Diff 176278.Apr 23 2026, 5:31 PM

Fix omission

Harbormaster completed remote builds in B72492: Diff 176278.Apr 23 2026, 5:31 PM
kajetan.puchalski_arm.com updated this revision to Diff 176320.Apr 24 2026, 11:09 AM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72512: Diff 176320.Apr 24 2026, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 176728.Apr 28 2026, 2:14 PM

Address remaining style review comments

Harbormaster completed remote builds in B72613: Diff 176728.Apr 28 2026, 2:14 PM
kajetan.puchalski_arm.com updated this revision to Diff 176738.Apr 28 2026, 4:32 PM

Correct register name

Harbormaster completed remote builds in B72615: Diff 176738.Apr 28 2026, 4:32 PM
kajetan.puchalski_arm.com updated this revision to Diff 176988.May 1 2026, 11:10 AM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72700: Diff 176988.May 1 2026, 11:10 AM
kajetan.puchalski_arm.com updated this revision to Diff 177461.May 8 2026, 2:45 PM

Correct nVHE omission

Harbormaster completed remote builds in B72932: Diff 177461.May 8 2026, 2:45 PM
andrew added inline comments.May 18 2026, 1:47 PM
sys/arm64/vmm/hyp.h
113–115 ↗(On Diff #177461)

We should create and use hyp_genassym.c if we need access to the enum from assembly.

kajetan.puchalski_arm.com updated this revision to Diff 178193.May 20 2026, 11:42 AM

Address review comments

Harbormaster completed remote builds in B73280: Diff 178193.May 20 2026, 11:42 AM
kajetan.puchalski_arm.com updated this revision to Diff 178197.May 20 2026, 1:12 PM

Use genassym for assembly offsets

Herald added a subscriber: rgrimes. · View Herald TranscriptMay 20 2026, 1:12 PM
Harbormaster completed remote builds in B73282: Diff 178197.May 20 2026, 1:12 PM
andrew added inline comments.Thu, Jun 4, 2:53 PM
sys/arm64/vmm/arm64.h
65–71

We might need to think about these to not break CHERI

71

Extra whitespace change

kajetan.puchalski_arm.com updated this revision to Diff 179458.Tue, Jun 9, 3:28 PM

Fix indentation

Harbormaster completed remote builds in B73762: Diff 179458.Tue, Jun 9, 3:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 179463.Tue, Jun 9, 3:33 PM

Fix indentation

Harbormaster completed remote builds in B73767: Diff 179463.Tue, Jun 9, 3:33 PM
kajetan.puchalski_arm.com updated this revision to Diff 179466.Tue, Jun 9, 4:35 PM

Fix indentation

Harbormaster completed remote builds in B73770: Diff 179466.Tue, Jun 9, 4:35 PM
kajetan.puchalski_arm.com marked an inline comment as done.Tue, Jun 9, 4:42 PM
kajetan.puchalski_arm.com added inline comments.
sys/arm64/vmm/arm64.h
65–71

Should I just put these in a separate array as part of this patch then?

kajetan.puchalski_arm.com updated this revision to Diff 180378.Tue, Jun 23, 2:43 PM

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74149: Diff 180378.Tue, Jun 23, 2:43 PM
kajetan.puchalski_arm.com marked an inline comment as done.Tue, Jun 23, 2:47 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
48 lines
35 lines
io/
22 lines
46 lines
5 lines
36 lines
6 lines
110 lines
137 lines
69 lines
6 lines
modules/
vmm/
11 lines

Diff 180378

View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/hyp_genassym.c

Loading...
View Options

sys/arm64/vmm/io/vgic_v3.h

Loading...
View Options

sys/arm64/vmm/io/vgic_v3.c

Loading...
View Options

sys/arm64/vmm/io/vtimer.h

Loading...
View Options

sys/arm64/vmm/io/vtimer.c

Loading...
View Options

sys/arm64/vmm/vmm.c

Loading...
View Options

sys/arm64/vmm/vmm_arm64.c

Loading...
View Options

sys/arm64/vmm/vmm_hyp.c

Loading...
View Options

sys/arm64/vmm/vmm_hyp_exception.S

Loading...
View Options

sys/arm64/vmm/vmm_reset.c

Loading...
View Options

sys/modules/vmm/Makefile

Loading...