Details

Reviewers

andrew
manu

Group Reviewers

arm64

Summary

Move vgic, timer and trapframe registers into sys_regs to handle them
in the same way as all the other registers.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 73282
Build 70165: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

Harbormaster completed remote builds in B72415: Diff 175979.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a parent revision: D56555: arm64/vmm: Move host-side EL2 regs into sys_regs.

Update

Harbormaster completed remote builds in B72440: Diff 176101.Apr 22 2026, 1:00 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72446: Diff 176107.Apr 22 2026, 1:24 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72474: Diff 176256.Apr 23 2026, 2:28 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72480: Diff 176262.Apr 23 2026, 2:39 PM

Fix omission

Harbormaster completed remote builds in B72492: Diff 176278.Apr 23 2026, 5:31 PM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72512: Diff 176320.Apr 24 2026, 11:09 AM

Address remaining style review comments

Harbormaster completed remote builds in B72613: Diff 176728.Apr 28 2026, 2:14 PM

Correct register name

Harbormaster completed remote builds in B72615: Diff 176738.Apr 28 2026, 4:32 PM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72700: Diff 176988.May 1 2026, 11:10 AM

Correct nVHE omission

Harbormaster completed remote builds in B72932: Diff 177461.May 8 2026, 2:45 PM

andrew added inline comments.Mon, May 18, 1:47 PM

sys/arm64/vmm/hyp.h
113–115 ↗	(On Diff #177461)	We should create and use `hyp_genassym.c` if we need access to the enum from assembly.

Address review comments

Harbormaster completed remote builds in B73280: Diff 178193.Wed, May 20, 11:42 AM

Use genassym for assembly offsets

Herald added a subscriber: rgrimes. · View Herald TranscriptWed, May 20, 1:12 PM

Harbormaster completed remote builds in B73282: Diff 178197.Wed, May 20, 1:12 PM

andrew added inline comments.Thu, Jun 4, 2:53 PM

sys/arm64/vmm/arm64.h
65–71	We might need to think about these to not break CHERI
87	Extra whitespace change

arm64/vmm: Make remaining registers use hypctx_*_sys_reg
Needs ReviewPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 178197

sys/arm64/vmm/arm64.h

sys/arm64/vmm/hyp_genassym.c

sys/arm64/vmm/io/vgic_v3.h

sys/arm64/vmm/io/vgic_v3.c

sys/arm64/vmm/io/vtimer.h

sys/arm64/vmm/io/vtimer.c

sys/arm64/vmm/vmm.c

sys/arm64/vmm/vmm_arm64.c

sys/arm64/vmm/vmm_hyp.c

sys/arm64/vmm/vmm_hyp_exception.S

sys/arm64/vmm/vmm_reset.c

sys/modules/vmm/Makefile

arm64/vmm: Make remaining registers use hypctx_*_sys_regNeeds ReviewPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 178197

sys/arm64/vmm/arm64.h

sys/arm64/vmm/hyp_genassym.c

sys/arm64/vmm/io/vgic_v3.h

sys/arm64/vmm/io/vgic_v3.c

sys/arm64/vmm/io/vtimer.h

sys/arm64/vmm/io/vtimer.c

sys/arm64/vmm/vmm.c

sys/arm64/vmm/vmm_arm64.c

sys/arm64/vmm/vmm_hyp.c

sys/arm64/vmm/vmm_hyp_exception.S

sys/arm64/vmm/vmm_reset.c

sys/modules/vmm/Makefile

arm64/vmm: Make remaining registers use hypctx_*_sys_reg
Needs ReviewPublic
Actions

Revision Contents
Changeset List