arm64/vmm: Store non-VNCR registers in an array

[kajetan.puchalski_arm.com]

Summary

Move non-VNCR EL0 and EL1 registers into a dedicated array inside of
hypctx. This enables uniform accesses to both VNCR and non-VNCR guest
register state through hypctx_[read|write]_sys_reg().

Signed-off-by: Kajetan Puchalski <[e-mail]>

[kajetan.puchalski_arm.com]

Update with changes to other commits in the stack

[kajetan.puchalski_arm.com]

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

[kajetan.puchalski_arm.com]

Handle non-VHE, store the vncr page as a pointer

[kajetan.puchalski_arm.com]

Fix non-VHE omission

[kajetan.puchalski_arm.com]

Use char* for ptr arithmetic

[kajetan.puchalski_arm.com]

Address remaining style review comments

[kajetan.puchalski_arm.com]

Use Static_assert to ensure correct struct hypctx size

[andrew]

It looks like a few lines passed 80 characters so will need to be split.

sys/arm64/vmm/vmm_hyp.c

123–124

Did this line pass 80 characters?

127–128

Why is an extra tab added here? (and other similar places below)

[kajetan.puchalski_arm.com]

Address review comments

[andrew]

sys/arm64/vmm/vmm_hyp.c

123–125

The second line should be indented the to the same number of tabs + 4 spaces (and below)

[kajetan.puchalski_arm.com]

Fix indentation

[kajetan.puchalski_arm.com]

Fix indentation

[andrew]

sys/arm64/vmm/arm64.h

63–66

These should be in a separate array so the type can be change for Morello

[kajetan.puchalski_arm.com]

Put potentially exotic registers in a separate array

[andrew]

sys/arm64/vmm/arm64.h

187–195

This is confusing two things, one is registers holding a virtual address that will be larger with Morello, the other is physical address registers that will be larger with FEAT_D128.

PAR_EL1 is the only physical address register in this list, so could be removed from here & the range renamed something like VA_REGS.

[kajetan.puchalski_arm.com]

Only separate out registers relevant for morello