Page MenuHomeFreeBSD
Differential D56553

arm64/vmm: Refactor vmm_hyp.c
Needs ReviewPublic
Actions

Authored by kajetan.puchalski_arm.com on Apr 21 2026, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jun 5, 12:39 AM
Unknown Object (File)
Thu, Jun 4, 11:30 PM
Unknown Object (File)
Thu, Jun 4, 8:52 PM
Unknown Object (File)
Thu, Jun 4, 8:10 PM
Unknown Object (File)
Thu, Jun 4, 4:50 PM
Unknown Object (File)
Thu, Jun 4, 6:23 AM
Unknown Object (File)
Thu, Jun 4, 6:23 AM
Unknown Object (File)
Thu, Jun 4, 6:23 AM
View All 77 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

Refactor vmm_hyp.c to split register reload logic by type of register,
streamline the implementation and improve readability.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 73764
Build 70647: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM
Harbormaster completed remote builds in B72412: Diff 175976.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a parent revision: D56552: arm64/vmm: Store non-VNCR registers in an array.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a child revision: D56554: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.
kajetan.puchalski_arm.com updated this revision to Diff 176098.Apr 22 2026, 12:59 PM

Update

Harbormaster completed remote builds in B72437: Diff 176098.Apr 22 2026, 12:59 PM
kajetan.puchalski_arm.com updated this revision to Diff 176104.Apr 22 2026, 1:23 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72443: Diff 176104.Apr 22 2026, 1:23 PM
kajetan.puchalski_arm.com updated this revision to Diff 176253.Apr 23 2026, 2:28 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72471: Diff 176253.Apr 23 2026, 2:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 176259.Apr 23 2026, 2:39 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72477: Diff 176259.Apr 23 2026, 2:39 PM
kajetan.puchalski_arm.com updated this revision to Diff 176275.Apr 23 2026, 5:30 PM

Fix omission

Harbormaster completed remote builds in B72489: Diff 176275.Apr 23 2026, 5:31 PM
kajetan.puchalski_arm.com updated this revision to Diff 176317.Apr 24 2026, 11:09 AM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72509: Diff 176317.Apr 24 2026, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 176725.Apr 28 2026, 2:14 PM

Address remaining style review comments

Harbormaster completed remote builds in B72610: Diff 176725.Apr 28 2026, 2:14 PM
kajetan.puchalski_arm.com updated this revision to Diff 176985.May 1 2026, 11:09 AM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72697: Diff 176985.May 1 2026, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 177458.May 8 2026, 2:44 PM

Correct nVHE omission

Harbormaster completed remote builds in B72929: Diff 177458.May 8 2026, 2:44 PM
andrew added inline comments.Mon, May 18, 1:30 PM
sys/arm64/vmm/vmm_hyp.c
330–335
345–352
kajetan.puchalski_arm.com updated this revision to Diff 178190.Wed, May 20, 11:42 AM

Address review comments

Harbormaster completed remote builds in B73277: Diff 178190.Wed, May 20, 11:42 AM
kajetan.puchalski_arm.com marked 2 inline comments as done.Wed, May 20, 11:46 AM
andrew accepted this revision.Thu, Jun 4, 2:45 PM
This revision is now accepted and ready to land.Thu, Jun 4, 2:45 PM
kajetan.puchalski_arm.com updated this revision to Diff 179455.Tue, Jun 9, 3:28 PM

Fix indentation

This revision now requires review to proceed.Tue, Jun 9, 3:28 PM
Harbormaster completed remote builds in B73759: Diff 179455.Tue, Jun 9, 3:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 179460.Tue, Jun 9, 3:33 PM

Fix indentation

Harbormaster completed remote builds in B73764: Diff 179460.Tue, Jun 9, 3:33 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
6 lines
406 lines

Diff 179460

View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/vmm_hyp.c

Loading...