Page MenuHomeFreeBSD
Differential D56553

arm64/vmm: Refactor vmm_hyp.c
Needs ReviewPublic
Actions

Authored by kajetan.puchalski_arm.com on Tue, Apr 21, 11:09 AM.
Tags
None
Referenced Files
F157281462: D56553.id175976.diff
Tue, May 19, 11:57 PM
Unknown Object (File)
Mon, May 18, 12:39 AM
Unknown Object (File)
Fri, May 15, 11:54 PM
Unknown Object (File)
Fri, May 15, 12:59 PM
Unknown Object (File)
Thu, May 14, 2:26 PM
Unknown Object (File)
Thu, May 14, 12:53 PM
Unknown Object (File)
Thu, May 14, 7:37 AM
Unknown Object (File)
Thu, May 14, 4:24 AM
View All 58 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

Refactor vmm_hyp.c to split register reload logic by type of register,
streamline the implementation and improve readability.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72929
Build 69812: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Tue, Apr 21, 11:09 AM
Herald added a reviewer: andrew. · View Herald TranscriptTue, Apr 21, 11:09 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
kajetan.puchalski_arm.com requested review of this revision.Tue, Apr 21, 11:09 AM
Harbormaster completed remote builds in B72412: Diff 175976.Tue, Apr 21, 11:09 AM
kajetan.puchalski_arm.com added a parent revision: D56552: arm64/vmm: Store non-VNCR registers in an array.Tue, Apr 21, 11:09 AM
kajetan.puchalski_arm.com added a child revision: D56554: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.
kajetan.puchalski_arm.com updated this revision to Diff 176098.Wed, Apr 22, 12:59 PM

Update

Harbormaster completed remote builds in B72437: Diff 176098.Wed, Apr 22, 12:59 PM
kajetan.puchalski_arm.com updated this revision to Diff 176104.Wed, Apr 22, 1:23 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72443: Diff 176104.Wed, Apr 22, 1:23 PM
kajetan.puchalski_arm.com updated this revision to Diff 176253.Thu, Apr 23, 2:28 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72471: Diff 176253.Thu, Apr 23, 2:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 176259.Thu, Apr 23, 2:39 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72477: Diff 176259.Thu, Apr 23, 2:39 PM
kajetan.puchalski_arm.com updated this revision to Diff 176275.Thu, Apr 23, 5:30 PM

Fix omission

Harbormaster completed remote builds in B72489: Diff 176275.Thu, Apr 23, 5:31 PM
kajetan.puchalski_arm.com updated this revision to Diff 176317.Fri, Apr 24, 11:09 AM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72509: Diff 176317.Fri, Apr 24, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 176725.Tue, Apr 28, 2:14 PM

Address remaining style review comments

Harbormaster completed remote builds in B72610: Diff 176725.Tue, Apr 28, 2:14 PM
kajetan.puchalski_arm.com updated this revision to Diff 176985.Fri, May 1, 11:09 AM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72697: Diff 176985.Fri, May 1, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 177458.Fri, May 8, 2:44 PM

Correct nVHE omission

Harbormaster completed remote builds in B72929: Diff 177458.Fri, May 8, 2:44 PM
andrew added inline comments.Mon, May 18, 1:30 PM
sys/arm64/vmm/vmm_hyp.c
304–309
318–325

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
6 lines
428 lines

Diff 177458

View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/vmm_hyp.c

Loading...