Details

Reviewers

andrew
manu

Group Reviewers

arm64

Commits

rGe3cd6d104783: arm64/vmm: Refactor vmm_hyp.c

Summary

Refactor vmm_hyp.c to split register reload logic by type of register,
streamline the implementation and improve readability.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72610
Build 69493: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM

Harbormaster completed remote builds in B72412: Diff 175976.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a parent revision: D56552: arm64/vmm: Store non-VNCR registers in an array.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a child revision: D56554: arm64/vmm: Move vttbr_el2 & vtimer into struct hypctx.

Update

Harbormaster completed remote builds in B72437: Diff 176098.Apr 22 2026, 12:59 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72443: Diff 176104.Apr 22 2026, 1:23 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72471: Diff 176253.Apr 23 2026, 2:28 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72477: Diff 176259.Apr 23 2026, 2:39 PM

Fix omission

Harbormaster completed remote builds in B72489: Diff 176275.Apr 23 2026, 5:31 PM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72509: Diff 176317.Apr 24 2026, 11:09 AM

Address remaining style review comments

Harbormaster completed remote builds in B72610: Diff 176725.Apr 28 2026, 2:14 PM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72697: Diff 176985.May 1 2026, 11:09 AM

Correct nVHE omission

Harbormaster completed remote builds in B72929: Diff 177458.May 8 2026, 2:44 PM

andrew added inline comments.May 18 2026, 1:30 PM

sys/arm64/vmm/vmm_hyp.c
304–309
318–325

Address review comments

Harbormaster completed remote builds in B73277: Diff 178190.May 20 2026, 11:42 AM

kajetan.puchalski_arm.com marked 2 inline comments as done.May 20 2026, 11:46 AM

andrew accepted this revision.Jun 4 2026, 2:45 PM

This revision is now accepted and ready to land.Jun 4 2026, 2:45 PM

Fix indentation

This revision now requires review to proceed.Jun 9 2026, 3:28 PM

Harbormaster completed remote builds in B73759: Diff 179455.Jun 9 2026, 3:28 PM

Fix indentation

Harbormaster completed remote builds in B73764: Diff 179460.Jun 9 2026, 3:33 PM

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74146: Diff 180375.Jun 23 2026, 2:43 PM

Only separate out registers relevant for morello

Harbormaster completed remote builds in B74411: Diff 180982.Tue, Jun 30, 2:17 PM

andrew accepted this revision.Tue, Jun 30, 3:01 PM

This revision is now accepted and ready to land.Tue, Jun 30, 3:01 PM

Closed by commit rGe3cd6d104783: arm64/vmm: Refactor vmm_hyp.c (authored by kajetan.puchalski_arm.com, committed by andrew). · Explain WhyMon, Jul 6, 3:25 PM

This revision was automatically updated to reflect the committed changes.

andrew added a commit: rGe3cd6d104783: arm64/vmm: Refactor vmm_hyp.c.

arm64/vmm: Refactor vmm_hyp.c
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 176725

sys/arm64/vmm/arm64.h

sys/arm64/vmm/vmm_hyp.c

arm64/vmm: Refactor vmm_hyp.cClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 176725

sys/arm64/vmm/arm64.h

sys/arm64/vmm/vmm_hyp.c

arm64/vmm: Refactor vmm_hyp.c
ClosedPublic
Actions

Revision Contents
Changeset List