Details

Reviewers

andrew
manu

Group Reviewers

arm64

Commits

rGd2e3e76ab902: arm64/vmm: Store non-VNCR registers in an array

Summary

Move non-VNCR EL0 and EL1 registers into a dedicated array inside of
hypctx. This enables uniform accesses to both VNCR and non-VNCR guest
register state through hypctx_[read|write]_sys_reg().

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 72470
Build 69353: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added subscribers: emaste, imp. · View Herald Transcript

kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM

Harbormaster completed remote builds in B72411: Diff 175975.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a parent revision: D56551: arm64/vmm: Use the VNCR_EL2 memory page to store guest registers.Apr 21 2026, 11:09 AM

kajetan.puchalski_arm.com added a child revision: D56553: arm64/vmm: Refactor vmm_hyp.c.

kajetan.puchalski_arm.com edited the summary of this revision. (Show Details)Apr 21 2026, 11:30 AM

Update with changes to other commits in the stack

Harbormaster completed remote builds in B72436: Diff 176097.Apr 22 2026, 12:57 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72442: Diff 176103.Apr 22 2026, 1:23 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72470: Diff 176252.Apr 23 2026, 2:28 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72476: Diff 176258.Apr 23 2026, 2:38 PM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72508: Diff 176316.Apr 24 2026, 11:09 AM

Address remaining style review comments

Harbormaster completed remote builds in B72609: Diff 176724.Apr 28 2026, 2:14 PM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72696: Diff 176984.May 1 2026, 11:09 AM

It looks like a few lines passed 80 characters so will need to be split.

sys/arm64/vmm/vmm_hyp.c
123	Did this line pass 80 characters?
127	Why is an extra tab added here? (and other similar places below)

Address review comments

Harbormaster completed remote builds in B73276: Diff 178189.May 20 2026, 11:42 AM

kajetan.puchalski_arm.com marked 2 inline comments as done.May 20 2026, 11:45 AM

andrew added inline comments.Jun 4 2026, 2:34 PM

sys/arm64/vmm/vmm_hyp.c
123–124	The second line should be indented the to the same number of tabs + 4 spaces (and below)

Fix indentation

Harbormaster completed remote builds in B73758: Diff 179454.Jun 9 2026, 3:28 PM

Fix indentation

Harbormaster completed remote builds in B73763: Diff 179459.Jun 9 2026, 3:33 PM

andrew added inline comments.Jun 23 2026, 10:54 AM

sys/arm64/vmm/arm64.h
63–66	These should be in a separate array so the type can be change for Morello

Put potentially exotic registers in a separate array

Harbormaster completed remote builds in B74145: Diff 180374.Jun 23 2026, 2:43 PM

kajetan.puchalski_arm.com marked an inline comment as done.Jun 23 2026, 2:45 PM

andrew added inline comments.Jun 24 2026, 3:46 PM

sys/arm64/vmm/arm64.h
194–202	This is confusing two things, one is registers holding a virtual address that will be larger with Morello, the other is physical address registers that will be larger with `FEAT_D128`. `PAR_EL1` is the only physical address register in this list, so could be removed from here & the range renamed something like `VA_REGS`.