Page MenuHomeFreeBSD
Differential D56556

arm64/vmm: Make remaining registers use hypctx_*_sys_reg
Needs ReviewPublic
Actions

Authored by kajetan.puchalski_arm.com on Apr 21 2026, 11:09 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 22, 7:46 AM
Unknown Object (File)
Sun, May 17, 12:15 PM
Unknown Object (File)
Thu, May 14, 3:27 PM
Unknown Object (File)
Thu, May 14, 2:43 PM
Unknown Object (File)
Thu, May 14, 12:34 PM
Unknown Object (File)
Thu, May 14, 4:44 AM
Unknown Object (File)
Thu, May 14, 3:32 AM
Unknown Object (File)
Thu, May 14, 1:37 AM
View All 63 Files
Subscribers
emaste
imp
rgrimes

Details

Reviewers
andrew
manu
Group Reviewers
arm64
Summary

Move vgic, timer and trapframe registers into sys_regs to handle them
in the same way as all the other registers.

Signed-off-by: Kajetan Puchalski <kajetan.puchalski@arm.com>

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 72480
Build 69363: arc lint + arc unit

Event Timeline

kajetan.puchalski_arm.com created this revision.Apr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald TranscriptApr 21 2026, 11:09 AM
Herald added a reviewer: andrew. · View Herald Transcript
Herald added a reviewer: manu. · View Herald Transcript
Herald added subscribers: emaste, imp. · View Herald Transcript
Harbormaster completed remote builds in B72415: Diff 175979.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com requested review of this revision.Apr 21 2026, 11:09 AM
kajetan.puchalski_arm.com added a parent revision: D56555: arm64/vmm: Move host-side EL2 regs into sys_regs.
kajetan.puchalski_arm.com updated this revision to Diff 176101.Apr 22 2026, 1:00 PM

Update

Harbormaster completed remote builds in B72440: Diff 176101.Apr 22 2026, 1:00 PM
kajetan.puchalski_arm.com updated this revision to Diff 176107.Apr 22 2026, 1:24 PM

Encode VNCR values into enum hypctx_sysreg as 64-bit offsets

Harbormaster completed remote builds in B72446: Diff 176107.Apr 22 2026, 1:24 PM
kajetan.puchalski_arm.com updated this revision to Diff 176256.Thu, Apr 23, 2:28 PM

Handle non-VHE, store the vncr page as a pointer

Harbormaster completed remote builds in B72474: Diff 176256.Thu, Apr 23, 2:28 PM
kajetan.puchalski_arm.com updated this revision to Diff 176262.Thu, Apr 23, 2:39 PM

Fix non-VHE omission

Harbormaster completed remote builds in B72480: Diff 176262.Thu, Apr 23, 2:39 PM
kajetan.puchalski_arm.com updated this revision to Diff 176278.Thu, Apr 23, 5:31 PM

Fix omission

Harbormaster completed remote builds in B72492: Diff 176278.Thu, Apr 23, 5:31 PM
kajetan.puchalski_arm.com updated this revision to Diff 176320.Fri, Apr 24, 11:09 AM

Use char* for ptr arithmetic

Harbormaster completed remote builds in B72512: Diff 176320.Fri, Apr 24, 11:09 AM
kajetan.puchalski_arm.com updated this revision to Diff 176728.Tue, Apr 28, 2:14 PM

Address remaining style review comments

Harbormaster completed remote builds in B72613: Diff 176728.Tue, Apr 28, 2:14 PM
kajetan.puchalski_arm.com updated this revision to Diff 176738.Tue, Apr 28, 4:32 PM

Correct register name

Harbormaster completed remote builds in B72615: Diff 176738.Tue, Apr 28, 4:32 PM
kajetan.puchalski_arm.com updated this revision to Diff 176988.Fri, May 1, 11:10 AM

Use Static_assert to ensure correct struct hypctx size

Harbormaster completed remote builds in B72700: Diff 176988.Fri, May 1, 11:10 AM
kajetan.puchalski_arm.com updated this revision to Diff 177461.Fri, May 8, 2:45 PM

Correct nVHE omission

Harbormaster completed remote builds in B72932: Diff 177461.Fri, May 8, 2:45 PM
andrew added inline comments.Mon, May 18, 1:47 PM
sys/arm64/vmm/hyp.h
113–115

We should create and use hyp_genassym.c if we need access to the enum from assembly.

kajetan.puchalski_arm.com updated this revision to Diff 178193.Wed, May 20, 11:42 AM

Address review comments

Harbormaster completed remote builds in B73280: Diff 178193.Wed, May 20, 11:42 AM
kajetan.puchalski_arm.com updated this revision to Diff 178197.Wed, May 20, 1:12 PM

Use genassym for assembly offsets

Herald added a subscriber: rgrimes. · View Herald TranscriptWed, May 20, 1:12 PM
Harbormaster completed remote builds in B73282: Diff 178197.Wed, May 20, 1:12 PM

Revision Contents
Changeset List

PathSize
sys/
arm64/
vmm/
61 lines
4 lines
io/
22 lines
46 lines
5 lines
36 lines
6 lines
80 lines
88 lines
68 lines
6 lines

Diff 176262

View Options

sys/arm64/vmm/arm64.h

Loading...
View Options

sys/arm64/vmm/hyp.h

Loading...
View Options

sys/arm64/vmm/io/vgic_v3.h

Loading...
View Options

sys/arm64/vmm/io/vgic_v3.c

Loading...
View Options

sys/arm64/vmm/io/vtimer.h

Loading...
View Options

sys/arm64/vmm/io/vtimer.c

Loading...
View Options

sys/arm64/vmm/vmm.c

Loading...
View Options

sys/arm64/vmm/vmm_arm64.c

Loading...
View Options

sys/arm64/vmm/vmm_hyp.c

Loading...
View Options

sys/arm64/vmm/vmm_hyp_exception.S

Loading...
View Options

sys/arm64/vmm/vmm_reset.c

Loading...