LinuxKPI: bitcount fix gcc and older llvm builds
AcceptedPublic
Actions

Authored by bz on Thu, Dec 18, 10:28 PM.

Details

Reviewers

dumbbell
imp
brooks
emaste

Group Reviewers

linuxkpi

Summary

LLVM before 19 and gcc before 14 do not support builtin_popcountg().
Use const_bitcount<n> from sys/bitcount.h as a replacement in these
cases. This should still allow drm-kmod to build with size to be known
at compile-time.

Sponsored by: The FreeBSD Foundation
Fixes: 7cbc4d875971, 5e0a4859f28a
MFC after: 3 days
X-MFC: remove sys/modules/Makefile checks

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 69385
Build 66268: arc lint + arc unit

Event Timeline

bz created this revision.Thu, Dec 18, 10:28 PM

Herald added a subscriber: emaste. · View Herald TranscriptThu, Dec 18, 10:28 PM

bz requested review of this revision.Thu, Dec 18, 10:28 PM

Harbormaster completed remote builds in B69385: Diff 168371.Thu, Dec 18, 10:28 PM

I found @dumbbell initial replacement suggestion here still: https://github.com/freebsd/freebsd-src/commit/c5b671a393950f98b83089a42a9f1d69f7b9ce9c

And that makes me find that __const_bitcount<n> is another local change; I'll update this in a minute

Added https://reviews.freebsd.org/D54301 as well.

Adding @emaste as I found @dumbbell 's version through the stack of local changes you carry.

And for reference; pushing this out was triggered by https://reviews.freebsd.org/D54266

brooks accepted this revision.Fri, Dec 19, 9:55 AM

This revision is now accepted and ready to land.Fri, Dec 19, 9:55 AM

brooks mentioned this in D54266: iwlwifi: Don't compile for clang before 19.Fri, Dec 19, 9:56 AM

Revision Contents
Changeset List

Path

Size

sys/

compat/

linuxkpi/

common/

include/

linux/

bitops.h

8 lines

Diff 168371

View Options

sys/compat/linuxkpi/common/include/linux/bitops.h

LinuxKPI: bitcount fix gcc and older llvm buildsAcceptedPublicActions