Page MenuHomeFreeBSD

Don't build and install {llvm,clang,lldb}-tblgen for the target
ClosedPublic

Authored by arichardson on Jul 5 2021, 5:22 PM.

Details

Summary

The tablegen binaries are only needed to build software that uses
LLVM's infrastructure for command line options,
disassembler tables, etc. They are not user-facing binaries and
should therefore not be installed by default.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fine with me, assuming these are built using a different mechanism for the build toolchain itself.

arichardson added a subscriber: jrtc27.

Address latest @jrtc27 feedback

sorry accidentally updated the wrong review.

This revision is now accepted and ready to land.Aug 6 2021, 3:22 PM

While this is OK, I think we may even consider to avoid installing any of the tblgen tools *at all* in the base system. Other "extras" tools like llc, llvm-mc etc are usable by themselves, whereas the tblgen tools are really only needed for building llvm-project components.

That said, can you also add an entry to OptionalObsoleteFiles.inc for these? So they get cleaned up everybody that has MK_CLANG_EXTRAS=no.

don't install the tools at all

This revision now requires review to proceed.Aug 16 2021, 8:27 AM
arichardson retitled this revision from Only build {llvm,clang,lldb}-tblgen for the target with MK_CLANG_EXTRAS to Don't build and install {llvm,clang,lldb}-tblgen for the target.Aug 16 2021, 8:29 AM
arichardson edited the summary of this revision. (Show Details)

ping @dim ?

ObsoleteFiles.inc
42

will update date prior to committing.

This revision is now accepted and ready to land.Aug 30 2021, 3:34 PM