Details

Reviewers

dim
emaste

Commits

rG5761fecb4ee3: Don't build and install {llvm,clang,lldb}-tblgen for the target
rG5814e2ba97a1: Don't build and install {llvm,clang,lldb}-tblgen for the target
rG8e1c989abbd1: Don't build and install {llvm,clang,lldb}-tblgen for the target

Summary

The tablegen binaries are only needed to build software that uses
LLVM's infrastructure for command line options,
disassembler tables, etc. They are not user-facing binaries and
should therefore not be installed by default.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 41055
Build 37944: arc lint + arc unit

Event Timeline

arichardson created this revision.Jul 5 2021, 5:22 PM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 5:22 PM

arichardson requested review of this revision.Jul 5 2021, 5:22 PM

Harbormaster completed remote builds in B40313: Diff 91811.Jul 5 2021, 5:22 PM

arichardson added a child revision: D31060: Add WITH_LLVM_BINUTILS to install LLVM binutils instead of Elftoolchain.Jul 5 2021, 5:45 PM

ping?

Fine with me, assuming these are built using a different mechanism for the build toolchain itself.

Address latest @jrtc27 feedback

Harbormaster completed remote builds in B40539: Diff 92442.Jul 19 2021, 10:36 PM

sorry accidentally updated the wrong review.

restore previous revision

Harbormaster completed remote builds in B40541: Diff 92444.Jul 19 2021, 10:41 PM

@dim does this look okay?

emaste accepted this revision.Aug 6 2021, 3:22 PM

This revision is now accepted and ready to land.Aug 6 2021, 3:22 PM

While this is OK, I think we may even consider to avoid installing any of the tblgen tools *at all* in the base system. Other "extras" tools like llc, llvm-mc etc are usable by themselves, whereas the tblgen tools are really only needed for building llvm-project components.

That said, can you also add an entry to OptionalObsoleteFiles.inc for these? So they get cleaned up everybody that has MK_CLANG_EXTRAS=no.

don't install the tools at all

This revision now requires review to proceed.Aug 16 2021, 8:27 AM

Harbormaster completed remote builds in B41055: Diff 93736.Aug 16 2021, 8:27 AM

arichardson retitled this revision from Only build {llvm,clang,lldb}-tblgen for the target with MK_CLANG_EXTRAS to Don't build and install {llvm,clang,lldb}-tblgen for the target.Aug 16 2021, 8:29 AM

arichardson edited the summary of this revision. (Show Details)

arichardson added a parent revision: D31531: Fix bootstrapping to actually build lldb-tblgen for later use.Aug 16 2021, 8:32 AM

ping @dim ?