Page MenuHomeFreeBSD

Fix building rescue/rescue when sanitizers are enabled
ClosedPublic

Authored by arichardson on Jul 5 2021, 10:51 AM.

Details

Summary

We have to ensure that we don't link any instrumented object files
into rescue as it is a static executable and static binaries can't
use the sanitizer runtime.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

imp added inline comments.
rescue/rescue/Makefile
117

do you happen to know why ${LIBIPF} fails in this context?

This revision is now accepted and ready to land.Jul 6 2021, 1:15 AM
rescue/rescue/Makefile
117

It was selecting the _pie.a library that has ASAN instrumentation. Actually this might no longer be needed with the
CRUNCH_BUILDOPTS+= MK_PIE=no line above (my initial patch only had NO_SHARED=yes)

This revision now requires review to proceed.Jul 6 2021, 11:05 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jul 6 2021, 1:30 PM
This revision was automatically updated to reflect the committed changes.