Fix building rescue/rescue when sanitizers are enabled
ClosedPublic
Actions

Authored by arichardson on Jul 5 2021, 10:51 AM.

Details

Reviewers

Commits

rG120f0a029e26: Fix building rescue/rescue when sanitizers are enabled
rG2eefc1d92643: Fix building rescue/rescue when sanitizers are enabled

Summary

We have to ensure that we don't link any instrumented object files
into rescue as it is a static executable and static binaries can't
use the sanitizer runtime.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

arichardson created this revision.Jul 5 2021, 10:51 AM

Herald added a subscriber: imp. · View Herald TranscriptJul 5 2021, 10:51 AM

arichardson requested review of this revision.Jul 5 2021, 10:51 AM

Harbormaster completed remote builds in B40292: Diff 91775.Jul 5 2021, 10:51 AM

arichardson added a parent revision: D31043: Add build system support for ASAN+UBSAN instrumentation.Jul 5 2021, 10:51 AM

imp accepted this revision.Jul 6 2021, 1:15 AM

imp added inline comments.

rescue/rescue/Makefile
117	do you happen to know why ${LIBIPF} fails in this context?

This revision is now accepted and ready to land.Jul 6 2021, 1:15 AM

arichardson added inline comments.Jul 6 2021, 8:38 AM

rescue/rescue/Makefile
117	It was selecting the _pie.a library that has ASAN instrumentation. Actually this might no longer be needed with the `CRUNCH_BUILDOPTS+= MK_PIE=no` line above (my initial patch only had NO_SHARED=yes)