Page MenuHomeFreeBSD

libc: Disable ASAN for certain string functions
ClosedPublic

Authored by arichardson on Jul 5 2021, 10:52 AM.

Details

Summary

They deliberately read out-of-bounds values to avoid byte-by-byte
loads and check multiple bytes at once. While this will work on x86,
it is flagged as an out-of-bounds read with ASAN, so we have to
disable instrumentation here. This also causes bounds errors for CHERI,
so in CheriBSD we use implementations that avoid OOB reads.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

arichardson retitled this revision from libc: Disable ASAN for certain str* functions to libc: Disable ASAN for certain string functions.Jul 5 2021, 5:42 PM
This revision was not accepted when it landed; it landed in state Needs Review.Aug 2 2021, 1:35 PM
This revision was automatically updated to reflect the committed changes.