From a style perspective, the use of __result_use_check is inconsistent, in one file it appears at the end, in the other it appears right after the return type. I think some of the lines are also over 80 colums.

In D39620#1008905, @sean_rogue-research.com wrote:

stable/13 has this patch
releng/13.2 doesn't have this patch (yet).

I'm not very familiar with FreeBSD's branching system... I see FreeBSD 13.3-RELEASE was released today, is this bug fix included?

stable/13 has this patch
releng/13.2 doesn't have this patch (yet).

Thanks to all of you for moving this along so swiftly! I've already started working on the next iteration. Will post that soon.

Thanks again!

Combining Ed's and Rod's feedback on processors: removing controversial paragraph on Intel architecture

I asked some doc committers on IRC to have a look.

• Updated paragraph on CPU architecture to reference Nehalem instead.
• Added --usage reference for vmstart.sh
• Fixed disconnect key sequence for cu

Its getting much better, probably with pushing a commit soon.

Included the relevant feedback points into this latest update. Thanks for the great inputs. Any further inputs/feedback welcome!

And finally condensed the processor feature constraints into a simpler and shorter statement.

Included additional updates after Rod's feedback. Thanks for the inputs!

Sorry, just realized I missed the -U99999; included this now.

Updates after initial feedback - also fixed version of ISO files in the command line listings.

Oh, one other comment - when you regenerate the new patch please use -U999999 to get full context - Phabricator will then allow the reader to expand the blocks in between what's been changed.

Just some nits.

Thanks for the great feedback. I'll update the patch accordingly.

Thanks. These are nice updates. I added a few mostly nit-picky comments and added a few other reviewers.

Move vm_snapshot_buf_cmp prototype under #ifndef _KERNEL.

Looks good to me, aside from the comment.

removed vm_snapshot_buf_cmp() in the kernel code

Removed vm_snapshot_buf_cmp() function in the kernel code.

In D43218#985321, @rew wrote:

In D43218#985292, @markj wrote:

This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.

I went ahead and took care of these, hopefully you don't mind.

In D43218#985292, @markj wrote:

This seems fine as a stopgap. If you mail me git patches for this and the MTRR review, I'll apply them.