It would be even better to remove all of these devices from the hints entirely.
We're well past the time when they are needed as a fallback. We should move all the isa hints to isa.hints and allow people with really old, non ACPI or broken ACPI systems to load it.
Plus, in -current, all of those are gone. Only atkbdc remains (and it should go too)

I think I must have not realized that the author of this patch wasn't a committer. Sorry James, I've committed this now!

This revision has landed

OK. This looks ready to go then. Sorry for my slowness in responding

I think this is ready now, so I'll land it.
I'm satisfied that old-school construct was for our old-school 4.2 gcc, which has aged out of support everywhere.

I can test on AMD64 (currently using it) and ARM64 and i386. I might be able to do BE PPC64.

Hey John do you want to land this or should I?

The commit log though can say "Remove pre-C99 support" though since the blocks are all for pre-C99.

This looks ok to me now.

Looks good to me.

Build Success

git rebase main

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

Removed redundant macros

Add __STDC_VERSION_STDBOOL_H__ as the header file now conforms C23.

Fix grammar in the commit message

Fixed by 5f757f3ff9144b609b3c433dfd370cc6bdc191ad and cb14a3fe5122c879eae1fb480ed7ce82a699ddb6

When will we merge the upstream llvm-project to freebsd-src? Are there any issues blocking the merge?

Fixed macro

@jrtc27 Can you review the changes?

D43545 takes care of this change. Should we close this?

Are there any more changes required?