Page MenuHomeFreeBSD
Feed Advanced Search

Yesterday

nikola.lecic_anthesphoria.net added a comment to D16698: First draft HID over I2C support (Mouse only).
  1. I compiled this driver with EVDEV support (https://gist.github.com/johalun/3c67a678e740b82512cec52bfe926092). How can I make use of it? I see no difference with and without this patch.

If there's a new device in /dev/input, it is working. You can run libinput debug-events to see the input events. To consume evdev devices from xorg, use xf86-input-libinput. There were patches for autodetection (one adding evdev autodetection to the devd backend, another switching to the udev backend with libudev-devd). The devd one might have been merged?? (I don't follow Xorg, I use Wayland exclusively)

Wed, Jul 17, 10:48 PM · Contributor Reviews (base)
greg_unrelenting.technology added a comment to D16698: First draft HID over I2C support (Mouse only).
  1. I compiled this driver with EVDEV support (https://gist.github.com/johalun/3c67a678e740b82512cec52bfe926092). How can I make use of it? I see no difference with and without this patch.
Wed, Jul 17, 1:06 AM · Contributor Reviews (base)

Tue, Jul 16

nikola.lecic_anthesphoria.net added a comment to D16698: First draft HID over I2C support (Mouse only).

... please note that I edited my last post; touchpad is working again after test #3.

Tue, Jul 16, 7:33 PM · Contributor Reviews (base)
nikola.lecic_anthesphoria.net added a comment to D16698: First draft HID over I2C support (Mouse only).

Many thanks for your efforts! My laptop: Asus Zenbook 14 UX410UFR with 12.0-RELEASE. After kldload ig4 iic acpi_iichid the device works after being probed with i2c -v -s -f /dev/iic1 (thanks fbsd_opal.com). My /var/log/messages:

Could you post the full output of the i2c -v -s -f /dev/iic1 command? I just checked the implementation and i2c either uses START/STOP or reads a byte to perform a scan per address. On my laptop (using ig4), I get the following output and I think it looks similar on yours.

dev: /dev/iic1, addr: 0x0, r/w: r, offset: 0x00, width: 8, count: 1
Hardware may not support START/STOP scanning; trying less-reliable read method.
Scanning I2C devices on /dev/iic1: 2c

Tue, Jul 16, 5:45 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Many thanks for your efforts! My laptop: Asus Zenbook 14 UX410UFR with 12.0-RELEASE. After kldload ig4 iic acpi_iichid the device works after being probed with i2c -v -s -f /dev/iic1 (thanks fbsd_opal.com). My /var/log/messages:

Tue, Jul 16, 3:17 PM · Contributor Reviews (base)

Mon, Jul 15

nikola.lecic_anthesphoria.net added a comment to D16698: First draft HID over I2C support (Mouse only).

Many thanks for your efforts! My notebook: Asus Zenbook 14 UX410UFR with 12.0-RELEASE. After kldload ig4 iic acpi_iichid the device works after being checked with i2c -v -s -f /dev/iic1 (thanks fbsd_opal.com). My /var/log/messages:

Mon, Jul 15, 1:07 AM · Contributor Reviews (base)

Mon, Jul 8

wulf added a comment to D16698: First draft HID over I2C support (Mouse only).

Oh, nice. Your iichid_identify() method is basically identical to what I wrote. You're right, it does not strictly require a separate module, it just seemed cleaner to have a generic acpi_iichid bus.

I don't object to acpi_iichid module existence. It just adds an extra requirements for module load order which I was not able to solve quickly.

I think it would be best to try and base the ims driver on top of your code. Are you interested in trying to integrate them?

Yes, I am going to submit this code to the project when it will be ready, so it is better to have it insync with ims

Mon, Jul 8, 11:15 PM · Contributor Reviews (base)
markj added a comment to D16698: First draft HID over I2C support (Mouse only).
In D16698#452631, @wulf wrote:

I wrote a driver for I2C MT touchscreens https://github.com/wulf7/iichid which is heavily based on the code in this review.
It does not require dedicated ACPI module at all and has some I2C/HID layers separation which is missed in current review.
So I think it may have sense to join efforts and codebases

Mon, Jul 8, 10:19 PM · Contributor Reviews (base)
wulf added a comment to D16698: First draft HID over I2C support (Mouse only).

I wrote a driver for I2C MT touchscreens https://github.com/wulf7/iichid which is heavily based on the code in this review.
It does not require dedicated ACPI module at all and has some I2C/HID layers separation which is missed in current review.
So I think it may have sense to join efforts and codebases

Mon, Jul 8, 10:06 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

I reuploaded the full patch with a sysctl (power_state) added.
Setting

Mon, Jul 8, 9:07 PM · Contributor Reviews (base)
fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

I just looked into Microsoft's HID over I2C specification document again. Section 8.2 deals with "Host Initiated Power Optimizations" (HIPO). There, sleep and on are explicitly stated as modes that the host should take care of:
Quote: [1]

The HOST is responsible for optimizing the power of the overall system and the DEVICE. This method of power optimization is to be used when the HOST wishes to provide power optimization notifications to devices.
The following power states are defined for HIPO and are not to be confused with vendor specific DIPO states.

• ON
• SLEEP

Section 7.2.8 specifies the SET_POWER command, so the DEVMETHODs device_suspend and device_resume should implement sleep and wakeup transitions for the human interface device. In addition, the device is not required to respond to the SET_POWER command, so it could be implemented fairly easy. Probably something like this (untested):

static int
iichid_write_register(device_t dev, uint8_t* cmd, int cmdlen)
static int
iichid_set_power(device_t dev, struct i2c_hid_desc* hid_desc, bool sleep)
Mon, Jul 8, 12:51 PM · Contributor Reviews (base)

Sun, Jul 7

markj added a comment to D16698: First draft HID over I2C support (Mouse only).

Hmm, I think I did not intend to create a new diff. Should I reupload, or can it be merged?

Sun, Jul 7, 4:12 PM · Contributor Reviews (base)

Sat, Jul 6

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Hmm, I think I did not intend to create a new diff. Should I reupload, or can it be merged?

Sat, Jul 6, 10:06 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com updated the diff for D16698: First draft HID over I2C support (Mouse only).
Sat, Jul 6, 9:55 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Do you have a license header for iichid.c?

Sat, Jul 6, 9:38 PM · Contributor Reviews (base)
markj added a comment to D16698: First draft HID over I2C support (Mouse only).

#1

The acpi_iichid driver needs to be rewritten. It should be a child of the iic bus, not the acpi bus. I've started working on this.

I will submit to the more experienced developers on this point, for completeness I would still like to include my findings here:

  • The I2C Bus is not enumerable, which means that the driver won't be attached automatically if it is a child of iicbus.
Sat, Jul 6, 8:11 PM · Contributor Reviews (base)
marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

#1

The acpi_iichid driver needs to be rewritten. It should be a child of the iic bus, not the acpi bus. I've started working on this.

Sat, Jul 6, 7:37 PM · Contributor Reviews (base)
markj added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.

Sat, Jul 6, 3:41 PM · Contributor Reviews (base)
fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.

Sat, Jul 6, 10:38 AM · Contributor Reviews (base)
seanc added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.

Sat, Jul 6, 7:02 AM · Contributor Reviews (base)

Fri, Jun 28

bcran closed D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Fri, Jun 28, 1:19 AM · Contributor Reviews (base), arm64
bcran closed D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Fri, Jun 28, 1:17 AM · Contributor Reviews (base), arm64
bcran accepted D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Fri, Jun 28, 1:14 AM · Contributor Reviews (base), arm64
bcran added a comment to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.
Fri, Jun 28, 1:10 AM · Contributor Reviews (base), arm64

Thu, Jun 27

greg_unrelenting.technology added a comment to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.

I just tried booting with this patch applied and with EDK2 firmware built from master yesterday, and I still don't see any output - both with devicetree and acpi.

Thu, Jun 27, 10:56 PM · Contributor Reviews (base), arm64
bcran added a comment to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms.

I just tried booting with this patch applied and with EDK2 firmware built from master yesterday, and I still don't see any output - both with devicetree and acpi.

Thu, Jun 27, 6:49 PM · Contributor Reviews (base), arm64
D20775: Add missing ACPI GICv2 MSI/MSI-X attachment is now accepted and ready to land.
Thu, Jun 27, 6:22 AM · Contributor Reviews (base), arm64

Wed, Jun 26

greg_unrelenting.technology retitled D20775: Add missing ACPI GICv2 MSI/MSI-X attachment from Add missing ACPI GICv2 MSI/MSI-X support to Add missing ACPI GICv2 MSI/MSI-X attachment.
Wed, Jun 26, 8:54 PM · Contributor Reviews (base), arm64
greg_unrelenting.technology updated subscribers of D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Wed, Jun 26, 8:52 PM · Contributor Reviews (base), arm64
greg_unrelenting.technology updated the test plan for D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Wed, Jun 26, 8:51 PM · Contributor Reviews (base), arm64
greg_unrelenting.technology added a project to D20765: Add ACPI entries for Synopsys Designware UARTs used on ARM platforms: Contributor Reviews (base).
Wed, Jun 26, 8:48 PM · Contributor Reviews (base), arm64
greg_unrelenting.technology created D20775: Add missing ACPI GICv2 MSI/MSI-X attachment.
Wed, Jun 26, 8:47 PM · Contributor Reviews (base), arm64

Mon, Jun 24

fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

By the way, there is an error in the diff of sys/conf/files in this D16698 patch:

Mon, Jun 24, 8:25 AM · Contributor Reviews (base)

Sun, Jun 23

fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Could anyone affected by the issue give the patch here a try? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238037

Sun, Jun 23, 8:04 PM · Contributor Reviews (base)
markj added a comment to D16698: First draft HID over I2C support (Mouse only).

Could anyone affected by the issue give the patch here a try? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238037

Sun, Jun 23, 7:48 PM · Contributor Reviews (base)
fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

I've been playing around with it here https://gist.github.com/johalun/ffc271a07a0cf50d0bc816138c4eec81 but still no success. Basically there are no interrupts from the device after resume. I don't know if this is because ig4 or the i2c device missing some kind of reset command. I found something in MS docs about sending an i2c reset command which you can see in the resume function but it doesn't do anything which makes me think that ig4 is the problem. Here I simply copy/paste the routine from the attach function to resume but not sure that's enough. Probably need to spend some times reading reference manual for the devices.

Sun, Jun 23, 7:45 PM · Contributor Reviews (base)
johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

I've been playing around with it here https://gist.github.com/johalun/ffc271a07a0cf50d0bc816138c4eec81 but still no success. Basically there are no interrupts from the device after resume. I don't know if this is because ig4 or the i2c device missing some kind of reset command. I found something in MS docs about sending an i2c reset command which you can see in the resume function but it doesn't do anything which makes me think that ig4 is the problem. Here I simply copy/paste the routine from the attach function to resume but not sure that's enough. Probably need to spend some times reading reference manual for the devices.

Sun, Jun 23, 7:17 PM · Contributor Reviews (base)
fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

After suspend/resume, all input broken (ims mouse, ums mouse and also keyboard), so need hard reboot to resolve.

Sun, Jun 23, 6:13 PM · Contributor Reviews (base)
fbsd_opal.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thank you very much Marc. I have been waiting for this and really appreciate your work.
It works almost for me on an ASUS UX310. Sometimes after boot I need to load the iic kernel module and scan the bus using i2c -s -f /dev/iic1.
Furthermore two finger scrolling does not work but it seems to be recognized. At least the cursor does not move during scrolling. The middle mouse button does not work as well.
...

Sun, Jun 23, 2:08 PM · Contributor Reviews (base)

May 24 2019

markj removed a member for Contributor Reviews (base): markj.
May 24 2019, 3:01 PM

May 8 2019

manu closed D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 3:43 PM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.

Tinh Nguyen from Ampere tested and it doesn't seems to make usb working (xhci controller is discovered but nothing more), I've tried on my overdrive in FDT mode and it works.
In acpi mode this doesn't but it doesn't without this patch too, looks like the acpi table is missing info about interrupts, I'll do one more test on the macchiatobin and then commit this.

May 8 2019, 2:05 PM · arm64, Contributor Reviews (base)
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 1:59 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 11:48 AM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.
May 8 2019, 11:47 AM · arm64, Contributor Reviews (base)

May 7 2019

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

May 7 2019, 2:26 PM · Contributor Reviews (base)
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 7 2019, 8:23 AM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.
May 7 2019, 7:40 AM · arm64, Contributor Reviews (base)

May 6 2019

cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 11:07 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 9:29 PM · Linux Emulation, Contributor Reviews (base)
dchagin closed D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 8:01 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 6 2019, 5:39 PM · Linux Emulation, Contributor Reviews (base)

May 1 2019

cem added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 1 2019, 9:20 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
May 1 2019, 8:05 PM · Linux Emulation, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Added fdt detach corresponding to the current attach code (usb-phy)

May 1 2019, 4:58 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
May 1 2019, 4:56 PM · arm64, Contributor Reviews (base)
johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

Driver does not work after resume. I had to reboot to get working touchpad again.

May 1 2019, 4:14 PM · Contributor Reviews (base)

Apr 30 2019

emaste added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999

Apr 30 2019, 8:35 PM · Linux Emulation, Contributor Reviews (base)
dchagin added a reviewer for D13656: Bug 223722 add sys/class/net data to linsysfs: dchagin.
Apr 30 2019, 6:32 PM · Linux Emulation, Contributor Reviews (base)

Apr 27 2019

seanc added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

Apr 27 2019, 6:15 PM · Contributor Reviews (base)
manu added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#431905, @manu wrote:

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

Apr 27 2019, 3:57 PM · arm64, Contributor Reviews (base)
manu requested changes to D19986: Add support for USB 3.0 XHCI via ACPI.

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

Apr 27 2019, 3:43 PM · arm64, Contributor Reviews (base)

Apr 25 2019

emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

As with GregV's report in PR237055 dsdt has for USB:

Method (_STA, 0, NotSerialized)  // _STA: Status
{
    Return (0x00)
}

regardless of BIOS settings; I wasn't able to test this here.

Apr 25 2019, 11:04 PM · arm64, Contributor Reviews (base)
andrew added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Apr 25 2019, 9:55 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Done. btw, the original version was confirmed working on the Ampere system.

Apr 25 2019, 6:48 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Ah, yes. GregV would you rework it using that approach?

Apr 25 2019, 2:22 PM · arm64, Contributor Reviews (base)

Apr 24 2019

emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Apr 24 2019, 11:34 PM · arm64, Contributor Reviews (base)

Apr 23 2019

manu added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

Something like D19389 would be better.

Apr 23 2019, 5:11 PM · arm64, Contributor Reviews (base)
emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

Patch looks plausible to me, @manu or @andrew can you review and commit?
PR 237055

Apr 23 2019, 5:01 PM · arm64, Contributor Reviews (base)
emaste closed D19983: Enable Mellanox drivers on AArch64.
Apr 23 2019, 3:11 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Please take it.

Apr 23 2019, 1:24 PM · arm64, Contributor Reviews (base)
emaste added a comment to D19983: Enable Mellanox drivers on AArch64.

@hselasky will you commit? Otherwise I can take it.

Apr 23 2019, 1:02 PM · arm64, Contributor Reviews (base)
hselasky accepted D19983: Enable Mellanox drivers on AArch64.
Apr 23 2019, 8:40 AM · arm64, Contributor Reviews (base)

Apr 21 2019

johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

Here's preliminary evdev support. Can you please incorporate it into your patch?
https://gist.github.com/johalun/3c67a678e740b82512cec52bfe926092

Apr 21 2019, 8:38 PM · Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Done. Checked that mlx5ib loads.

Apr 21 2019, 3:28 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

mlx5ib depends on ibcore. Can you ensure this module is also built for aarch64 ?

Apr 21 2019, 1:07 PM · arm64, Contributor Reviews (base)

Apr 20 2019

emaste closed D19987: Enable ioremap for aarch64 in the LinuxKPI.
Apr 20 2019, 3:57 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Apr 20 2019, 3:13 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology retitled D19987: Enable ioremap for aarch64 in the LinuxKPI from LinuxKPI: enable ioremap on AArch64 to Enable ioremap for aarch64 in the LinuxKPI.
Apr 20 2019, 3:04 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Apr 20 2019, 3:03 PM · arm64, Contributor Reviews (base)
hselasky accepted D19987: Enable ioremap for aarch64 in the LinuxKPI.

Commit message should be something like this:
Enable ioremap for aarch64 in the LinuxKPI.

Apr 20 2019, 2:57 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Sure, split to D19987

Apr 20 2019, 2:10 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19987: Enable ioremap for aarch64 in the LinuxKPI.
Apr 20 2019, 2:09 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19986: Add support for USB 3.0 XHCI via ACPI.
Apr 20 2019, 2:05 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you split this patch?

Apr 20 2019, 1:08 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19983: Enable Mellanox drivers on AArch64.
Apr 20 2019, 1:01 PM · arm64, Contributor Reviews (base)

Apr 10 2019

trasz added a comment to D19690: mount/unmount events to devd.

Please consider adding it to devd.conf(5) man page.

Apr 10 2019, 2:48 PM · Contributor Reviews (base)

Apr 2 2019

imp added inline comments to D19690: mount/unmount events to devd.
Apr 2 2019, 10:07 PM · Contributor Reviews (base)
imp added inline comments to D19690: mount/unmount events to devd.
Apr 2 2019, 10:01 PM · Contributor Reviews (base)

Mar 31 2019

justus_sutsuj.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thank you very much Marc. I have been waiting for this and really appreciate your work.

Mar 31 2019, 12:32 AM · Contributor Reviews (base)

Mar 27 2019

mjg added inline comments to D19690: mount/unmount events to devd.
Mar 27 2019, 11:53 PM · Contributor Reviews (base)

Mar 25 2019

cneirabustos_gmail.com added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Mar 25 2019, 5:15 PM · Linux Emulation, Contributor Reviews (base)
rozhuk.im-gmail.com added a comment to D19690: mount/unmount events to devd.

This is alternate to kqueue EVFILT_FS, but there is no need to keep prev state from getmntinfo() and compare with new to find changes.
Also user can use shell scripts to perform additional actions.

Mar 25 2019, 3:34 PM · Contributor Reviews (base)
dchagin added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Mar 25 2019, 2:07 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

updated patch to address style(9) issues.

Mar 25 2019, 1:19 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com updated the diff for D13656: Bug 223722 add sys/class/net data to linsysfs.

Fixed latest style issue.

Mar 25 2019, 1:18 PM · Linux Emulation, Contributor Reviews (base)
mjg added a comment to D19690: mount/unmount events to devd.

What's the motivation for this functionality?

Mar 25 2019, 12:23 PM · Contributor Reviews (base)

Mar 24 2019

dchagin added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

style (9)

Mar 24 2019, 7:29 AM · Linux Emulation, Contributor Reviews (base)

Mar 23 2019

rozhuk.im-gmail.com retitled D19690: mount/unmount events to devd from mount/unmount event to devd to mount/unmount events to devd.
Mar 23 2019, 4:11 PM · Contributor Reviews (base)
rozhuk.im-gmail.com created D19690: mount/unmount events to devd.
Mar 23 2019, 4:09 PM · Contributor Reviews (base)