Page MenuHomeFreeBSD
Feed Advanced Search

Wed, May 8

manu closed D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 3:43 PM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.

Tinh Nguyen from Ampere tested and it doesn't seems to make usb working (xhci controller is discovered but nothing more), I've tried on my overdrive in FDT mode and it works.
In acpi mode this doesn't but it doesn't without this patch too, looks like the acpi table is missing info about interrupts, I'll do one more test on the macchiatobin and then commit this.

Wed, May 8, 2:05 PM · arm64, Contributor Reviews (base)
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 1:59 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 11:48 AM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 11:47 AM · arm64, Contributor Reviews (base)

Tue, May 7

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

Tue, May 7, 2:26 PM · Contributor Reviews (base)
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
Tue, May 7, 8:23 AM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.
Tue, May 7, 7:40 AM · arm64, Contributor Reviews (base)

Mon, May 6

cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 11:07 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 9:29 PM · Linux Emulation, Contributor Reviews (base)
dchagin closed D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 8:01 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 5:39 PM · Linux Emulation, Contributor Reviews (base)

Wed, May 1

cem added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Wed, May 1, 9:20 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Wed, May 1, 8:05 PM · Linux Emulation, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Added fdt detach corresponding to the current attach code (usb-phy)

Wed, May 1, 4:58 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 1, 4:56 PM · arm64, Contributor Reviews (base)
johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

Driver does not work after resume. I had to reboot to get working touchpad again.

Wed, May 1, 4:14 PM · Contributor Reviews (base)

Tue, Apr 30

emaste added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999

Tue, Apr 30, 8:35 PM · Linux Emulation, Contributor Reviews (base)
dchagin added a reviewer for D13656: Bug 223722 add sys/class/net data to linsysfs: dchagin.
Tue, Apr 30, 6:32 PM · Linux Emulation, Contributor Reviews (base)

Sat, Apr 27

seanc added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

Sat, Apr 27, 6:15 PM · Contributor Reviews (base)
manu added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#431905, @manu wrote:

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

Sat, Apr 27, 3:57 PM · arm64, Contributor Reviews (base)
manu requested changes to D19986: Add support for USB 3.0 XHCI via ACPI.

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

Sat, Apr 27, 3:43 PM · arm64, Contributor Reviews (base)

Thu, Apr 25

emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

As with GregV's report in PR237055 dsdt has for USB:

Method (_STA, 0, NotSerialized)  // _STA: Status
{
    Return (0x00)
}

regardless of BIOS settings; I wasn't able to test this here.

Thu, Apr 25, 11:04 PM · arm64, Contributor Reviews (base)
andrew added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Thu, Apr 25, 9:55 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Done. btw, the original version was confirmed working on the Ampere system.

Thu, Apr 25, 6:48 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Ah, yes. GregV would you rework it using that approach?

Thu, Apr 25, 2:22 PM · arm64, Contributor Reviews (base)

Wed, Apr 24

emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Wed, Apr 24, 11:34 PM · arm64, Contributor Reviews (base)

Tue, Apr 23

manu added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

Something like D19389 would be better.

Tue, Apr 23, 5:11 PM · arm64, Contributor Reviews (base)
emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

Patch looks plausible to me, @manu or @andrew can you review and commit?
PR 237055

Tue, Apr 23, 5:01 PM · arm64, Contributor Reviews (base)
emaste closed D19983: Enable Mellanox drivers on AArch64.
Tue, Apr 23, 3:11 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Please take it.

Tue, Apr 23, 1:24 PM · arm64, Contributor Reviews (base)
emaste added a comment to D19983: Enable Mellanox drivers on AArch64.

@hselasky will you commit? Otherwise I can take it.

Tue, Apr 23, 1:02 PM · arm64, Contributor Reviews (base)
hselasky accepted D19983: Enable Mellanox drivers on AArch64.
Tue, Apr 23, 8:40 AM · arm64, Contributor Reviews (base)

Sun, Apr 21

johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

Here's preliminary evdev support. Can you please incorporate it into your patch?
https://gist.github.com/johalun/3c67a678e740b82512cec52bfe926092

Sun, Apr 21, 8:38 PM · Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Done. Checked that mlx5ib loads.

Sun, Apr 21, 3:28 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

mlx5ib depends on ibcore. Can you ensure this module is also built for aarch64 ?

Sun, Apr 21, 1:07 PM · arm64, Contributor Reviews (base)

Sat, Apr 20

emaste closed D19987: Enable ioremap for aarch64 in the LinuxKPI.
Sat, Apr 20, 3:57 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Sat, Apr 20, 3:13 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology retitled D19987: Enable ioremap for aarch64 in the LinuxKPI from LinuxKPI: enable ioremap on AArch64 to Enable ioremap for aarch64 in the LinuxKPI.
Sat, Apr 20, 3:04 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Sat, Apr 20, 3:03 PM · arm64, Contributor Reviews (base)
hselasky accepted D19987: Enable ioremap for aarch64 in the LinuxKPI.

Commit message should be something like this:
Enable ioremap for aarch64 in the LinuxKPI.

Sat, Apr 20, 2:57 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Sure, split to D19987

Sat, Apr 20, 2:10 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19987: Enable ioremap for aarch64 in the LinuxKPI.
Sat, Apr 20, 2:09 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19986: Add support for USB 3.0 XHCI via ACPI.
Sat, Apr 20, 2:05 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you split this patch?

Sat, Apr 20, 1:08 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19983: Enable Mellanox drivers on AArch64.
Sat, Apr 20, 1:01 PM · arm64, Contributor Reviews (base)

Apr 10 2019

trasz added a comment to D19690: mount/unmount events to devd.

Please consider adding it to devd.conf(5) man page.

Apr 10 2019, 2:48 PM · Contributor Reviews (base)

Apr 2 2019

imp added inline comments to D19690: mount/unmount events to devd.
Apr 2 2019, 10:07 PM · Contributor Reviews (base)
imp added inline comments to D19690: mount/unmount events to devd.
Apr 2 2019, 10:01 PM · Contributor Reviews (base)

Mar 31 2019

justus_sutsuj.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thank you very much Marc. I have been waiting for this and really appreciate your work.

Mar 31 2019, 12:32 AM · Contributor Reviews (base)

Mar 27 2019

mjg added inline comments to D19690: mount/unmount events to devd.
Mar 27 2019, 11:53 PM · Contributor Reviews (base)

Mar 25 2019

cneirabustos_gmail.com added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Mar 25 2019, 5:15 PM · Linux Emulation, Contributor Reviews (base)
rozhuk.im-gmail.com added a comment to D19690: mount/unmount events to devd.

This is alternate to kqueue EVFILT_FS, but there is no need to keep prev state from getmntinfo() and compare with new to find changes.
Also user can use shell scripts to perform additional actions.

Mar 25 2019, 3:34 PM · Contributor Reviews (base)
dchagin added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

ok, btw, what is the reason to create only 2 devices (eth0 and lo0)?

Mar 25 2019, 2:07 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

updated patch to address style(9) issues.

Mar 25 2019, 1:19 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com updated the diff for D13656: Bug 223722 add sys/class/net data to linsysfs.

Fixed latest style issue.

Mar 25 2019, 1:18 PM · Linux Emulation, Contributor Reviews (base)
mjg added a comment to D19690: mount/unmount events to devd.

What's the motivation for this functionality?

Mar 25 2019, 12:23 PM · Contributor Reviews (base)

Mar 24 2019

dchagin added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

style (9)

Mar 24 2019, 7:29 AM · Linux Emulation, Contributor Reviews (base)

Mar 23 2019

rozhuk.im-gmail.com retitled D19690: mount/unmount events to devd from mount/unmount event to devd to mount/unmount events to devd.
Mar 23 2019, 4:11 PM · Contributor Reviews (base)
rozhuk.im-gmail.com created D19690: mount/unmount events to devd.
Mar 23 2019, 4:09 PM · Contributor Reviews (base)

Mar 21 2019

cneirabustos_gmail.com updated the diff for D13656: Bug 223722 add sys/class/net data to linsysfs.

Fixed style.

Mar 21 2019, 3:57 PM · Linux Emulation, Contributor Reviews (base)

Mar 16 2019

wosch closed D13910: `make buildkernel' should display the build time in seconds.
Mar 16 2019, 8:03 PM · Contributor Reviews (base)
cem accepted D13910: `make buildkernel' should display the build time in seconds.

Thanks, LGTM

Mar 16 2019, 5:43 PM · Contributor Reviews (base)

Mar 12 2019

wosch closed D13911: `make buildworld' should display the build time in seconds.
Mar 12 2019, 7:41 AM · Contributor Reviews (base)

Mar 11 2019

cem accepted D13911: `make buildworld' should display the build time in seconds.
Mar 11 2019, 5:54 PM · Contributor Reviews (base)
wosch updated the diff for D13911: `make buildworld' should display the build time in seconds.

The updated patch works without a temp file.

Mar 11 2019, 4:20 PM · Contributor Reviews (base)

Mar 10 2019

wosch updated the diff for D13910: `make buildkernel' should display the build time in seconds.

The updated patch works without a temp file.

Mar 10 2019, 7:13 PM · Contributor Reviews (base)

Feb 15 2019

Scoobi_doo_yahoo.com added a comment to D16698: First draft HID over I2C support (Mouse only).

I'm working on adding support for the Intel DesignWare I2C controllers that are connected to my touchpad and my touchscreen, also to the touchpad of another user (who originally requested my help on this issue for his laptop). I think I have a working I2C device(running 'i2c -s -v -f /dev/iic0' kills my working PS/2-connected touchpad). I would like to use your iichid module to instantly add support for these HID devices, but when I build & load iichid I see no new HID device nodes.

Feb 15 2019, 7:01 PM · Contributor Reviews (base)

Jan 27 2019

zarychtam_plan-b.pwste.edu.pl added a comment to D16698: First draft HID over I2C support (Mouse only).

Builds on 12.0-STABLE r343501 sources and works fine with Dell Latitude 5590. Thank you!

Jan 27 2019, 7:15 PM · Contributor Reviews (base)

Dec 15 2018

james.wright_digital-chaos.com updated the diff for D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

Updated file path in diff for Phabricator Diffusion browsing

Dec 15 2018, 3:37 PM · Contributor Reviews (base)

Dec 11 2018

dab closed D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Dec 11 2018, 4:36 PM · Contributor Reviews (base)
dab closed D18395: Add uk.macbook.kbd keymap (vt).
Dec 11 2018, 2:14 AM · Contributor Reviews (base)
dab updated the summary of D18395: Add uk.macbook.kbd keymap (vt).
Dec 11 2018, 12:59 AM · Contributor Reviews (base)

Dec 8 2018

james.wright_digital-chaos.com updated the summary of D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Dec 8 2018, 11:30 AM · Contributor Reviews (base)
james.wright_digital-chaos.com updated the summary of D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Dec 8 2018, 11:29 AM · Contributor Reviews (base)
james.wright_digital-chaos.com updated the summary of D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Dec 8 2018, 5:01 AM · Contributor Reviews (base)
james.wright_digital-chaos.com created D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Dec 8 2018, 5:00 AM · Contributor Reviews (base)

Dec 1 2018

dab updated the diff for D18395: Add uk.macbook.kbd keymap (vt).

After commandeering the revision, updating it to make sure my diff is the same as the previously submitted diff.

Dec 1 2018, 6:56 PM · Contributor Reviews (base)
dab added reviewers for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2: rpaulo, adrian.

Adding @adrian and @rpaulo as reviewers, as they have been in this code before and might have input.

Dec 1 2018, 6:50 PM · Contributor Reviews (base)
dab updated the diff for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

After commandeering the revision, updating it to make sure my diff is
the same as the previously submitted diff.

Dec 1 2018, 6:47 PM · Contributor Reviews (base)
dab commandeered D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

I'll take over this diff and get it committed to -CURRENT in the next few days.

Dec 1 2018, 6:27 PM · Contributor Reviews (base)
james.wright_digital-chaos.com updated the test plan for D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Dec 1 2018, 3:04 PM · Contributor Reviews (base)
james.wright_digital-chaos.com updated the summary of D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Dec 1 2018, 3:04 PM · Contributor Reviews (base)
james.wright_digital-chaos.com added a comment to D18395: Add uk.macbook.kbd keymap (vt).
In D18395#391434, @dab wrote:

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

Dec 1 2018, 3:39 AM · Contributor Reviews (base)
dab commandeered D18395: Add uk.macbook.kbd keymap (vt).

Thanks. I'll take over this diff and get it committed to -CURRENT in the next few days. On what branch or revision did you test this? Do you need it applied to the stable/11 or stable/12?

Dec 1 2018, 2:41 AM · Contributor Reviews (base)
james.wright_digital-chaos.com added a comment to D18395: Add uk.macbook.kbd keymap (vt).
In D18395#391412, @dab wrote:

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Dec 1 2018, 12:07 AM · Contributor Reviews (base)

Nov 30 2018

dab added a comment to D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Nov 30 2018, 11:32 PM · Contributor Reviews (base)
dab added a comment to D18395: Add uk.macbook.kbd keymap (vt).

@james.wright_jigsawdezign.com, do you need someone to help get this committed? I could do that if so. Can you update the review with information on testing you've done?

Nov 30 2018, 11:32 PM · Contributor Reviews (base)
emaste accepted D18395: Add uk.macbook.kbd keymap (vt).
Nov 30 2018, 7:38 PM · Contributor Reviews (base)
markj added a reviewer for D18395: Add uk.macbook.kbd keymap (vt): emaste.
Nov 30 2018, 6:22 PM · Contributor Reviews (base)
james.wright_digital-chaos.com updated the summary of D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Nov 30 2018, 5:33 PM · Contributor Reviews (base)
james.wright_digital-chaos.com created D18396: asmc: Add Support for MacBookAir 7,1 and 7,2.
Nov 30 2018, 5:33 PM · Contributor Reviews (base)
james.wright_digital-chaos.com created D18395: Add uk.macbook.kbd keymap (vt).
Nov 30 2018, 5:25 PM · Contributor Reviews (base)

Nov 25 2018

jeymon_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Many thanks for these files and patches.
Now my Asus Vivobook S15 touchpad is working running FreeBSD 12.RC1, kernel source revision 340904.

Nov 25 2018, 8:09 PM · Contributor Reviews (base)

Nov 1 2018

johalun0_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thanks for doing this! Works great on my Dell 7490.
Suspend/resume not tested. Please also add EVDEV to this driver so we can get things like horizontal scrolling :)

Nov 1 2018, 11:10 AM · Contributor Reviews (base)

Oct 21 2018

daniel.piecebypiece_yahoo.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Awesome Mark.
It works on my Huawei Matebook X Pro. Sorry for comming back so late.
I had 10 minutes to test and here are my initial findings.

Oct 21 2018, 10:52 AM · Contributor Reviews (base)

Oct 19 2018

lizhichao877_163.com added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com
sorry for bothering you guys
I have managed to kldload acpi_iicbus.ko
but my mosuepad doesn't work
here is my latest FreeBSD dmesg output:
ig4iic_pci0: <Intel Sunrise Point-LP I2C Controller-0> mem 0xd2336000-0xd2336fff at device 21.0 on pci0
ig4iic_pci0: Using MSI
iicbus0: <Philips I2C bus> on ig4iic_pci0
acpi_iichid0: <HID over I2C (ACPI)> irq 51 on acpi0
acpi_iichid0: descriptor register address is 1
acpi_iichid0: - irq: 51
acpi_iichid0: parent device is "\134_SB_.PCI0.I2C0"
iichid0: <HID over I2C> at addr 0x15 on iicbus0
iichid0: ADDR 0x15 REG 0x1
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
iichid0: 3 buttons and [XY] coordinates ID=1
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
iichid0: 3 buttons and [XY] coordinates ID=1
hid_get_item: Number of items(256) truncated to 255
hid_get_item: Number of items(672) truncated to 255
acpi_iichid0: added iichid0 ADDR 0x15 REG 0x1 to iicbus0
acpi_iichid0: allocated irq at 0xfffff801088b6780 and rid 0
acpi_iichid0: successfully setup interrupt

Oct 19 2018, 10:14 AM · Contributor Reviews (base)

Oct 18 2018

lizhichao877_163.com added a comment to D16698: First draft HID over I2C support (Mouse only).

@marc.priggemeyer_gmail.com hello sir can you be so kind to help me out, when I try to kldload acpi_iichid.ko it says 'parent is not attached', what should I kldload beforehand or something should be done?

Oct 18 2018, 7:32 AM · Contributor Reviews (base)

Oct 15 2018

alvisen_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

It works, but there is only one button and no two finger scrolling, whereas with psm I have 3 buttons (one, two and three finger taps) and two finger scrolling.

Thanks for testing. That your two finger scroll does not work is apparent from the descriptor line identifying only two axis, namely X and Y. For scrolling to work, there should be a Z axis as well. I believe that your touchpad does not only support the mouse reports but also multitouch trackpad reports, but they are not yet considered by iichid. Nevertheless you should be able to use two buttons.

Oct 15 2018, 9:46 AM · Contributor Reviews (base)

Oct 14 2018

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

...
I haven't spent any significant amount of time looking at the diff yet, but I'll take a stab at answering these.
...

Oct 14 2018, 5:30 PM · Contributor Reviews (base)