Page MenuHomeFreeBSD

Contributor Reviews (base)Project
ActivePublic

Recent Activity

Wed, May 8

manu closed D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 3:43 PM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.

Tinh Nguyen from Ampere tested and it doesn't seems to make usb working (xhci controller is discovered but nothing more), I've tried on my overdrive in FDT mode and it works.
In acpi mode this doesn't but it doesn't without this patch too, looks like the acpi table is missing info about interrupts, I'll do one more test on the macchiatobin and then commit this.

Wed, May 8, 2:05 PM · arm64, Contributor Reviews (base)
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 1:59 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 11:48 AM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 8, 11:47 AM · arm64, Contributor Reviews (base)

Tue, May 7

marc.priggemeyer_gmail.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

Tue, May 7, 2:26 PM · Contributor Reviews (base)
andrew accepted D19986: Add support for USB 3.0 XHCI via ACPI.
Tue, May 7, 8:23 AM · arm64, Contributor Reviews (base)
manu accepted D19986: Add support for USB 3.0 XHCI via ACPI.
Tue, May 7, 7:40 AM · arm64, Contributor Reviews (base)

Mon, May 6

cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 11:07 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 9:29 PM · Linux Emulation, Contributor Reviews (base)
dchagin closed D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 8:01 PM · Linux Emulation, Contributor Reviews (base)
cneirabustos_gmail.com added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Mon, May 6, 5:39 PM · Linux Emulation, Contributor Reviews (base)

Wed, May 1

cem added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Wed, May 1, 9:20 PM · Linux Emulation, Contributor Reviews (base)
dchagin added inline comments to D13656: Bug 223722 add sys/class/net data to linsysfs.
Wed, May 1, 8:05 PM · Linux Emulation, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Added fdt detach corresponding to the current attach code (usb-phy)

Wed, May 1, 4:58 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Wed, May 1, 4:56 PM · arm64, Contributor Reviews (base)
johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

Driver does not work after resume. I had to reboot to get working touchpad again.

Wed, May 1, 4:14 PM · Contributor Reviews (base)

Tue, Apr 30

emaste added a comment to D13656: Bug 223722 add sys/class/net data to linsysfs.

For future updates (to this review, if any, or other reviews) please include context e.g. git diff -U9999

Tue, Apr 30, 8:35 PM · Linux Emulation, Contributor Reviews (base)
dchagin added a reviewer for D13656: Bug 223722 add sys/class/net data to linsysfs: dchagin.
Tue, Apr 30, 6:32 PM · Linux Emulation, Contributor Reviews (base)

Sat, Apr 27

seanc added a comment to D16698: First draft HID over I2C support (Mouse only).

Can someone summarize what's left or preventing this from being committed?

Sat, Apr 27, 6:15 PM · Contributor Reviews (base)
manu added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#431905, @manu wrote:

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

Sat, Apr 27, 3:57 PM · arm64, Contributor Reviews (base)
manu requested changes to D19986: Add support for USB 3.0 XHCI via ACPI.

The fdt needs it's own detach function where we disable the phy (like it's done in D19389 for ehci).

Sat, Apr 27, 3:43 PM · arm64, Contributor Reviews (base)

Thu, Apr 25

emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

As with GregV's report in PR237055 dsdt has for USB:

Method (_STA, 0, NotSerialized)  // _STA: Status
{
    Return (0x00)
}

regardless of BIOS settings; I wasn't able to test this here.

Thu, Apr 25, 11:04 PM · arm64, Contributor Reviews (base)
andrew added inline comments to D19986: Add support for USB 3.0 XHCI via ACPI.
Thu, Apr 25, 9:55 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19986: Add support for USB 3.0 XHCI via ACPI.

Done. btw, the original version was confirmed working on the Ampere system.

Thu, Apr 25, 6:48 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Ah, yes. GregV would you rework it using that approach?

Thu, Apr 25, 2:22 PM · arm64, Contributor Reviews (base)

Wed, Apr 24

emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.
In D19986#430466, @manu wrote:

Something like D19389 would be better.

Wed, Apr 24, 11:34 PM · arm64, Contributor Reviews (base)

Tue, Apr 23

manu added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

Something like D19389 would be better.

Tue, Apr 23, 5:11 PM · arm64, Contributor Reviews (base)
emaste added a comment to D19986: Add support for USB 3.0 XHCI via ACPI.

Patch looks plausible to me, @manu or @andrew can you review and commit?
PR 237055

Tue, Apr 23, 5:01 PM · arm64, Contributor Reviews (base)
emaste closed D19983: Enable Mellanox drivers on AArch64.
Tue, Apr 23, 3:11 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Please take it.

Tue, Apr 23, 1:24 PM · arm64, Contributor Reviews (base)
emaste added a comment to D19983: Enable Mellanox drivers on AArch64.

@hselasky will you commit? Otherwise I can take it.

Tue, Apr 23, 1:02 PM · arm64, Contributor Reviews (base)
hselasky accepted D19983: Enable Mellanox drivers on AArch64.
Tue, Apr 23, 8:40 AM · arm64, Contributor Reviews (base)

Sun, Apr 21

johalun added a comment to D16698: First draft HID over I2C support (Mouse only).

Here's preliminary evdev support. Can you please incorporate it into your patch?
https://gist.github.com/johalun/3c67a678e740b82512cec52bfe926092

Sun, Apr 21, 8:38 PM · Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Done. Checked that mlx5ib loads.

Sun, Apr 21, 3:28 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

mlx5ib depends on ibcore. Can you ensure this module is also built for aarch64 ?

Sun, Apr 21, 1:07 PM · arm64, Contributor Reviews (base)

Sat, Apr 20

emaste closed D19987: Enable ioremap for aarch64 in the LinuxKPI.
Sat, Apr 20, 3:57 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Sat, Apr 20, 3:13 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology retitled D19987: Enable ioremap for aarch64 in the LinuxKPI from LinuxKPI: enable ioremap on AArch64 to Enable ioremap for aarch64 in the LinuxKPI.
Sat, Apr 20, 3:04 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you verify that the LINT kernel passes with this change on aarch64?

Sat, Apr 20, 3:03 PM · arm64, Contributor Reviews (base)
hselasky accepted D19987: Enable ioremap for aarch64 in the LinuxKPI.

Commit message should be something like this:
Enable ioremap for aarch64 in the LinuxKPI.

Sat, Apr 20, 2:57 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology updated the diff for D19983: Enable Mellanox drivers on AArch64.

Sure, split to D19987

Sat, Apr 20, 2:10 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19987: Enable ioremap for aarch64 in the LinuxKPI.
Sat, Apr 20, 2:09 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19986: Add support for USB 3.0 XHCI via ACPI.
Sat, Apr 20, 2:05 PM · arm64, Contributor Reviews (base)
hselasky added a comment to D19983: Enable Mellanox drivers on AArch64.

Can you split this patch?

Sat, Apr 20, 1:08 PM · arm64, Contributor Reviews (base)
greg_unrelenting.technology created D19983: Enable Mellanox drivers on AArch64.
Sat, Apr 20, 1:01 PM · arm64, Contributor Reviews (base)

Apr 10 2019

trasz added a comment to D19690: mount/unmount events to devd.

Please consider adding it to devd.conf(5) man page.

Apr 10 2019, 2:48 PM · Contributor Reviews (base)

Apr 2 2019

imp added inline comments to D19690: mount/unmount events to devd.
Apr 2 2019, 10:07 PM · Contributor Reviews (base)
imp added inline comments to D19690: mount/unmount events to devd.
Apr 2 2019, 10:01 PM · Contributor Reviews (base)

Mar 31 2019

justus_sutsuj.com added a comment to D16698: First draft HID over I2C support (Mouse only).

Thank you very much Marc. I have been waiting for this and really appreciate your work.

Mar 31 2019, 12:32 AM · Contributor Reviews (base)