That is expected as it ignored any touchpads
Fri, Jul 19
just unpack it at your $HOME. Than
make && sudo kldload ./iichid.ko
leaving all other modules built from the source of this thread?
drivers from this review should be at least unloaded from kernel. There is no need to revert D16698 patch. Just don't try to kldload both modules in between reboots.
Should I remove evdev support from the kernel?
No need. It links with evdev unconditionally
Can you please share your xorg configuration?
I do not have any specific xorg.conf options. Any evdev-awared autoconfiguration backend should work out of box. See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=196678 for example.
Thu, Jul 18
OS driver or userland applications just do not have enough information as finger coords or count to support doublefinger scroll or multifinger taps.
I wrote a simple util to dump report descriptor from I2C HID device.
It accepts 3 input parameters: iic device path, i2c bus address and i2c HID register and prints report descriptor of given I2C device on stdout. This report descriptor can be further analyzed with any tool (e.g. web-based http://eleccelerator.com/usbdescreqparser/) to examine HID device capabilities.
hm. EVDEV_SUPPORT enables evdev in "legacy" drivers like psm, ums, ukbd etc. I'm not sure why @johalun added ifdefs for that here, this is a new driver :)
Wed, Jul 17
Tue, Jul 16
... please note that I edited my last post; touchpad is working again after test #3.
Mon, Jul 15
Many thanks for your efforts! My notebook: Asus Zenbook 14 UX410UFR with 12.0-RELEASE. After kldload ig4 iic acpi_iichid the device works after being checked with i2c -v -s -f /dev/iic1 (thanks fbsd_opal.com). My /var/log/messages:
Mon, Jul 8
I don't object to acpi_iichid module existence. It just adds an extra requirements for module load order which I was not able to solve quickly.
I think it would be best to try and base the ims driver on top of your code. Are you interested in trying to integrate them?
Yes, I am going to submit this code to the project when it will be ready, so it is better to have it insync with ims
I wrote a driver for I2C MT touchscreens https://github.com/wulf7/iichid which is heavily based on the code in this review.
It does not require dedicated ACPI module at all and has some I2C/HID layers separation which is missed in current review.
So I think it may have sense to join efforts and codebases
I reuploaded the full patch with a sysctl (power_state) added.
Sun, Jul 7
Sat, Jul 6
Hmm, I think I did not intend to create a new diff. Should I reupload, or can it be merged?
@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.
Fri, Jun 28
Thu, Jun 27
I just tried booting with this patch applied and with EDK2 firmware built from master yesterday, and I still don't see any output - both with devicetree and acpi.
Wed, Jun 26
Mon, Jun 24
By the way, there is an error in the diff of sys/conf/files in this D16698 patch:
Sun, Jun 23
Could anyone affected by the issue give the patch here a try? https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=238037