A quite quick review, which I'll complete later, but unfortunately only after a while since I'm about to be almost completely AFK for ~4 weeks.

In D58329#1338905, @temcbun_gmail.com wrote:

Document descriptions should not have crossreferences especially, but really any child macros.
Manpage compiler upstream has said (quite strongly and hilariously actually) it's wrong.

But where exactly does it say this?

Get rid of .Xr in .Nd and make the .Nd itself more informative.

Thank you for the review!

I have not reviewed this because all I know about colors is how to turn them off, drives me crazy. Maybe... @dteske might know?

Ping.

Ping.

New D58086 for you to check.

Going to commit this. Will apply a few additional minor style (mostly, names, and a declaration moved to the corresponding block) changes in a separate commit.

In D57720#1331295, @temcbun_gmail.com wrote:

@ziaee Could you please MFC this commit (I see the commit message says it is to be MFCed after 3 days, but it's still not).

@ziaee Could you please MFC this commit (I see the commit message says it is to be MFCed after 3 days, but it's still not).

In D58038#1331015, @olce wrote:

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself.

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself. Which mail do you want to use? The one that can be inferred from your Phabricator login? I also see a mail at "zohomail" in the tree that could match. If you have to disclose the full name and don't want to do that here, then please mail it to me (olce@).

Remove hyphen from the first comment line. Thanks @ziaee!

Ping for review.

In the patch I just submitted, I inadvertently modified lines unrelated to the current fix, so I have reverted those lines to their original state.
I apologize for the error.

• Define the thermal interrupt callback function using typedef.
• Fix style issues.

Looks good modulo some minor style (in a broad sense) improvements. To ease things, I could apply these changes myself on commit. Please tell me if you object to that.

In D44454#1327923, @kib wrote:

Ed, feel free to merge this review.

Ed, feel free to merge this review.

• Fix an issue where the constant for the hmp(4) registration priority value was not enclosed within "#ifdef HMP - #endif" directives.
• Remove the INTELHFI_HMP_SCORE_FROM(x) macro.
  • It was decided that removal was appropriate because it was used in only two places—making the macro unnecessary—and also due to the aforementioned issue.
• Correct invalid tab to space. (Sorry)

• Add the "intelhfi" driver to the default kernel configuration file (sys/amd64/conf/GENERIC).

I will since as the reviewer I was supposed to prevent these typos. Thanks guys!

Thanks! Who's going to commit this?

Thanks Artem!