Page MenuHomeFreeBSD
Projects Contributor Reviews (src)

Contributor Reviews (src)Project
ActivePublic
Watch Project

Members (11)

Watchers (5)

Recent Activity
View All

Today

cperciva added a comment to D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).

I think I must have not realized that the author of this patch wasn't a committer. Sorry James, I've committed this now!

Sun, Oct 13, 5:45 AM · Contributor Reviews (src)
cperciva closed D18482: Amazon EC2: Disable floppy devices (fdc0, fd0,) and parallel port device (pp0).
Sun, Oct 13, 5:45 AM · Contributor Reviews (src)

Sep 12 2024

minsoochoo0122_proton.me closed D44145: Disable C standards under C99 from kernel build.

This revision has landed

Sep 12 2024, 9:28 PM · Contributor Reviews (src)

Sep 4 2024

bz added a watcher for Contributor Reviews (src): bz.
Sep 4 2024, 7:12 PM

Jun 3 2024

imp accepted D44664: stdbool.h: Update for C23.

OK. This looks ready to go then. Sorry for my slowness in responding

Jun 3 2024, 5:06 PM · Contributor Reviews (src)
imp added inline comments to D44665: stddef.h: Update for C23.
Jun 3 2024, 3:18 PM · Contributor Reviews (src)
imp added a comment to D44145: Disable C standards under C99 from kernel build.

I think this is ready now, so I'll land it.
I'm satisfied that old-school construct was for our old-school 4.2 gcc, which has aged out of support everywhere.

Jun 3 2024, 2:53 PM · Contributor Reviews (src)

May 4 2024

instructionset_gmail.com added a comment to D41421: Update jemalloc to version 5.3.0.

I can test on AMD64 (currently using it) and ARM64 and i386. I might be able to do BE PPC64.

May 4 2024, 4:10 AM · Contributor Reviews (src)

Apr 12 2024

minsoochoo0122_proton.me added inline comments to D44145: Disable C standards under C99 from kernel build.
Apr 12 2024, 11:03 PM · Contributor Reviews (src)
jhb closed D43254: libc: Remove support for pre-C11 C standards.
Apr 12 2024, 7:40 PM · Contributor Reviews (src)
imp accepted D43254: libc: Remove support for pre-C11 C standards.

Hey John do you want to land this or should I?

Apr 12 2024, 6:55 PM · Contributor Reviews (src)
jhb added a comment to D43254: libc: Remove support for pre-C11 C standards.

The commit log though can say "Remove pre-C99 support" though since the blocks are all for pre-C99.

Apr 12 2024, 6:51 PM · Contributor Reviews (src)
jhb accepted D43254: libc: Remove support for pre-C11 C standards.

This looks ok to me now.

Apr 12 2024, 6:50 PM · Contributor Reviews (src)

Apr 10 2024

markj closed D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 10 2024, 12:52 PM · Contributor Reviews (src)
dougm accepted D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 10 2024, 9:40 AM · Contributor Reviews (src)
zlei added a reviewer for D44667: vm_reserv_reclaim_contig: Return NULL not false: dougm.
Apr 10 2024, 9:11 AM · Contributor Reviews (src)
zlei accepted D44667: vm_reserv_reclaim_contig: Return NULL not false.

Looks good to me.

Apr 10 2024, 8:57 AM · Contributor Reviews (src)

Apr 9 2024

minsoochoo0122_proton.me added a comment to D41421: Update jemalloc to version 5.3.0.

Build Success

Apr 9 2024, 11:33 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D41421: Update jemalloc to version 5.3.0.
Apr 9 2024, 11:30 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D41421: Update jemalloc to version 5.3.0.

git rebase main

Apr 9 2024, 10:13 PM · Contributor Reviews (src)
minsoochoo0122_proton.me requested review of D44665: stddef.h: Update for C23.
Apr 9 2024, 8:49 PM · Contributor Reviews (src)

Apr 7 2024

lwhsu added a reviewer for D44667: vm_reserv_reclaim_contig: Return NULL not false: markj.
Apr 7 2024, 6:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D44667: vm_reserv_reclaim_contig: Return NULL not false.

I'm not completely familar with FreeBSD's virtual memory system. But it seems the comment still doesn't match the code. Doesn't it return m_ret when the reclaim is successful and null when failed?

Apr 7 2024, 5:51 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the test plan for D44667: vm_reserv_reclaim_contig: Return NULL not false.
Apr 7 2024, 5:45 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Removed redundant macros

Apr 7 2024, 4:27 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44664: stdbool.h: Update for C23.
Apr 7 2024, 4:23 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added inline comments to D44665: stddef.h: Update for C23.
Apr 7 2024, 4:20 AM · Contributor Reviews (src)
imp accepted D44666: sys/types.h: Do not define bool macros for C23 and later.
Apr 7 2024, 3:43 AM · Contributor Reviews (src)
imp requested changes to D44665: stddef.h: Update for C23.
Apr 7 2024, 3:41 AM · Contributor Reviews (src)
imp requested changes to D44664: stdbool.h: Update for C23.
Apr 7 2024, 3:38 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44666: sys/types.h: Do not define bool macros for C23 and later: Contributor Reviews (src).
Apr 7 2024, 3:15 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44665: stddef.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 3:10 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44664: stdbool.h: Update for C23.

Add __STDC_VERSION_STDBOOL_H__ as the header file now conforms C23.

Apr 7 2024, 2:21 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44664: stdbool.h: Update for C23: Contributor Reviews (src).
Apr 7 2024, 2:11 AM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D44663: stdalign.h: Disable for C23.

Fix grammar in the commit message

Apr 7 2024, 1:02 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44663: stdalign.h: Disable for C23: Contributor Reviews (src).
Apr 7 2024, 1:01 AM · Contributor Reviews (src)

Apr 6 2024

minsoochoo0122_proton.me abandoned D44660: llvm-project: Fix build on devel/llvm18.

Fixed by 5f757f3ff9144b609b3c433dfd370cc6bdc191ad and cb14a3fe5122c879eae1fb480ed7ce82a699ddb6

Apr 6 2024, 11:29 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D44660: llvm-project: Fix build on devel/llvm18.

When will we merge the upstream llvm-project to freebsd-src? Are there any issues blocking the merge?

Apr 6 2024, 9:54 PM · Contributor Reviews (src)
lwhsu added a reviewer for D44660: llvm-project: Fix build on devel/llvm18: brooks.
Apr 6 2024, 8:58 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the summary of D44660: llvm-project: Fix build on devel/llvm18.
Apr 6 2024, 7:56 PM · Contributor Reviews (src)
minsoochoo0122_proton.me added a reviewer for D44660: llvm-project: Fix build on devel/llvm18: Contributor Reviews (src).
Apr 6 2024, 7:55 PM · Contributor Reviews (src)
minsoochoo0122_proton.me updated the diff for D43239: Use gnu17 for buildkernel.

Fixed macro

Apr 6 2024, 3:16 AM · Contributor Reviews (src)
minsoochoo0122_proton.me added a comment to D43254: libc: Remove support for pre-C11 C standards.

@jrtc27 Can you review the changes?

Apr 6 2024, 12:40 AM · Contributor Reviews (src)

Mar 26 2024

rozhuk.im-gmail.com abandoned D11140: OSS: allow unplug sound cards without apps close devices.
Mar 26 2024, 6:27 AM · Contributor Reviews (src), multimedia
christos added a comment to D11140: OSS: allow unplug sound cards without apps close devices.

D43545 takes care of this change. Should we close this?

Mar 26 2024, 5:49 AM · Contributor Reviews (src), multimedia

Mar 11 2024

minsoochoo0122_proton.me added a comment to D43239: Use gnu17 for buildkernel.

Are there any more changes required?

Mar 11 2024, 5:42 AM · Contributor Reviews (src)

Feb 29 2024

emaste accepted D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 9:57 PM · Contributor Reviews (src)
emaste added inline comments to D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 9:57 PM · Contributor Reviews (src)
imp added inline comments to D44145: Disable C standards under C99 from kernel build.
Feb 29 2024, 6:11 PM · Contributor Reviews (src)
imp added a comment to D44145: Disable C standards under C99 from kernel build.

Thanks for splitting this out.

Feb 29 2024, 6:08 PM · Contributor Reviews (src)