I like it, lets give it a few days to see if anyone else has any suggestions to improve it further.

Ping.

Ping.

Ping.

First of all, THANK YOU VERY MUCH for your review.

In D58457#1342400, @ziaee wrote:

This line was forgotten to be updated when information about st_birthtime was first added into the manual page.

Nice, so we want to find that commit and put it at the bottom of the commit message like Fixes: <shorthash> ("Commit title").

In D58476#1342416, @ziaee wrote:

So we've been trying to standardize this language, here's the draft: https://reviews.freebsd.org/D57690

Use standardized formulation.

So we've been trying to standardize this language, here's the draft: https://reviews.freebsd.org/D57690

Hey Artem, thanks for the patch.

A quite quick review, which I'll complete later, but unfortunately only after a while since I'm about to be almost completely AFK for ~4 weeks.

In D58329#1338905, @temcbun_gmail.com wrote:

Document descriptions should not have crossreferences especially, but really any child macros.
Manpage compiler upstream has said (quite strongly and hilariously actually) it's wrong.

But where exactly does it say this?

Get rid of .Xr in .Nd and make the .Nd itself more informative.

Thank you for the review!

I have not reviewed this because all I know about colors is how to turn them off, drives me crazy. Maybe... @dteske might know?

Ping.

Ping.

New D58086 for you to check.

Going to commit this. Will apply a few additional minor style (mostly, names, and a declaration moved to the corresponding block) changes in a separate commit.

In D57720#1331295, @temcbun_gmail.com wrote:

@ziaee Could you please MFC this commit (I see the commit message says it is to be MFCed after 3 days, but it's still not).

@ziaee Could you please MFC this commit (I see the commit message says it is to be MFCed after 3 days, but it's still not).

In D58038#1331015, @olce wrote:

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself.

Removing the hyphen in the first line is fine, but then that should be mentioned in the commit message. I can add a sentence to that effect myself. Which mail do you want to use? The one that can be inferred from your Phabricator login? I also see a mail at "zohomail" in the tree that could match. If you have to disclose the full name and don't want to do that here, then please mail it to me (olce@).

Remove hyphen from the first comment line. Thanks @ziaee!

Ping for review.

In the patch I just submitted, I inadvertently modified lines unrelated to the current fix, so I have reverted those lines to their original state.
I apologize for the error.

• Define the thermal interrupt callback function using typedef.
• Fix style issues.

Looks good modulo some minor style (in a broad sense) improvements. To ease things, I could apply these changes myself on commit. Please tell me if you object to that.

In D44454#1327923, @kib wrote:

Ed, feel free to merge this review.