Page MenuHomeFreeBSD

markj (Mark Johnston)
User

Projects (9)

User Details

User Since
Mar 12 2014, 1:00 AM (568 w, 1 d)

Recent Activity

Yesterday

markj committed rGeb9d8bafa485: contrib/tzdata: import tzdata 2025a (authored by philip).
contrib/tzdata: import tzdata 2025a
Wed, Jan 29, 7:01 PM
markj committed rGaef6b5321eea: Add updating entries and bump version (authored by markj).
Add updating entries and bump version
Wed, Jan 29, 7:01 PM
markj committed rGbb48aba6244c: cd9660: Make sure that struct ifid fits in generic filehandle structure (authored by markj).
cd9660: Make sure that struct ifid fits in generic filehandle structure
Wed, Jan 29, 7:01 PM
markj committed rG0365b776f1b1: ext2fs: Fix the size of struct ufid and add a static assert (authored by rmacklem).
ext2fs: Fix the size of struct ufid and add a static assert
Wed, Jan 29, 6:56 PM
markj committed rGe2bb7b33daa5: contrib/tzdata: import tzdata 2024b (authored by philip).
contrib/tzdata: import tzdata 2024b
Wed, Jan 29, 6:56 PM
markj committed rG88d5d8108711: OpenSSH: correct logic error in ObscureKeystrokeTiming (authored by emaste).
OpenSSH: correct logic error in ObscureKeystrokeTiming
Wed, Jan 29, 6:56 PM
markj committed rGc1c180910d46: etcupdate: Restrict access to the conflicts directory (authored by markj).
etcupdate: Restrict access to the conflicts directory
Wed, Jan 29, 6:56 PM
markj committed rG40928c124157: contrib/tzdata: import tzdata 2025a (authored by philip).
contrib/tzdata: import tzdata 2025a
Wed, Jan 29, 6:56 PM
markj committed rG8635fea6ed9f: contrib/tzdata: import tzdata 2024b (authored by philip).
contrib/tzdata: import tzdata 2024b
Wed, Jan 29, 6:56 PM
markj committed rGc90866090517: tarfs: Fix the size of struct tarfs_fid and add a static assert (authored by rmacklem).
tarfs: Fix the size of struct tarfs_fid and add a static assert
Wed, Jan 29, 6:56 PM
markj committed rGf2cc3336ad40: ext2fs: Fix the size of struct ufid and add a static assert (authored by rmacklem).
ext2fs: Fix the size of struct ufid and add a static assert
Wed, Jan 29, 6:56 PM
markj committed rGf7b9cd733c39: audit: Fix short-circuiting in syscallenter() (authored by markj).
audit: Fix short-circuiting in syscallenter()
Wed, Jan 29, 6:56 PM
markj committed rG4fdb8d1ab316: svc.c: Check for a non-NULL xp_socket (authored by rmacklem).
svc.c: Check for a non-NULL xp_socket
Wed, Jan 29, 6:56 PM
markj committed rG89321a8f5707: Add UPDATING entries and bump version (authored by markj).
Add UPDATING entries and bump version
Wed, Jan 29, 6:56 PM
markj committed rGb8945a926a2f: etcupdate: Restrict access to the conflicts directory (authored by markj).
etcupdate: Restrict access to the conflicts directory
Wed, Jan 29, 6:56 PM
markj committed rGd8083f5425fd: cd9660: Make sure that struct ifid fits in generic filehandle structure (authored by markj).
cd9660: Make sure that struct ifid fits in generic filehandle structure
Wed, Jan 29, 6:56 PM
markj committed rG1574c53178e9: audit: Fix short-circuiting in syscallenter() (authored by markj).
audit: Fix short-circuiting in syscallenter()
Wed, Jan 29, 6:56 PM
markj committed rGfaa47d299a0e: tarfs: Fix the size of struct tarfs_fid and add a static assert (authored by rmacklem).
tarfs: Fix the size of struct tarfs_fid and add a static assert
Wed, Jan 29, 6:56 PM
markj committed rG1f3cea9cc12c: ext2fs: Fix the size of struct ufid and add a static assert (authored by rmacklem).
ext2fs: Fix the size of struct ufid and add a static assert
Wed, Jan 29, 6:55 PM
markj committed rGb9149a3af722: contrib/tzdata: import tzdata 2025a (authored by philip).
contrib/tzdata: import tzdata 2025a
Wed, Jan 29, 6:55 PM
markj committed rGc55000e7c233: etcupdate: Restrict access to the conflicts directory (authored by markj).
etcupdate: Restrict access to the conflicts directory
Wed, Jan 29, 6:55 PM
markj committed rGa1e3ff6580de: Add UPDATING entries and bump version (authored by markj).
Add UPDATING entries and bump version
Wed, Jan 29, 6:55 PM
markj committed rG498561509061: cd9660: Make sure that struct ifid fits in generic filehandle structure (authored by markj).
cd9660: Make sure that struct ifid fits in generic filehandle structure
Wed, Jan 29, 6:55 PM
markj committed rG10f8a9df522f: ktrace: Fix uninitialized memory disclosure (authored by markj).
ktrace: Fix uninitialized memory disclosure
Wed, Jan 29, 6:55 PM
markj committed rG71bf983f92ba: audit: Fix short-circuiting in syscallenter() (authored by markj).
audit: Fix short-circuiting in syscallenter()
Wed, Jan 29, 6:55 PM
markj accepted D48712: riscv bhyve: remove clock-frequency.
Wed, Jan 29, 4:00 PM
markj accepted D48713: riscv bhyve: fix interrupts-extended.
Wed, Jan 29, 4:00 PM
markj accepted D48710: tcp: remove check for condition that never happens.
Wed, Jan 29, 3:00 PM
markj committed rG94fb5ab9043c: Revert "dtrace/arm64: Simplify dtrace_getarg() slightly" (authored by markj).
Revert "dtrace/arm64: Simplify dtrace_getarg() slightly"
Wed, Jan 29, 3:13 AM
markj added a reverting change for rG70c067062217: dtrace/arm64: Simplify dtrace_getarg() slightly: rG94fb5ab9043c: Revert "dtrace/arm64: Simplify dtrace_getarg() slightly".
Wed, Jan 29, 3:13 AM
markj committed rG4da070ce6c01: dtrace/arm64: Fix enumeration of FBT return probes (authored by markj).
dtrace/arm64: Fix enumeration of FBT return probes
Wed, Jan 29, 2:22 AM
markj committed rG70c067062217: dtrace/arm64: Simplify dtrace_getarg() slightly (authored by markj).
dtrace/arm64: Simplify dtrace_getarg() slightly
Wed, Jan 29, 2:22 AM
markj committed rG51688136b161: libdtrace: Use designators to initialize the opcode array (authored by markj).
libdtrace: Use designators to initialize the opcode array
Wed, Jan 29, 2:22 AM

Tue, Jan 28

markj updated the diff for D48665: tests: Add some FIB multibind test cases.

Add some tests for raw sockets.

Tue, Jan 28, 6:11 PM
markj requested review of D48707: rawip: Add a bind_all_fibs mode.
Tue, Jan 28, 6:10 PM
markj updated the diff for D48666: socket: Move SO_SETFIB handling to protocol layers.

Update raw socket option handlers as well.

Tue, Jan 28, 6:10 PM
markj updated the diff for D48664: udp: Add a sysctl to control binding.

Handle multicast sockets as well.

Tue, Jan 28, 6:08 PM
markj committed rG17e935f1f327: etcupdate: Restrict access to the conflicts directory (authored by markj).
etcupdate: Restrict access to the conflicts directory
Tue, Jan 28, 4:08 PM
markj committed rG93836ff92be8: etcupdate: Restrict access to the conflicts directory (authored by markj).
etcupdate: Restrict access to the conflicts directory
Tue, Jan 28, 4:07 PM
markj committed rGbe53f732663c: bsdinstall: hook up help line and prompt for ZFS disk selection (authored by franco_opnsense.org).
bsdinstall: hook up help line and prompt for ZFS disk selection
Tue, Jan 28, 4:01 PM
markj committed rGcd1f435f4819: rtsold: Further usage message updates (authored by markj).
rtsold: Further usage message updates
Tue, Jan 28, 4:01 PM
markj committed rG66ff03065def: ls: Release resources before returning from traverse() (authored by markj).
ls: Release resources before returning from traverse()
Tue, Jan 28, 4:01 PM
markj committed rG3ba946aebf74: rtsold: Add -i to the usage message (authored by markj).
rtsold: Add -i to the usage message
Tue, Jan 28, 4:01 PM
markj committed rG5289625dfecb: zinject: Fix format string errors on 32-bit platforms (authored by markj).
zinject: Fix format string errors on 32-bit platforms
Tue, Jan 28, 3:12 PM
markj committed rGc43ae7ab4bf8: etcupdate: Restrict access to the conflicts directory (authored by markj).
etcupdate: Restrict access to the conflicts directory
Tue, Jan 28, 2:30 PM
markj closed D48576: etcupdate: Restrict access to the conflicts directory.
Tue, Jan 28, 2:29 PM
markj committed rG63efd7f5ac66: socket tests: Add a test which calls listen() twice on an lb socket (authored by markj).
socket tests: Add a test which calls listen() twice on an lb socket
Tue, Jan 28, 2:23 PM
markj closed D48702: socket tests: Add a test which calls listen() twice on an lb socket.
Tue, Jan 28, 2:23 PM

Mon, Jan 27

markj accepted D48703: sockets/tcp: quick fix for regression with SO_REUSEPORT_LB.
Mon, Jan 27, 11:14 PM
markj requested review of D48702: socket tests: Add a test which calls listen() twice on an lb socket.
Mon, Jan 27, 10:24 PM
markj added a comment to D48659: sysctl: Add a regression test which runs sysctl -a.

does sysctl -o still pass all the data to userspace but then only print the first bit?

Mon, Jan 27, 6:14 PM
markj updated the diff for D48659: sysctl: Add a regression test which runs sysctl -a.
  • Use -o instead of -x: with the latter sysctl(8) will print a huge amount of output and is a couple orders of magnitude slower. We get the same kernel coverage with -o, so just use that.
  • Avoid using atf_check: it causes kyua to buffer all of the output in memory and then store it in the test results DB, which is somewhat unwieldy. Check the exit status manually.
Mon, Jan 27, 5:51 PM
markj added a comment to D48666: socket: Move SO_SETFIB handling to protocol layers.

The change definitely improves, but some questions remain :) Why do we need to store fib both in socket and inpcb? I believe it belongs only to the inpcb, cause many sockets (unix, netlink, ...) doesn't have a notion of forwarding. The rtsock(4) doesn't have notion of forwarding, but we use it configure other protocols forwarding, hence it needs fib. But it has its own pcb that of course can store fib.

Mon, Jan 27, 3:42 PM
markj updated the diff for D48660: inpcb: Imbue in(6)_pcblookup_local() with a FIB parameter.

Use RT_ALL_FIBS instead of -1 as a sentinel value.

Mon, Jan 27, 2:59 PM
markj updated the diff for D48659: sysctl: Add a regression test which runs sysctl -a.

Add -x to the sysctl flags

Mon, Jan 27, 2:53 PM
markj accepted D48679: ip6addrctl(8): Teach ip6addrctl to attach and run itself in a jail.
Mon, Jan 27, 2:17 PM

Sat, Jan 25

markj committed rG494a2b14722e: dtrace: Remove the noinline qualifier from dtrace_getarg() (authored by markj).
dtrace: Remove the noinline qualifier from dtrace_getarg()
Sat, Jan 25, 5:34 PM
markj committed rG853cd8723494: arm64: Clean up usage of the dtrace invop handler (authored by markj).
arm64: Clean up usage of the dtrace invop handler
Sat, Jan 25, 5:34 PM
markj committed rG096a5c6cd28c: libdtrace: Generalize handling of data models a bit (authored by markj).
libdtrace: Generalize handling of data models a bit
Sat, Jan 25, 4:03 PM

Fri, Jan 24

markj committed rGc81417289606: open.2: update description for O_PATH (authored by CismonX <admin@cismon.net>).
open.2: update description for O_PATH
Fri, Jan 24, 8:17 PM
markj committed rGd726bc286325: bsdinstall: hook up help line and prompt for ZFS disk selection (authored by franco_opnsense.org).
bsdinstall: hook up help line and prompt for ZFS disk selection
Fri, Jan 24, 7:40 PM
markj committed rGdc273058cb0b: ure(4): Add support for ELECOM EDC-QUA3C (authored by FUKAUMI Naoki <naoki@radxa.com>).
ure(4): Add support for ELECOM EDC-QUA3C
Fri, Jan 24, 7:26 PM
markj abandoned D37420: ossl: add supprot for ARMv7.

This was committed in 44f8e1e8530e1d2e95e84bbbe3d22ac9cb2557fe

Fri, Jan 24, 7:16 PM
markj added a comment to rG44f8e1e8530e: ossl: Add support for armv7.
Fri, Jan 24, 7:15 PM
markj commandeered D37420: ossl: add supprot for ARMv7.
Fri, Jan 24, 7:15 PM
markj abandoned D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.

This was committed in 629a72376d51aad812d6f1279403bc81c38c35d2

Fri, Jan 24, 7:14 PM
markj commandeered D37421: ossl: Add AES-GCM implementation for ARMv7 NEON.
Fri, Jan 24, 7:13 PM
markj requested review of D48666: socket: Move SO_SETFIB handling to protocol layers.
Fri, Jan 24, 5:04 PM
markj requested review of D48665: tests: Add some FIB multibind test cases.
Fri, Jan 24, 5:04 PM
markj requested review of D48664: udp: Add a sysctl to control binding.
Fri, Jan 24, 5:04 PM
markj requested review of D48663: tcp: Add a sysctl to affect listening socket behaviour.
Fri, Jan 24, 5:04 PM
markj requested review of D48662: inpcb: Add FIB-aware inpcb lookup.
Fri, Jan 24, 5:04 PM
markj requested review of D48661: inpcb: Add a flags parameter to in_pcbbind().
Fri, Jan 24, 5:04 PM
markj requested review of D48660: inpcb: Imbue in(6)_pcblookup_local() with a FIB parameter.
Fri, Jan 24, 5:03 PM
markj updated the diff for D48659: sysctl: Add a regression test which runs sysctl -a.

Improve test descriptions.

Fri, Jan 24, 4:59 PM
markj updated the diff for D48659: sysctl: Add a regression test which runs sysctl -a.

Go a bit further: add a test which does the same thing in a jail.

Fri, Jan 24, 4:55 PM
markj requested review of D48659: sysctl: Add a regression test which runs sysctl -a.
Fri, Jan 24, 4:52 PM
markj committed rG04a3ca71ead6: netcat: Add a flag to enable the use of SO_REUSEPORT_LB (authored by markj).
netcat: Add a flag to enable the use of SO_REUSEPORT_LB
Fri, Jan 24, 4:49 PM
markj closed D48543: netcat: Add a flag to enable the use of SO_REUSEPORT_LB.
Fri, Jan 24, 4:49 PM
markj accepted D48632: vm_page_startup(): Clarify memory lowest, highest and size computation.
Fri, Jan 24, 4:45 PM
markj added inline comments to D48649: rpcsec_tls: cleanup the rpctls_syscall().
Fri, Jan 24, 4:35 PM
markj added a comment to D48634: vm_phys_early_alloc(): Switch order of arguments.

It seems more intuitive to specify the requested size first.

Fri, Jan 24, 4:33 PM
markj added inline comments to D48570: rpc.tlsservd: provide parallelism with help of pthread(3).
Fri, Jan 24, 4:30 PM
markj added inline comments to D48550: libc/rpc: add userland side RPC server over netlink(4).
Fri, Jan 24, 4:22 PM
markj added a comment to D48549: krpc: add kernel side client over netlink(4).

I'm not very familiar with netlink nor RPC internals, so it's hard to make useful comments.

Fri, Jan 24, 4:08 PM
markj accepted D48548: xdr: provide x_putmbuf method for xdrmem.
Fri, Jan 24, 3:53 PM
markj updated the diff for D48523: linuxkpi: Introduce a properly typed jiffies.

Fix MAX_JIFFY_OFFSET, remove an uneeded cast, add an XXX comment for jiffies_64.

Fri, Jan 24, 3:48 PM
markj added inline comments to D48523: linuxkpi: Introduce a properly typed jiffies.
Fri, Jan 24, 3:47 PM
markj updated subscribers of D48650: routing: do not allow PINNED routes to be overridden.

This change addresses the failing test, but there's a new failure in sys/netinet/fibs_test:same_ip_multiple_ifaces_fib0. The test creates two interfaces, then assigns the same IP address to each, with different masks. With this change, the second address assignment fails with EEXIST.

Fri, Jan 24, 3:37 PM
markj added a comment to D48633: vm_phys_early_alloc(): Add diagnostics and comments.

Panic after each search for biggest ranges if no range was found at all.

Fri, Jan 24, 3:14 PM
markj added inline comments to D48632: vm_page_startup(): Clarify memory lowest, highest and size computation.
Fri, Jan 24, 3:02 PM
markj accepted D48631: vm_phys_early_startup(): Panic if phys_avail[] is empty.
Fri, Jan 24, 2:52 PM
markj accepted D48630: vm_phys_avail_split(): Tolerate split requests at boundaries.
Fri, Jan 24, 2:51 PM
markj added inline comments to D48630: vm_phys_avail_split(): Tolerate split requests at boundaries.
Fri, Jan 24, 2:51 PM
markj added inline comments to D48629: vm_phys_avail_count(): Fix out-of-bounds accesses.
Fri, Jan 24, 2:47 PM
markj added inline comments to D48628: vm_phys: Check for overlap when adding a segment.
Fri, Jan 24, 2:46 PM
markj accepted D48627: vm_phys_add_seg(): Check for bad segments, allow empty ones.
Fri, Jan 24, 2:41 PM
markj accepted D48626: vm_phys_avail_check(): Check index parity, fix panic messages.
Fri, Jan 24, 2:39 PM
markj added inline comments to D48401: bhyvectl.8: Polish.
Fri, Jan 24, 2:39 PM
markj committed rG3dc18af5770f: savecore: add a test for LOG_PERROR (authored by stephane.rochoy_stormshield.eu).
savecore: add a test for LOG_PERROR
Fri, Jan 24, 2:37 PM