Page MenuHomeFreeBSD
Differential D53820

sys/_types.h: define fallback __(u)intcap_t
AcceptedPublic
Actions

Authored by brooks on Wed, Nov 19, 11:18 AM.
Tags
None
Referenced Files
F136793588: D53820.id166753.diff
Wed, Nov 19, 2:29 PM
F136791782: D53820.id.diff
Wed, Nov 19, 2:09 PM
F136790939: D53820.diff
Wed, Nov 19, 2:02 PM
Subscribers
markj

Details

Reviewers
imp
kib
Group Reviewers
cheri
Summary

intcap_t and uintcap_t are new primative types in CHERI-aware ABIs
that are used to define (u)intptr_t. To allow coexistance of integer
pointers and hybrid code, define them to __(u)intptr_t when they are
not otherwise available.

Effort: CHERI upstreaming
Sponsored by: Innovate UK

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 68728
Build 65611: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Wed, Nov 19, 11:18 AM
brooks created this revision.
Harbormaster completed remote builds in B68728: Diff 166753.Wed, Nov 19, 11:18 AM
brooks added a parent revision: D53819: sys/_types.h: define __(u)int(f)ptr_t for CHERI.Wed, Nov 19, 11:18 AM
brooks added a child revision: D53821: sys/_types.h: add void * to __max_align_t.
brooks added a comment.Wed, Nov 19, 11:23 AM

On CheriBSD we also include intcap_t and uintcap_t to be friendly, but we're trying to discourage the hybrid programming model so I'd like to stick with __ variants in FreeBSD.

kib accepted this revision.Wed, Nov 19, 1:47 PM
This revision is now accepted and ready to land.Wed, Nov 19, 1:47 PM
markj added a subscriber: markj.Wed, Nov 19, 3:07 PM
markj added inline comments.
sys/sys/_types.h
159

I'd be more explicit here about when these types are supposed to be useful, i.e., when exactly they should be used instead of (u)intptr_t. Like, would we ever use these in the base system?

Revision Contents
Changeset List

PathSize
sys/
sys/
8 lines

Diff 166753

View Options

sys/sys/_types.h

Loading...