stand: Add back missing EFIAPI define
ClosedPublic
Actions

Authored by imp on Tue, Nov 18, 4:26 AM.

Tags

None

Referenced Files

	F136850807: D53799.id166649.diff
	Thu, Nov 20, 2:23 AM

	F136850784: D53799.id166651.diff
	Thu, Nov 20, 2:23 AM

	F136850427: D53799.id.diff
	Thu, Nov 20, 2:20 AM

	F136850316: D53799.diff
	Thu, Nov 20, 2:18 AM

	Unknown Object (File)
	Wed, Nov 19, 1:49 AM

	Unknown Object (File)
	Tue, Nov 18, 7:22 PM

	Unknown Object (File)
	Tue, Nov 18, 5:50 PM

	Unknown Object (File)
	Tue, Nov 18, 5:48 PM

View All 18 Files

Subscribers

markj

olce

Details

Reviewers

markj

Commits

rG396b32e801d6: stand: Add back missing EFIAPI define

Summary

EFIAPI has to be defined correctly for amd64, or things won't boot
because it uses a different API than we normally use.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp requested review of this revision.Tue, Nov 18, 4:26 AM

imp created this revision.

Harbormaster completed remote builds in B68708: Diff 166649.Tue, Nov 18, 4:27 AM

imp added inline comments.Tue, Nov 18, 4:31 AM

sys/sys/efi-edk2.h
48	Note: this might need a #ifndef arm around it, since the old armv7 file didn't do that. But I think we have bigger arm issues that I need to sort out.

Seems ok, this is really just a Tested-by: markj

This revision is now accepted and ready to land.Tue, Nov 18, 4:40 AM

Closed by commit rG396b32e801d6: stand: Add back missing EFIAPI define (authored by imp). · Explain WhyTue, Nov 18, 4:46 AM

This revision was automatically updated to reflect the committed changes.

imp added a commit: rG396b32e801d6: stand: Add back missing EFIAPI define.

imp added inline comments.Tue, Nov 18, 4:49 AM

sys/sys/efi-edk2.h
48	Turns out arm works w/o an arm ifdef. And I don't think we enable _MSC_EXTENSIONS and I think even if we did, __cdecl would #define away. Fun times.
79–80	I'll fix the comment

Minor nits in comments.

sys/sys/efi-edk2.h
48
52

Revision Contents
Changeset List

Path

Size

sys/

efi-edk2.h

21 lines

Diff 166651

View Options

stand: Add back missing EFIAPI defineClosedPublicActions