Page MenuHomeFreeBSD
Differential D53799

stand: Add back missing EFIAPI define
ClosedPublic
Actions

Authored by imp on Nov 18 2025, 4:26 AM.
Tags
None
Referenced Files
F149790874: D53799.diff
Fri, Mar 27, 3:06 AM
Unknown Object (File)
Thu, Mar 26, 6:48 AM
Unknown Object (File)
Thu, Mar 26, 6:48 AM
Unknown Object (File)
Wed, Mar 18, 9:41 PM
Unknown Object (File)
Tue, Mar 17, 11:37 PM
Unknown Object (File)
Tue, Mar 17, 5:21 PM
Unknown Object (File)
Sun, Mar 15, 5:21 AM
Unknown Object (File)
Tue, Mar 10, 4:22 PM
View All 45 Files
Subscribers
markj
olce

Details

Reviewers
markj
Commits
rG396b32e801d6: stand: Add back missing EFIAPI define
Summary

EFIAPI has to be defined correctly for amd64, or things won't boot
because it uses a different API than we normally use.

Sponsored by: Netflix

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp requested review of this revision.Nov 18 2025, 4:26 AM
imp created this revision.
Harbormaster completed remote builds in B68708: Diff 166649.Nov 18 2025, 4:27 AM
imp added inline comments.Nov 18 2025, 4:31 AM
sys/sys/efi-edk2.h
48

Note: this might need a #ifndef arm around it, since the old armv7 file didn't do that.
But I think we have bigger arm issues that I need to sort out.

markj accepted this revision.Nov 18 2025, 4:40 AM
markj added a subscriber: markj.

Seems ok, this is really just a Tested-by: markj

This revision is now accepted and ready to land.Nov 18 2025, 4:40 AM
Closed by commit rG396b32e801d6: stand: Add back missing EFIAPI define (authored by imp). · Explain WhyNov 18 2025, 4:46 AM
This revision was automatically updated to reflect the committed changes.
imp added a commit: rG396b32e801d6: stand: Add back missing EFIAPI define.
imp added inline comments.Nov 18 2025, 4:49 AM
sys/sys/efi-edk2.h
48

Turns out arm works w/o an arm ifdef. And I don't think we enable _MSC_EXTENSIONS and I think even if we did, __cdecl would #define away. Fun times.

79–80

I'll fix the comment

olce added a subscriber: olce.Nov 18 2025, 12:39 PM

Minor nits in comments.

sys/sys/efi-edk2.h
48
52

Revision Contents
Changeset List

PathSize
sys/
sys/
21 lines

Diff 166651

View Options

sys/sys/efi-edk2.h

Loading...