Differential D52968

vmm: My attempt at fixing the rendezvous deadlock
Needs ReviewPublic
Actions

Authored by markj on Tue, Oct 7, 8:13 PM.

Tags

None

Referenced Files

	F132101033: D52968.id163723.diff
	Mon, Oct 13, 5:06 PM

	Unknown Object (File)
	Sun, Oct 12, 9:36 AM

	Unknown Object (File)
	Sun, Oct 12, 9:34 AM

	Unknown Object (File)
	Fri, Oct 10, 9:45 PM

	Unknown Object (File)
	Thu, Oct 9, 1:47 PM

	Unknown Object (File)
	Thu, Oct 9, 1:46 PM

	Unknown Object (File)
	Thu, Oct 9, 12:44 PM

	Unknown Object (File)
	Wed, Oct 8, 11:53 AM

View All 13 Files

Subscribers

Details

Reviewers

corvink
andrew
manu

Group Reviewers

Summary

This is a WIP, not intended to be committed as-is.

Implement vcpu_lock_all() in a way that avoids deadlocks with
vm_smp_rendezvous(). In particular, when traversing vCPUs, invoke the
rendezvous callback on the vCPU's behalf to help the initiator finish.
We can only safely do so when the vCPU is IDLE or we have already locked
it.

Diff Detail

Repository

rG FreeBSD src repository

Lint

Lint Skipped

Unit

Tests Skipped

Build Status

Buildable 67625
Build 64508: arc lint + arc unit

Event Timeline

markj created this revision.Tue, Oct 7, 8:13 PM

Herald added a reviewer: andrew. · View Herald TranscriptTue, Oct 7, 8:13 PM

Herald added a reviewer: andrew. · View Herald Transcript

Herald added a reviewer: manu. · View Herald Transcript

Herald added a reviewer: bhyve. · View Herald Transcript

Herald added subscribers: riscv, bcran, rgrimes and 2 others. · View Herald Transcript

markj requested review of this revision.Tue, Oct 7, 8:13 PM

Harbormaster completed remote builds in B67625: Diff 163723.Tue, Oct 7, 8:13 PM

markj mentioned this in D52781: sys/amd64/vmm: fix Windows 11 deadlock.Tue, Oct 7, 8:14 PM

Revision Contents
Changeset List

Path

Size

sys/

amd64/

include/

3 lines

vmm/

172 lines

arm64/

include/

2 lines

vmm/

4 lines

dev/

vmm/

33 lines

riscv/

include/

2 lines

vmm/

4 lines

Diff 163723

sys/amd64/include/vmm.h

Loading...

sys/amd64/vmm/vmm.c

Loading...

sys/arm64/include/vmm.h

Loading...

sys/arm64/vmm/vmm.c

Loading...

sys/dev/vmm/vmm_dev.c

Loading...

sys/riscv/include/vmm.h

Loading...

sys/riscv/vmm/vmm.c

Loading...