Page MenuHomeFreeBSD

rc.subr: Remove misguided cpuset usage
AcceptedPublic

Authored by markj on Thu, Nov 13, 9:36 PM.
Tags
None
Referenced Files
F136608571: D53746.diff
Tue, Nov 18, 1:52 PM
Unknown Object (File)
Sun, Nov 16, 2:51 AM
Unknown Object (File)
Sun, Nov 16, 2:41 AM
Unknown Object (File)
Sun, Nov 16, 2:39 AM
Unknown Object (File)
Fri, Nov 14, 8:01 AM
Unknown Object (File)
Fri, Nov 14, 6:47 AM
Unknown Object (File)
Fri, Nov 14, 1:45 AM
Unknown Object (File)
Fri, Nov 14, 1:14 AM
Subscribers

Details

Reviewers
0mp
Group Reviewers
rc
Summary

When running an rc command, if the target rc script defines
<command>_cmd, e.g., start_cmd=..., then the run_rc_command() executes
that instead of $command. In general it's a shell function, and
"cpuset -l <n> <shell function>" doesn't work.

Moreover, it doesn't really make sense to run cpuset for anything other
than start_cmd.

Other optional isolation mechanisms (e.g., <name>_fib,
<name>_chroot) are only used when invoking $command directly as part of
the "start" command. Make <name>_cpuset consistent with everything else
by removing these extraneous cpuset invocations.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 68620
Build 65503: arc lint + arc unit