Are you able to follow this up? I'm still unsure when a PR is better than a review, so sorry if I've messed up protocol.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
May 20 2024
May 20 2024
My only comment is that, reading the code, it's not immediately obvious why we give up right away when failing to acquire the buf lock, but not when we successfully acquire the buf lock and discover that the buffer identity has changed. A comment explaining that we want to avoid touching the interlock when the "locked lock" is probably going to fail anyway would help, I think.
wosch committed rG37be4197f72a: man: the exists function needs to validate the first parameter (authored by wosch).
man: the exists function needs to validate the first parameter
Address whitespace issues.
I didn't know .so wasn't wildly used - I just happened to stumbl on the issue with port net/libmaxminddb
The patch is fine as is, but it does not fully address the issue described in the commit message, only D45256 does actually resolve it. You could either merge the two commits (and commit messages) when D45256 is ready, or adapt the commit messages to describe what part of the issue is addressed in each.
x11/shotman: update to 0.4.6
x11/shotman: update to 0.4.6
dev_submerge.ch added a comment to D45164: sound: Separate implementations for SNDCTL_AUDIOINFO[_EX] and SNDCTL_ENGINEINFO.
Uhm, sorry again, how do I take back the review accepted and change requested flags?
christos added inline comments to D45154: mixer.3: Showcase example of how to loop through all mixers.
dev_submerge.ch requested changes to D45164: sound: Separate implementations for SNDCTL_AUDIOINFO[_EX] and SNDCTL_ENGINEINFO.
Sorry, this was meant for D45150, "Login to comment" took me to the wrong page.
dch updated the summary of D45269: Summary: port & dependencies for Anthropic's Claude3 LLM and Datasette.
dev_submerge.ch added inline comments to D45154: mixer.3: Showcase example of how to loop through all mixers.
dch updated the diff for D45269: Summary: port & dependencies for Anthropic's Claude3 LLM and Datasette.
add Anthropic SDK and add as dependency to llm-claude-3
The change is good and even if we update this script ~eadler/bin/whodid isn't the right place for it. But I think you must have a very old tree based on the en_US.ISO8859-1 and .xml extension.
dev_submerge.ch accepted D45164: sound: Separate implementations for SNDCTL_AUDIOINFO[_EX] and SNDCTL_ENGINEINFO.
The patch is fine as is, but it does not fully address the issue described in the commit message, only D45256 does actually resolve it. You could either merge the two commits (and commit messages) when D45256 is ready, or adapt the commit messages to describe what part of the issue is addressed in each.
Can we have a regression test case for this?
jhale added a reverting change for R11:f1cd45a6680d: devel/ninja: Update to 1.12.1: R11:9307e7dd80dd: Revert "devel/ninja: Update to 1.12.1".
Revert "devel/ninja: Update to 1.12.1"
pi committed R11:61971843fd48: editors/neovim: update 0.9.5 -> 0.10.0 (authored by Laurant Chardon <laurent.chardon@gmail.com>).
editors/neovim: update 0.9.5 -> 0.10.0
brooks added a reverting change for rGb25ceb97eddc: Revert "Make WITHOUT_UNDEFINED_VERSION the default": rG6edb14c006f6: Make WITHOUT_UNDEFINED_VERSION the default.
Make WITHOUT_UNDEFINED_VERSION the default
audio/linuxwave: back to default zig
devel/zls: update to 0.12.0
x11-wm/river: update to 0.3.2
x11/waylock: update to 1.1.0
lang/zig: fork 0.11 into a pinned port
jbeich committed R11:bec41b713392: biology/vcflib: add upstream reference for zig >= 0.11 (authored by jbeich).
biology/vcflib: add upstream reference for zig >= 0.11
lang/zig: update to 0.12.0
astro/mepo: update to 1.2.1
jbeich committed R11:55f0537a0484: lang/zig: adjust CONFLICTS after 98d70399e765 (authored by bsd_orsolic.org).
lang/zig: adjust CONFLICTS after 98d70399e765
jbeich committed R11:8c51d3a8ca38: lang/zig: drop unused dependency on archivers/lzma (authored by bsd_orsolic.org).
lang/zig: drop unused dependency on archivers/lzma
jbeich committed R11:a14183bb8404: lang/zig010: drop unused dependency on archivers/lzma (authored by bsd_orsolic.org).
lang/zig010: drop unused dependency on archivers/lzma
jbeich committed R11:7a200185378b: lang/zig: pacify check-plist after 8c1e3e605452 (authored by bsd_orsolic.org).
lang/zig: pacify check-plist after 8c1e3e605452
markj added inline comments to D45244: Stop treating size 0 as unknown size in vnode_create_vobject()..
diff: Nits in tests.
christos committed rG64f4e2db6d19: sound: Correctly check nvlist_unpack() error (authored by christos).
sound: Correctly check nvlist_unpack() error
christos committed rG074d337ad618: sound: Check user-supplied size passed to SNDSTIOC_ADD_USER_DEVS* (authored by christos).
sound: Check user-supplied size passed to SNDSTIOC_ADD_USER_DEVS*
markj added inline comments to D45236: sound: Check user-supplied size passed to SNDSTIOC_ADD_USER_DEVS*.
christos committed rG5d1a5d6f1f59: sound: Prevent uninitialized variable destruction in chn_init() (authored by christos).
sound: Prevent uninitialized variable destruction in chn_init()
christos committed rG2db2292dac73: sound: Get rid of redundant assignments in chn_init() (authored by christos).
sound: Get rid of redundant assignments in chn_init()
markj added inline comments to D45272: sound: Prevent uninitialized variable destruction in chn_init().
christos updated the diff for D45272: sound: Prevent uninitialized variable destruction in chn_init().
Address Mark's comment.
christos added inline comments to D45272: sound: Prevent uninitialized variable destruction in chn_init().
christos requested review of D45272: sound: Prevent uninitialized variable destruction in chn_init().
graphics/cimg: upgrade to v.3.3.6
markj committed rGc39084799647: wg tests: Add a simple regression test case for netmap support (authored by markj).
wg tests: Add a simple regression test case for netmap support
wg: Add netmap support
clang-format: Minor tweaks
• karels committed rG0b39b2e2ddb2: adduser: create dataset only if home is directly within dataset (authored by • karels).
adduser: create dataset only if home is directly within dataset
libdiff: Add a test for the truncation issue.
diff: Warn if the atomizer detected truncation.
libdiff: Detect and recover from file truncation.
mail/roundcube: update to 1.6.7 release.
arrowd committed R11:db2120b357c4: ports-mgmt/pkg-appstream: update to 1.0.3 (authored by Zhuneva Maria <mzhyneva@gmail.com>).
ports-mgmt/pkg-appstream: update to 1.0.3
arrowd committed R11:b0458f0daa92: security/linux-rl9-libsecret: add new port (authored by Alexey Donskov <aadonsk4@mts.ru>).
security/linux-rl9-libsecret: add new port
Mikael Urankar <mikael@FreeBSD.org> committed R11:18c52fb99052: editors/parinfer-rust: Mark as broken on i386 (authored by Mikael Urankar <mikael@FreeBSD.org>).
editors/parinfer-rust: Mark as broken on i386
Mikael Urankar <mikael@FreeBSD.org> committed R11:7aa4f968b4c5: security/rustscan: Mark as broken on i386 (authored by Mikael Urankar <mikael@FreeBSD.org>).
security/rustscan: Mark as broken on i386
correct nvmupdate port
schakrabarti_microsoft.com added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
oci: update image formats for Oracle Cloud
Looks great
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
added changes for function pointer and contigmalloc
- Merge branch 'freebsd:main' into review_branch
- added some changes
- refactored with pointer
- pointer for the function
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
- Merge branch 'freebsd:main' into review_branch
- added some changes
- refactored with pointer
- pointer for the function