Differential D45239

lang/ruby34: Add new port
Needs ReviewPublic
Actions

Authored by yasu on Sat, May 18, 7:47 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 22, 3:28 AM

	Unknown Object (File)
	Wed, May 22, 3:24 AM

	Unknown Object (File)
	Wed, May 22, 2:48 AM

	Unknown Object (File)
	Tue, May 21, 5:13 PM

Subscribers

Details

Reviewers

mfechner
sunpoet
tota

Summary

Add preview1 of Ruby 3.4 series.

ReleaseNotes: https://www.ruby-lang.org/en/news/2024/05/16/ruby-3-4-0-preview1-released/

Test Plan

Build succeeds with poudriere and 14.0-RELEASE amd64 jail.
Pass check of portlint, portclippy and portfmt.

Diff Detail

Repository

R11 FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 57749
Build 54637: arc lint + arc unit

Event Timeline

yasu requested review of this revision.Sat, May 18, 7:47 AM

yasu created this revision.

Harbormaster completed remote builds in B57749: Diff 138710.Sat, May 18, 7:47 AM

lwhsu added a subscriber: lwhsu.Sat, May 18, 10:53 AM

diizzy added a subscriber: diizzy.Sun, May 19, 8:17 AM

diizzy added inline comments.

lang/ruby34/Makefile
18	${LOCALBASE} in LIB_DEPENDS in doesn't work?
40	I guess this falls under style preference but for consistency and logical reasons I'd place these variables before CONFIGURE_ARGS
43	Should be formatted so it's readable?

yasu added inline comments.Mon, May 20, 2:16 PM

lang/ruby34/Makefile
18	Do you mean such line as below? LIB_DEPENDD= ${LOCALBASE}/lib/libffi.so:devel/libffi If so, unfortunately it doesn't.
40	Order of variables in Makefile is sorted with portclippy.
43	It is formatted with portfmt.

Revision Contents
Changeset List

Path

Size

Mk/

Uses/

11 lines

bsd.default-versions.mk

2 lines

lang/

1 line

ruby34/

203 lines

3 lines

files/

patch-common.mk

26 lines

patch-configure.ac

36 lines

patch-lib_mkmf.rb

11 lines

patch-lib_rdoc_generator_json__index.rb

20 lines

patch-tool_mkconfig.rb

14 lines

17 lines

44 lines

16195 lines

Diff 138710

Mk/Uses/ruby.mk

Loading...

Mk/bsd.default-versions.mk

Loading...

lang/Makefile

Loading...

lang/ruby34/Makefile

Loading...

lang/ruby34/distinfo

Loading...

lang/ruby34/files/patch-common.mk

Loading...

lang/ruby34/files/patch-configure.ac

Loading...

lang/ruby34/files/patch-lib_mkmf.rb

Loading...

lang/ruby34/files/patch-lib_rdoc_generator_json__index.rb

Loading...

lang/ruby34/files/patch-tool_mkconfig.rb

Loading...

lang/ruby34/pkg-descr

Loading...

lang/ruby34/pkg-message

Loading...

lang/ruby34/pkg-plist

Loading...