Page MenuHomeFreeBSD

schakrabarti_microsoft.com (souradeep chakrabarti)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 8 2022, 11:19 AM (122 w, 4 d)

Recent Activity

Jun 6 2024

schakrabarti_microsoft.com requested review of D45521: TLB flush enhancement using hypercall in Hyper-V .
Jun 6 2024, 7:29 PM
schakrabarti_microsoft.com abandoned D45520: TLB flush enhancement using hypercalls in Hyper-V.
Jun 6 2024, 7:25 PM
schakrabarti_microsoft.com removed a reviewer for D45520: TLB flush enhancement using hypercalls in Hyper-V: whu.
Jun 6 2024, 7:07 PM
schakrabarti_microsoft.com requested review of D45520: TLB flush enhancement using hypercalls in Hyper-V.
Jun 6 2024, 6:57 PM
schakrabarti_microsoft.com abandoned D45519: TLB flush enhancement using HyperCalls in x86 Hyper-V.
Jun 6 2024, 6:53 PM
schakrabarti_microsoft.com requested review of D45519: TLB flush enhancement using HyperCalls in x86 Hyper-V.
Jun 6 2024, 6:52 PM

Jun 3 2024

schakrabarti_microsoft.com added inline comments to D45235: libkern: add ilog2 helpers.
Jun 3 2024, 3:18 PM

May 29 2024

schakrabarti_microsoft.com added inline comments to D45235: libkern: add ilog2 helpers.
May 29 2024, 6:06 PM
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.

Fixed minor indentation.

May 29 2024, 6:00 AM

May 22 2024

schakrabarti_microsoft.com added inline comments to D45235: libkern: add ilog2 helpers.
May 22 2024, 5:11 PM

May 21 2024

schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
  • small correction
May 21 2024, 12:39 PM
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
  • added extra line
May 21 2024, 12:37 PM
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
  • some more cleanup
May 21 2024, 12:28 PM
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
  • fixed smp tb shootdown function pointer
  • fixed double declaration and cleanup
  • fixed indentation
May 21 2024, 10:04 AM
schakrabarti_microsoft.com added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
May 21 2024, 9:29 AM

May 20 2024

schakrabarti_microsoft.com added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
May 20 2024, 1:01 PM
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.

added changes for function pointer and contigmalloc

  • Merge branch 'freebsd:main' into review_branch
    • added some changes
    • refactored with pointer
    • pointer for the function
May 20 2024, 12:57 PM
schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.
  • Merge branch 'freebsd:main' into review_branch
  • added some changes
  • refactored with pointer
  • pointer for the function
May 20 2024, 12:55 PM

May 16 2024

schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.

Changed the structure to remove extra FAM attribute.

May 16 2024, 7:00 PM

May 15 2024

schakrabarti_microsoft.com added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
May 15 2024, 10:14 AM
schakrabarti_microsoft.com added inline comments to D45174: TLB flush enlightment using Hyper-V hypercall.
May 15 2024, 5:56 AM

May 14 2024

schakrabarti_microsoft.com added a reviewer for D45174: TLB flush enlightment using Hyper-V hypercall: kib.
May 14 2024, 1:07 PM
schakrabarti_microsoft.com added a comment to D45174: TLB flush enlightment using Hyper-V hypercall.

The patch adds a macro in kernel.mk NO_WNO_GNU_VARIABLE_SIZED_TYPE_NOT_AT_END, to add an exception for compilation of hyperv_mmu.c c in conf/files.x86 .
This is to address the compiler warning for multiple fam attributes in hv_tlb_flush_ex structure. We are working with Hyper-V team on changing the structure definition for the
hypercall HVCALL_FLUSH_VIRTUAL_ADDRESS_LIST_EX and corresponding protocol. Once we reach the agreement, it could be changed on both Linux and FreeBSD guest.

May 14 2024, 11:59 AM

May 13 2024

schakrabarti_microsoft.com updated the diff for D45174: TLB flush enlightment using Hyper-V hypercall.

Updated vmbus_var.h to remove the unused variable.

May 13 2024, 10:23 AM
schakrabarti_microsoft.com added reviewers for D45174: TLB flush enlightment using Hyper-V hypercall: whu, imp.
May 13 2024, 10:14 AM
schakrabarti_microsoft.com requested review of D45174: TLB flush enlightment using Hyper-V hypercall.
May 13 2024, 10:13 AM

May 6 2024

schakrabarti_microsoft.com added inline comments to D39150: hyperv: Fix compilation with larger page sizes.
May 6 2024, 6:57 AM

Jan 24 2024

schakrabarti_microsoft.com added a comment to D43431: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources.

Code looks fine to me, but has the new functions been tested on Azure ? As in local Hyper-V we mostly dont use pci passthrough.

Jan 24 2024, 7:00 AM

Jan 18 2024

schakrabarti_microsoft.com added inline comments to D43431: hyperv vmbus_pcib: Use pci_domain_*_bus for PCI_RES_BUS resources.
Jan 18 2024, 3:36 AM

Jan 16 2024

schakrabarti_microsoft.com added a comment to D39395: Hyper-V framebuffer driver.

Has this change been tested?

Of course, I used it as I was working on it :)

I didn't add anyone to reviewers though just yet as I am still thinking about the options here:

  1. have this in base for a (bit better) resolution with console and scfb
  2. have this entirely in drm-kmod (that will be completely separate change) for things like wayland compositors to work
  3. have this in base and provide interfaces for drm module to re-use
Jan 16 2024, 3:45 PM

Nov 1 2023

schakrabarti_microsoft.com added inline comments to D42414: Hyper-V: vmbus: Add NULL check for vmbus_res.
Nov 1 2023, 9:52 PM

Oct 18 2023

schakrabarti_microsoft.com accepted D42271: Add Azure 2023Q3 status report.
Oct 18 2023, 9:32 AM
schakrabarti_microsoft.com added inline comments to D42271: Add Azure 2023Q3 status report.
Oct 18 2023, 4:56 AM

Sep 14 2023

schakrabarti_microsoft.com updated the summary of D41728: vmbus bus_get_dma_tag implementation for arm64.
Sep 14 2023, 3:35 AM

Sep 12 2023

schakrabarti_microsoft.com updated the diff for D41728: vmbus bus_get_dma_tag implementation for arm64.
  • Changed the function vmbus_get_dma_tag to create the tag inside.
Sep 12 2023, 11:24 AM
schakrabarti_microsoft.com updated the diff for D41728: vmbus bus_get_dma_tag implementation for arm64.
  • Changed the function vmbus_get_dma_tag to create the tag inside.
Sep 12 2023, 6:24 AM

Sep 11 2023

schakrabarti_microsoft.com added inline comments to D41728: vmbus bus_get_dma_tag implementation for arm64.
Sep 11 2023, 12:09 PM
schakrabarti_microsoft.com added inline comments to D41728: vmbus bus_get_dma_tag implementation for arm64.
Sep 11 2023, 10:37 AM
schakrabarti_microsoft.com added inline comments to D41728: vmbus bus_get_dma_tag implementation for arm64.
Sep 11 2023, 9:04 AM

Sep 7 2023

schakrabarti_microsoft.com added a comment to D41728: vmbus bus_get_dma_tag implementation for arm64.
Sep 7 2023, 9:16 AM
schakrabarti_microsoft.com updated the diff for D41728: vmbus bus_get_dma_tag implementation for arm64.

Updating the diff with arc

Sep 7 2023, 9:15 AM

Sep 5 2023

schakrabarti_microsoft.com requested review of D41728: vmbus bus_get_dma_tag implementation for arm64.
Sep 5 2023, 10:33 AM

Jul 21 2023

schakrabarti_microsoft.com accepted D41126: Add Azure 2023Q2 status report.
Jul 21 2023, 10:28 AM

Jun 22 2023

schakrabarti_microsoft.com accepted D40660: hyperv/kvp: Remove set but unused variables..
Jun 22 2023, 6:39 PM

Jun 1 2023

schakrabarti_microsoft.com accepted D40227: Switch to contigmalloc in the Hyper-V code.
Jun 1 2023, 10:28 AM
schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

I have tested in arm64 and x86 and looks good to me.

Jun 1 2023, 9:31 AM

May 30 2023

schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

If possible please get the change thoroughly tested in Azure x86 platform or Hyper-V x86.

May 30 2023, 9:09 PM

May 29 2023

schakrabarti_microsoft.com updated the diff for D40279: enabling Hyper-V SMP for ARM64.
May 29 2023, 8:47 AM

May 26 2023

schakrabarti_microsoft.com requested review of D40279: enabling Hyper-V SMP for ARM64.
May 26 2023, 9:17 AM

May 25 2023

schakrabarti_microsoft.com added a comment to D40263: gicv3: Use an offset to find the redist registers.

Tested on Hyper-V on ARM64 and it is working. The panic from gic redistributor is not coming.

May 25 2023, 4:06 PM
schakrabarti_microsoft.com awarded D40263: gicv3: Use an offset to find the redist registers a Like token.
May 25 2023, 1:48 PM

May 24 2023

schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

If possible please get the change thoroughly tested in Azure x86 platform or Hyper-V x86.

May 24 2023, 6:32 AM

May 23 2023

schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

I will try to test the patch on Azure x86 gen1 and gen2 and arm64.
I guess by this weekend I can complete it.

May 23 2023, 11:51 AM
schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

hyperv_dmamem_free() is removed, but hyperv_dmamem_alloc() stays, so what about the memory allocated by hyperv_dmamem_alloc()? How they will be freed?
Also it is not very consistent.
We need to do a thorough testing on Azure amd64 gen1 gen2 and arm64 with this patch.
Have you tested the change on Hyper-V x86 and arm64?

May 23 2023, 11:49 AM
schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

hyperv_dmamem_alloc is used in amd64 code. I wasn't planning on touching that as I am unable to easily test the change.

May 23 2023, 11:24 AM
schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.

Also if hyperv_dmamem_alloc() and hyperv_dmamem_free() is not in use, please remove them from vmbus. As they are dead code.

May 23 2023, 11:10 AM
schakrabarti_microsoft.com added inline comments to D40227: Switch to contigmalloc in the Hyper-V code.
May 23 2023, 9:38 AM
schakrabarti_microsoft.com added inline comments to D40227: Switch to contigmalloc in the Hyper-V code.
May 23 2023, 9:36 AM
schakrabarti_microsoft.com added a comment to D40227: Switch to contigmalloc in the Hyper-V code.
May 23 2023, 9:18 AM
schakrabarti_microsoft.com added a comment to rG172af24449cd: arm64: gicv3: setup PPIs on all APs after they're online.
May 23 2023, 9:18 AM

Apr 11 2023

schakrabarti_microsoft.com added a comment to D39395: Hyper-V framebuffer driver.

Has this change been tested?

Apr 11 2023, 7:08 AM
schakrabarti_microsoft.com added inline comments to D39150: hyperv: Fix compilation with larger page sizes.
Apr 11 2023, 2:47 AM

Feb 12 2023

schakrabarti_microsoft.com requested review of D38529: missed conf files attributes for Hyper-V vpci driver.
Feb 12 2023, 8:14 AM

Feb 2 2023

schakrabarti_microsoft.com added a comment to D36052: Enabling FreeBSD on ARM64 Hyper-V.

@tsoome Can you please share the patch, would like to test it on Hyper-V arm64 and x86. Thanks.

Feb 2 2023, 5:43 AM

Feb 1 2023

schakrabarti_microsoft.com added inline comments to D37958: Enabling v-PCI in FreeBSD in ARM64 Hyper-V second patch.
Feb 1 2023, 4:24 PM

Jan 31 2023

schakrabarti_microsoft.com added inline comments to D37763: SPI MSI mapping for gic v3 acpi in arm64.
Jan 31 2023, 3:44 AM

Jan 24 2023

schakrabarti_microsoft.com added inline comments to D36052: Enabling FreeBSD on ARM64 Hyper-V.
Jan 24 2023, 10:13 AM

Jan 9 2023

schakrabarti_microsoft.com added a comment to D37763: SPI MSI mapping for gic v3 acpi in arm64.
In D37763#862942, @imp wrote:

Are there times other than when running as a hyperv guest that these might be needed?

Jan 9 2023, 7:11 AM

Jan 5 2023

schakrabarti_microsoft.com requested review of D37958: Enabling v-PCI in FreeBSD in ARM64 Hyper-V second patch.
Jan 5 2023, 5:28 PM
schakrabarti_microsoft.com updated the diff for D37780: Enabling v-PCI in FreeBSD in ARM64 Hyper-V.
Jan 5 2023, 5:09 PM

Dec 22 2022

schakrabarti_microsoft.com updated the diff for D37763: SPI MSI mapping for gic v3 acpi in arm64.
Dec 22 2022, 8:30 PM
schakrabarti_microsoft.com requested review of D37780: Enabling v-PCI in FreeBSD in ARM64 Hyper-V.
Dec 22 2022, 11:45 AM

Dec 20 2022

schakrabarti_microsoft.com updated the diff for D37763: SPI MSI mapping for gic v3 acpi in arm64.
Dec 20 2022, 10:30 PM
schakrabarti_microsoft.com requested review of D37763: SPI MSI mapping for gic v3 acpi in arm64.
Dec 20 2022, 8:55 PM

Dec 16 2022

schakrabarti_microsoft.com added a comment to D36052: Enabling FreeBSD on ARM64 Hyper-V.

small nits still, but good otherwise, I assume, this code does work as expected now?

Dec 16 2022, 9:15 AM
schakrabarti_microsoft.com updated the diff for D36052: Enabling FreeBSD on ARM64 Hyper-V.
Dec 16 2022, 9:13 AM
schakrabarti_microsoft.com added a comment to D36052: Enabling FreeBSD on ARM64 Hyper-V.

Setting other values than default values cause hang during comc_setup. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266248

It seems, you got some extra files included?

Dec 16 2022, 5:52 AM
schakrabarti_microsoft.com updated the diff for D36052: Enabling FreeBSD on ARM64 Hyper-V.
Dec 16 2022, 5:50 AM

Dec 15 2022

schakrabarti_microsoft.com updated the summary of D36052: Enabling FreeBSD on ARM64 Hyper-V.
Dec 15 2022, 7:48 PM
schakrabarti_microsoft.com added a reviewer for D36052: Enabling FreeBSD on ARM64 Hyper-V: tsoome.
Dec 15 2022, 7:47 PM
schakrabarti_microsoft.com updated the diff for D36052: Enabling FreeBSD on ARM64 Hyper-V.

Setting other values than default values cause hang during comc_setup. https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=266248

Dec 15 2022, 7:46 PM

Oct 31 2022

schakrabarti_microsoft.com requested review of D37222: FreeBSD enablement for ARM64 in Hyper-V: making INTR MP Safe.
Oct 31 2022, 11:51 AM
schakrabarti_microsoft.com updated the diff for D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 31 2022, 11:48 AM
schakrabarti_microsoft.com updated the diff for D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 31 2022, 7:25 AM
schakrabarti_microsoft.com updated the diff for D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 31 2022, 7:12 AM
schakrabarti_microsoft.com updated the diff for D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 31 2022, 7:07 AM

Oct 30 2022

schakrabarti_microsoft.com updated the diff for D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 30 2022, 9:40 PM
schakrabarti_microsoft.com requested review of D37219: FreeBSD enablement for ARM64 in Hyper-V: fixing hung issue during Hyper-V initialization.
Oct 30 2022, 9:36 PM

Oct 29 2022

schakrabarti_microsoft.com added a comment to D36466: FreeBSD enablement for ARM64 in Hyper-V.

Will put the

Oct 29 2022, 6:25 AM
schakrabarti_microsoft.com added inline comments to D36466: FreeBSD enablement for ARM64 in Hyper-V.
Oct 29 2022, 6:23 AM

Oct 24 2022

schakrabarti_microsoft.com updated the diff for D36744: FreeBSD enablement for ARM64 in Hyper-V.
Oct 24 2022, 11:07 AM
schakrabarti_microsoft.com requested review of D37103: FreeBSD enablement for ARM64 in Hyper-V.
Oct 24 2022, 10:57 AM

Oct 20 2022

schakrabarti_microsoft.com updated the diff for D37064: FreeBSD enablement for ARM64 in Hyper-V.
Oct 20 2022, 6:33 AM
schakrabarti_microsoft.com requested review of D37064: FreeBSD enablement for ARM64 in Hyper-V.
Oct 20 2022, 6:31 AM

Oct 10 2022

schakrabarti_microsoft.com added a comment to D36467: FreeBSD enablement for ARM64 in Hyper-V.

It seems that some of the content of these comes from sys/dev/hyperv/vmbus/vmbus.c and other files under vmbus/. Are there corresponding changes to those?

Oct 10 2022, 5:59 AM

Sep 29 2022

schakrabarti_microsoft.com updated the diff for D36744: FreeBSD enablement for ARM64 in Hyper-V.
Sep 29 2022, 12:42 PM

Sep 27 2022

schakrabarti_microsoft.com updated the diff for D36744: FreeBSD enablement for ARM64 in Hyper-V.
Sep 27 2022, 12:39 PM
schakrabarti_microsoft.com added a reviewer for D36744: FreeBSD enablement for ARM64 in Hyper-V: whu.
Sep 27 2022, 12:22 PM
schakrabarti_microsoft.com requested review of D36744: FreeBSD enablement for ARM64 in Hyper-V.
Sep 27 2022, 12:21 PM
schakrabarti_microsoft.com updated the diff for D36467: FreeBSD enablement for ARM64 in Hyper-V.

These are the changes for x86 (for both 32 and 64bit).

Sep 27 2022, 11:56 AM