Page MenuHomeFreeBSD

libdiff: Add a test for the truncation issue.
ClosedPublic

Authored by des on May 16 2024, 12:26 PM.
Tags
None
Referenced Files
F103163634: D45218.diff
Thu, Nov 21, 6:52 PM
F103110784: D45218.id138779.diff
Thu, Nov 21, 3:39 AM
Unknown Object (File)
Tue, Nov 19, 10:06 PM
Unknown Object (File)
Tue, Nov 19, 5:36 PM
Unknown Object (File)
Tue, Nov 19, 10:14 AM
Unknown Object (File)
Sat, Nov 16, 6:13 AM
Unknown Object (File)
Thu, Nov 7, 7:33 AM
Unknown Object (File)
Wed, Nov 6, 11:50 AM
Subscribers

Details

Summary

Sponsored by: Klara, Inc.

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

des requested review of this revision.May 16 2024, 12:26 PM
This revision is now accepted and ready to land.May 16 2024, 1:40 PM
markj added inline comments.
lib/libdiff/tests/libdiff_test.c
36

You might consider using some multiple of the system page size instead. For instance, on arm64 it's possible to configure a base page size of 64KB, in which case this test is going to truncate within a page and so won't trigger SIGBUS.

55

In general you don't need to clean up files in the current directory, kyua or whatever other test runner should handle that for you I believe.

This revision was automatically updated to reflect the committed changes.