In D19992#429687, @bcran wrote:In D19992#429679, @imp wrote:I've also started to create a 'fallback loader' path to try to hash out a good design. I'm thinking that a good design might be to have loader.efi read in \efi\freebsd\loader.env and parse it like the command line with foo=bar variables. This would let us say uefi_rootdev=HD(3,GPT,0f91d7c6-2de5-11e8-b5f1-3cfdfe9d5250,0x619430,0x600000) and have that become / for the new system. The only downside to this is that we have to encode the size and offset of the partition into the device path which doesn't play well with the auto resize code, though we could hack that to update this env :)
I don't understand how loader.env fits into the idea of a fallback loader, but it's perhaps better to wait for your design document.
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Apr 22 2019
Apr 22 2019
Apr 21 2019
Apr 21 2019
Apr 20 2019
Apr 20 2019
I like this, but command line switches are too easy to quibble over, so I'll just have my say and let you decide.
In D19962#429625, @sjg wrote:Would it be worth adding a means of explicitly marking a file in manifest as not to be verified?
Start to reduce the number of #ifdef EFI_ZFS_BOOT
(sorry, last comment was stale)
Apr 19 2019
Apr 19 2019
one minor style nit and we're good to go.
Add wrapper functions to convert strings to EFI_DEVICE_PATH
Add UEFI definitions related to converting string to DEVICE_PATH
Apr 18 2019
Apr 18 2019
When parsing command line stuff, treat tabs and spaces the same.
Add note that I'm the defacto maintainer of libegacy, our
Add a more generic efi_setenv function.
This looks good, and we can make good use of this in our automation. It's adequate for netflix to decide what to do at boot when the aberrant conditions happen, as well as accommodating our diverse deployment model which is currently biased towards servers, but may not always be.
Apr 17 2019
Apr 17 2019
Other than fixing the misleading comments, I understand why we're doing this, and it looks good.
The sysctl returns non-nonsense now. Is this even needed?
imp requested changes to D19928: random(4): More thoroughly attempt to ensure seeding during priming.
I like that we can have a fallback seeding to RND devices, but Netflix requires a system to be bootable to userland no matter what goes on with the randomness in early boot. As such, we'd like a mode that can report that something screwed up in the early random stuff so we can decide if we care or not about that. And then take appropriate action based on our level of caring and concern. We have boxes all over the world and a hung boot would mean an RMA which is quite costly. We'd rather the system come up at least enough to report broken randomness to our backplane, or to take remediation steps when, for example, our entropy file is corrupted on a crash by recreating it and rebooting.
Apr 16 2019
Apr 16 2019
this is a reasonable stopgap, approved with the understanding that there will be follow on work to allow MD sources of entropy, like RDSEED on x86 etc
Apr 14 2019
Apr 14 2019
Looks good to me.
There's only one issue that I see with this commit, and that's OUI namespace management. It's likely not a huge deal, but I think it's an easy thing to get right. emaste@ or kevans@ have the context / information to get the allocation from the foundation that I think we need. It's a minor tweak to the code to o things that way.
Apr 13 2019
Apr 13 2019
Move mpr/mps drivers from per-arch NOTES files into the MI notes
Apr 12 2019
Apr 12 2019
Looks like Andy's suggestions were followed... I was going to make similar when I last looked at it as well.
This change looks correct to me. Unsure why we need to do it though. Would like to see the follow-on fixes that this depends on, since I'm pretty happy with this if there's some reason to change.
This looks OK to me, but my knowledge of what bhyve does to emulate PCI is weak.
Apr 11 2019
Apr 11 2019
Apr 10 2019
Apr 10 2019
So this looks good to me. Having at least mips64 covered, even if other things are unknown is a win. one question about r_mips_32 to think about.
Apr 9 2019
Apr 9 2019
Couple of minor style nits, but the code looks good to my brain.
This looks good to me, however I'd wait a few days to see if Scott can spot something that I can't.
Apr 8 2019
Apr 8 2019
OK. this looks good, and you are using the flag I was complaining about not being used , so ignore that bit.
This is conditional on D19779.
and I'm ENOCLUE on the hardware, but it looks like it might be right.
imp added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
imp added inline comments to D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
imp retitled D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly from Move function definitions to after the VARS_ONLY exit to Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
imp updated the diff for D19849: Reorg newvers.sh to eliminate VARS_ONLY and do things more directly.
Finish the transition
Style only change: Prefer $() to ``
Apr 7 2019
Apr 7 2019
Make RELDATE be on a single line.
Use default shell assignment rather more complicated if then
Apr 5 2019
Apr 5 2019
In D19695#425335, @chuck wrote:In D19695#423813, @imp wrote:This looks good to me. It's the right thing to do.
Do we need to expand it more generally (in a different commit) for any time we have to copy data out, or is the I/O path good?The IO path appears to be OK, but I only took brief look. That said, I've run a fair amount of IO against and haven't seen any issues in practice. Where as this issue was easily reproducible.
Remove another instance of All Rights Reserved.
imp updated the diff for D19797: Use default shell assignment rather more complicated if then construct..
Fix line length, per ed.
imp added a comment to D19816: Add an option for specifying the default debug flags for mps driver..
I debated tossing this into sys/conf/NOTES, but didn't want to play whack-a-mole with the architectures that I'd opt out of... Comments?
imp updated the diff for D19816: Add an option for specifying the default debug flags for mps driver..
mps debug flags in NOTES, as appropriate.
imp added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
I'm trying to recall that. I know that the different types of subdevices don't change what's probed (as there are catch-all entries). I had a specific reason, but I can't recall it now.
imp added a comment to D19827: aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string.
I specifically allowed those duplicates when I was originally reviewing this change....
imp added a comment to D19816: Add an option for specifying the default debug flags for mps driver..
In D19816#425165, @cem wrote:Why not just cut straight to a tunable instead and save a compile?
Add mpr, mps, mpt to NOTES file
Apr 4 2019
Apr 4 2019
imp added a comment to D19816: Add an option for specifying the default debug flags for mps driver..
If this looks good, I'll do the identical changes to mpr as well.
imp updated the test plan for D19816: Add an option for specifying the default debug flags for mps driver..
Apr 3 2019
Apr 3 2019
Looks great, apart from the stupid date nits :). And even if those weren't fixed, it wouldn't be too bad.
imp requested changes to D19706: Allow Kernel to link in both legacy libkern/zlib and new sys/contrib/zlib..
Apr 2 2019
Apr 2 2019
imp added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
imp added inline comments to D19797: Use default shell assignment rather more complicated if then construct..
Apr 1 2019
Apr 1 2019
imp added inline comments to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
imp added a comment to D19779: Add new fields to mmc_data in preparation to SDIO CMD53 block mode support.
In D19779#424228, @kibab wrote:In D19779#424220, @bz wrote:This is missing files I think. The mmcreg.h structure changes are missing from this one. This won't compile.
Sorry, something has gone wrong with my tree. I will reupload.
So slm is Steve McConnell who has been the long-time driver maintainer inside of LSI/et-al. His day job has transitioned to firmware, but is active on phab.
Achim is from Adaptec / Microsemi and left Adaptec in 2016.
Scott is going to contact both of them as a courtesy to these vendors.
Apart from slm and achim, I'm good. Let's put those two in the not yet box.
Update after latest cleanups.
I'd be happier if we copied usbdevs.awk to sdiodevs.awk.
I'll take a closer look next week when I'm back in the office.
In D19507#423939, @greg_unrelenting.technology wrote:In D19507#423825, @imp wrote:IIRC, this violates the ACPI definition for these fields.
Where are they defined? https://docs.microsoft.com/en-us/windows-hardware/drivers/serports/serial-port-console-redirection-table — Ctrl+F "width" — 0 results. (Thanks Microsoft.)
Mar 31 2019
Mar 31 2019
In D19507#423770, @greg_unrelenting.technology wrote:Dammit. The Ampere eMAG (which uses the pl011 SBSR UART) represents *shiftp = 2; as
[029h 0041 1] Bit Width : 20 [02Ah 0042 1] Bit Offset : 00 [02Bh 0043 1] Encoded Access Width : 01 [Byte Access:8]
imp added inline comments to D19019: zfs stand: plumb primary vdev out through zfs_probe_dev as needed.