Rather than requiring someone hack mps.c to set these, make them a
Why not just cut straight to a tunable instead and save a compile?
ScottL will want a matching change to dev/mpr (if appropriate) to keep them in sync.
Edit: oops, got our lines crossed. I see you plan to do so:
Sometimes the deployment is just easier to compile it in. There's a default with /*XXX */ (which I need to change) which suggests that its useful. This has been the debugging default for a long, long time, though...
Eh, I'm not a big fan of this, converting the driver to use strings from sysctl and kenv was intended to make it as easy as possible to set and unset flags from the default. It also adds new touch points in the system that will have to be updated or risk going stale if debugging evolves. Is editing, compiling, and deploying a new kernel easier than editing loader.conf? That said, I don't have a hard objection to it being committed, so long as the first time it goes stale, Warner buys me a nice chopped brisket dinner at Shorty's.