Page MenuHomeFreeBSD

Ensure kernel.bootfile is a real file
Needs ReviewPublic

Authored by aryeeteygerald_rogers.com on Jan 23 2019, 9:06 PM.

Details

Reviewers
emaste
imp
Summary

Also handle cases where non-default bootloaders are being used
which causes kernel.bootfile to be "/kernel". In those cases, assume
the default bootfile location.

Test Plan

None

Diff Detail

Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 23717
Build 22680: arc lint + arc unit

Event Timeline

rS345550 changed the default value of kern.bootfile to /boot/kernel/kernel. You may need to adjust this patch slightly to compensate for that.

imp requested changes to this revision.Apr 17 2019, 5:57 PM
imp added a subscriber: imp.

The sysctl returns non-nonsense now. Is this even needed?

usr.sbin/freebsd-update/freebsd-update.sh
693–698

no it's not. We fixed that recently. :)

841–846

again, this is not correct anymore.

This revision now requires changes to proceed.Apr 17 2019, 5:57 PM

Other than fixing the misleading comments, I understand why we're doing this, and it looks good.

usr.sbin/freebsd-update/freebsd-update.sh
693–698

In -current this is now correct, so the comment should be updated to reflect that we're doing this for old kernels that don't have the fix yet.

This revision is now accepted and ready to land.Apr 17 2019, 5:59 PM
This revision now requires review to proceed.Apr 17 2019, 7:22 PM

Remove diff junk ...

  • Ensure kernel.bootfile is really a file
  • Update comments to reflect rS345550