Page MenuHomeFreeBSD

aac(4): Add subvendor / subdevice to MODULE_PNP_INFO()'s descriptor_string
Needs ReviewPublic

Authored by rpokala on Apr 5 2019, 4:50 AM.

Details

Reviewers
imp
Summary

I noticed that devmatch reported many apparently duplicated entries
in the list for aac.ko. This is because the driver's probe() actually
matches on the full (vendor, device, subvendor, subdevice) tuple, but
only (vendor, device) were passed to MODULE_PNP_INFO(). With updated
string, there are no more purported duplicates.

Test Plan

Run devmatch -ud with and without the change, and compare.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 23526
Build 22530: arc lint + arc unit

Event Timeline

rpokala created this revision.Apr 5 2019, 4:50 AM
imp added a comment.Apr 5 2019, 5:20 AM

I specifically allowed those duplicates when I was originally reviewing this change....

In D19827#425235, @imp wrote:

I specifically allowed those duplicates when I was originally reviewing this change....

Interesting. Why? If the reasons still stand, then I'll change this to just add a comment instead.

imp added a comment.EditedApr 5 2019, 5:35 AM

I'm trying to recall that. I know that the different types of subdevices don't change what's probed (as there are catch-all entries). I had a specific reason, but I can't recall it now.

I'll check my notes in the morning.