I noticed that devmatch reported many apparently duplicated entries
in the list for aac.ko. This is because the driver's probe() actually
matches on the full (vendor, device, subvendor, subdevice) tuple, but
only (vendor, device) were passed to MODULE_PNP_INFO(). With updated
string, there are no more purported duplicates.
Details
Details
- Reviewers
imp
Run devmatch -ud with and without the change, and compare.
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 23526 Build 22530: arc lint + arc unit
Event Timeline
Comment Actions
I specifically allowed those duplicates when I was originally reviewing this change....
Comment Actions
Interesting. Why? If the reasons still stand, then I'll change this to just add a comment instead.
Comment Actions
I'm trying to recall that. I know that the different types of subdevices don't change what's probed (as there are catch-all entries). I had a specific reason, but I can't recall it now.
I'll check my notes in the morning.