Differential D19979

Use symlinks for kernel modules rather than hardlinks
ClosedPublic
Actions

Authored by asomers on Apr 20 2019, 2:10 AM.

Details

Reviewers

• ian
imp

Commits

rS346441: Use symlinks for kernel modules rather than hardlinks

Summary

Use symlinks for kernel modules rather than hardlinks

When aliasing a kernel module to a different name (ie if_igb for if_em),
it's better to use symlinks than hard links. kldxref will omit entries for
the links, ensuring that the loaded module has the correct name.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

asomers created this revision.Apr 20 2019, 2:10 AM

Herald added a subscriber: imp. · View Herald TranscriptApr 20 2019, 2:10 AM

Harbormaster completed remote builds in B23780: Diff 56414.Apr 20 2019, 2:10 AM

imp added inline comments.Apr 20 2019, 2:37 AM

sys/modules/em/Makefile
25 ↗	(On Diff #56414)	Why specify directories here. Elsewhere in the tree we just do the moral equivalent of ${KMOD},ko ${KMODDIR}/if_igb.ko I think the original LINKS were wrong :) My suggestion would allow mv /boot/kernel /boot/kernel.old and have the symlinks still be good. It didn't matter with hard links. Here and below.