In D43746#998246, @andrew wrote:In D43746#997823, @pldrouin_gmail.com wrote:Note: lx2160a_i2c_fdt should not be loaded along with vf_i2c, as they share the same FDT ID. What is the best way to handle this?
Can you merge the two drivers?
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed Advanced Search
Advanced Search
Advanced Search
Feb 6 2024
Feb 6 2024
Fixing /sys/arm64/conf/std.nxp and sys/conf/files.arm64
In D43746#997823, @pldrouin_gmail.com wrote:Note: lx2160a_i2c_fdt should not be loaded along with vf_i2c, as they share the same FDT ID. What is the best way to handle this?
Last diff is broken. Will investigate...
Adding devices to sys/arm64/conf/std.nxp . The driver should work for LX2160A, LX2120A, LX2080A, LS1046A and LS1026A based on their respective reference manuals. The ACPI driver could be included in GENERIC. However as previously mentioned, I think including the FDT version along with vf_i2c could be problematic due to them sharing the same ID, so I commented out the lx2160a_i2c_fdt device.
In D43746#998187, @pldrouin_gmail.com wrote:Revised version with all requested changes
Fixing a few typos in debug print statements. Adding also one debug print statement.
Revised version with all requested changes
Just basic style(9) review.
Also you should add the devices in sys/arm64/conf/std.nxp
I think this is now ready for review.
Feb 5 2024
Feb 5 2024
modules/Makefile: Moving _lx2160a_i2c_fdt inside the nested condition on OPT_FDT
modules/Makefile: The modules are now only enabled for arm64/aarch64
Removing the verification of IBSR_IBB in i2c_stop. It was most likely potentially problematic and should have not been used.
Adding blank line to copyright notice
The templates shown at https://www.freebsd.org/internal/software-license/ have a (nearly) blank line after the Copyright . . . line:
* Copyright (c) [year] [your name] * * Redistribution and use in source and binary forms, with or without
In general it is a good place to look at for comparisons.
Updating the copyright notice as recommended.
Avoid use of "All rights reserved." in copyright notices? https://www.freebsd.org/internal/software-license/ reports:
With the ratification of the Berne Convention in 2000, it became obsolete. As such, the FreeBSD project recommends that new code omit the phrase and encourages existing copyright holders to remove it. In 2018, the project updated its templates to remove it.
-The logic in wait_for_icf was not quite right. It is now fixed.
Removing unnecessary small delay in i2c_stop. It had been introduced earlier as an attempt to fix the issue which was resolved by using wait_for_nibb in i2c_start.
Removing an unused define in lx2160a_i2c.h
pldrouin_gmail.com updated the test plan for D43746: Adding Support for QorIQ LX2160A I2C Controller.
pldrouin_gmail.com updated the test plan for D43746: Adding Support for QorIQ LX2160A I2C Controller.
-Moved the source files to sys/dev/iicbus/controller/qoriq
-Removed lx2160a_common.h
-Renamed the driver modules to separate names
-Now using wait_for_nibb in i2c_start so it works reliably after a reset
-Added the drivers to files.arm64
-Updated the copyright notice, and added credits.
Thanks, I will make these changes. I also have to tweak some delay that should apply when a start follows a reset.
We have a new-ish directory sys/dev/iicbus/controller/ for i2c controllers, it should go there.
Ok I have found a few things to change. It looks like some extra delays might be required when the module is not run in DEBUG mode.
I currently have it configured as a pair of modules. One weird thing I noticed is that I could kldload and kldunload them just fine when I was building the modules manually and before I included them in sys/modules/Makefile and I rebuilt the kernel. After adding them to sys/modules/Makefile, rebuilding and installing the kernel, I can only load them through /boot/loader.conf, otherwise it complains the modules are already loaded in the kernel, although kldstat -v and grep -R lx2160a_i2c /boot/kernel say otherwise. How can this be fixed? Thanks
pldrouin_gmail.com updated the test plan for D43746: Adding Support for QorIQ LX2160A I2C Controller.
pldrouin_gmail.com updated the test plan for D43746: Adding Support for QorIQ LX2160A I2C Controller.
Feb 4 2024
Feb 4 2024
pldrouin_gmail.com added a comment to D24917: Add ACPI attachment for the Vybrid VF610 I2C controller.
I wrote a FDT/ACPI split driver for the LX2160A I2C controller based on the work started by Val, and the LX2160A I2C controller documentation. It deviates significantly from the Vybrid driver as the way the original driver was handling the controller's registers was not quite compatible with the LX2160A I2C controller. Should I start a new diff with my driver and link to it from here? It seems to work well so far based on the (limited) tests I made. I can scan the bus and get the correct output. I am able to query the MUX's register and the fan controller's ID.
Jan 20 2024
Jan 20 2024
fred_thegalacticzoo.com added a comment to D43399: VCHIQ HDMI AUDIO 64 bits BCM2835, BCM2711 Raspberry Pi 4B; correct minor compile errors. bcm2835_audio.c.
In D43399#991801, @bses30074_gmail.com wrote:
Happy to have your testing and participation in getting Marcos VCHIQ HDMI audio sound patch reviewed. I post many URL links below to share ideas for further reading and learning.. YES, this is first a FreeBSD code review and not related to other BSD and URL links. So the point is to specifically comment about using FreeBSD source code. Sorry for the overload, but I wanted a good post to answer your question and share links for the background information.
Jan 18 2024
Jan 18 2024
bses30074_gmail.com added a comment to D43399: VCHIQ HDMI AUDIO 64 bits BCM2835, BCM2711 Raspberry Pi 4B; correct minor compile errors. bcm2835_audio.c.
Is this patch based on the three preceding patches? Were there compilation warnings (or errors) encountered when applying those three patches, leading to the creation of this patch to address those issues?
markmi_dsl-only.net added a comment to D24917: Add ACPI attachment for the Vybrid VF610 I2C controller.
In D24917#550057, @val_packett.cool wrote:Looks like this needs to wait until there's some way to get the clock without devicetree (I guess Linux runs with fdt+acpi both to make it work..)
Jan 17 2024
Jan 17 2024
Herald added a reviewer for D24917: Add ACPI attachment for the Vybrid VF610 I2C controller: andrew.
Jan 13 2024
Jan 13 2024
fred_thegalacticzoo.com updated the diff for D43399: VCHIQ HDMI AUDIO 64 bits BCM2835, BCM2711 Raspberry Pi 4B; correct minor compile errors. bcm2835_audio.c.
Concatenated 7 git diff -u patch files into one_large_vchiq_freebsd_patch_file.patch and updated this diff. I see that the FreeBSD (src) does not yet contain Marcos Devesas Campos VCHIQ revision D378378 https://reviews.freebsd.org/D37878. So make a decision to use or not use that code before incorporating this D43399 revision.
Jan 11 2024
Jan 11 2024
fred_thegalacticzoo.com added a comment to D43399: VCHIQ HDMI AUDIO 64 bits BCM2835, BCM2711 Raspberry Pi 4B; correct minor compile errors. bcm2835_audio.c.
I do not know how to add the 5 other patch files to be included in this diff comparision. Seems like 132598, got over written with this "update diff" instead of being added. Time for me to read and study hand book. okay
fred_thegalacticzoo.com updated the diff for D43399: VCHIQ HDMI AUDIO 64 bits BCM2835, BCM2711 Raspberry Pi 4B; correct minor compile errors. bcm2835_audio.c.
add file vchiq_2835_arm_.c.patch to diff section
Jan 4 2024
Jan 4 2024
oskar.holmlund_ohdata.se requested review of D43321: am335x: ti_adc add possibility to invert x coordinate.
Jan 2 2024
Jan 2 2024
oskar.holmlund_ohdata.se added inline comments to D43283: AM335x: Add PWM(9) api to am335x_ecap driver.
oskar.holmlund_ohdata.se added a reviewer for D43280: am335x: am335x_lcd remove backlight code: karels.
Dec 26 2023
Dec 26 2023
Dec 25 2023
Dec 25 2023
Dec 11 2023
Dec 11 2023
Dec 8 2023
Dec 8 2023
https://reviews.freebsd.org/D42969 and the rest of the patch series are available for review. They break up this patch into logical commits, plus ensure that we do not erroneously consume an exception if a kernel thread triggers a VFP exception without having entered an FPU section. This lets fpu_kern_enter() work on ARM when a FPU context is supplied by the caller.
Nov 30 2023
Nov 30 2023
oskar.holmlund_ohdata.se added reviewers for D27889: TI SoC rework clk support: karels, to.karlzon_gmail.com.
Fix up this review to work with DTS import from Linux 6.4
Nov 9 2023
Nov 9 2023
Nov 8 2023
Nov 8 2023
Nov 7 2023
Nov 7 2023
karels added inline comments to D42471: cpufreq_dt: Add interface to support other parse functions for the operating-points table.
Nov 5 2023
Nov 5 2023
In D42415#969126, @arichardson wrote:I see you have a reduced test case, would it be possible to turn it into a regression test for in the ld-elf tests?
arichardson added a comment to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
I see you have a reduced test case, would it be possible to turn it into a regression test for in the ld-elf tests?
Nov 3 2023
Nov 3 2023
Nov 2 2023
Nov 2 2023
rcm updated the diff for D42445: libc: enable initial-exec (IE) as default thread-local storage model on arm.
remove the entire if statement
imp added inline comments to D42445: libc: enable initial-exec (IE) as default thread-local storage model on arm.
rcm requested review of D42445: libc: enable initial-exec (IE) as default thread-local storage model on arm.
Thanks for suggestions.
collapse tmp = *where + tmp -> tmp += *where
kib added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Nov 1 2023
Nov 1 2023
rcm retitled D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation from rtld/arm: fix thread-local storage relocation to rtld/arm: fix initial-exec (IE) thread-local storage relocation.
In D42415#968208, @jrtc27 wrote:If IE is fixed then lib/libc/Makefile probably should enable it on arm as a follow-up, which I *think* is the only architecture not covered by that if statement, unless I'm missing something
Ensure we update tmp for dbg output
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
jrtc27 added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
I have now reduced the diff down to the minimum. Thanks all for your continued comments.
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
If IE is fixed then lib/libc/Makefile probably should enable it on arm as a follow-up, which I *think* is the only architecture not covered by that if statement, unless I'm missing something
jrtc27 added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
I studied what NetBSD is doing here. Here is an updated test program:
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
rcm added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
andrew added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
kib added a reviewer for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation: jrtc27.
kib added inline comments to D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation.
Oct 31 2023
Oct 31 2023
kp added a reviewer for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation: kib.
rcm added a reviewer for D42415: rtld/arm: fix initial-exec (IE) thread-local storage relocation: brd.
Oct 18 2023
Oct 18 2023
Oct 11 2023
Oct 11 2023
- Replaced the DEFINE_CLASS_0 -> struct driver_t
- removed pinctrl_single_pins_write / read
- update pinctrl_single_syscon_unlocked_write_4/read_4 to honor pinctrl-single,register-width. (even if the functionnames will be misleading and give the impression its an 4byte version of read/write)
- removed pinctrl_single_syscon_unlocked_modify_4
- update error handling after fdt_pinctrl_register() call to release syscon in case of failure.
Oct 10 2023
Oct 10 2023
Looks mostly good to me.
Oct 9 2023
Oct 9 2023
Thank you Manu. Followed your advice to move the bus_alloc_resource/syscon interface to the end of the attach function to avoid complicated error paths.
oskar.holmlund_ohdata.se abandoned D41896: AM335x: ti_pinmux.c add pinconf-single to set of compatible strings.
Replaced by D42124
Oct 8 2023
Oct 8 2023
I'm pretty sure that the last time I've tested my pandaboard (maybe 4-5 years ago) there were already problems.