Page MenuHomeFreeBSD

arm: Allow in-kernel VFP instructions handling.
Needs ReviewPublic

Authored by alex.stetsenko_gmail.com on Sep 6 2023, 6:48 AM.
Tags
Referenced Files
Unknown Object (File)
Wed, Nov 15, 11:27 AM
Unknown Object (File)
Nov 6 2023, 7:20 PM
Unknown Object (File)
Oct 24 2023, 9:40 AM
Unknown Object (File)
Oct 19 2023, 1:25 PM
Unknown Object (File)
Oct 10 2023, 7:40 PM
Unknown Object (File)
Sep 27 2023, 6:53 AM
Unknown Object (File)
Sep 6 2023, 10:15 AM
Subscribers

Details

Reviewers
andrew
markj
Group Reviewers
Klara

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Why is the kernel getting into the undefined instruction handler? It should only use VFP instructions from within a specific section marked by the fpu_kern_* functions

Why is the kernel getting into the undefined instruction handler? It should only use VFP instructions from within a specific section marked by the fpu_kern_* functions

As I understand it, your comment is only true when fpu_kern_enter() is called with FPU_KERN_NOCTX. When an explicit context is provided, I believe the intent is to enable VFP lazily, but that is currently broken. The intent of the patch is to fix fpu_kern_enter() to behave properly when the caller supplies a context.

sys/arm/arm/vfp.c
281

This addition is unrelated to the rest of the patch and should be added separately.

des added inline comments.
sys/arm/arm/undefined.c
354