Page MenuHomeFreeBSD

AM335x: Add ti,clksel driver
Needs ReviewPublic

Authored by oskar.holmlund_ohdata.se on Sep 16 2023, 5:27 PM.
Tags
Referenced Files
Unknown Object (File)
Sun, Sep 22, 4:35 AM
Unknown Object (File)
Fri, Sep 20, 9:56 PM
Unknown Object (File)
Fri, Sep 20, 9:56 PM
Unknown Object (File)
Thu, Sep 19, 11:53 AM
Unknown Object (File)
Thu, Sep 19, 11:53 AM
Unknown Object (File)
Thu, Sep 19, 11:52 AM
Unknown Object (File)
Thu, Sep 19, 10:20 AM
Unknown Object (File)
Wed, Sep 18, 6:33 PM
Subscribers

Details

Reviewers
manu
karels
andrew
imp
Group Reviewers
ARM
arm64
Summary

TI has a new idea to collect some clocks within a ti,clksel. checkout clock@664 and clock@52c in sys/contrib/device-tree/src/arm/am33xx-clocks.dtsi

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

I'm not sure what this driver actually does, so I'm probably not the one to approve it. Just a few cosmetic issues.

sys/arm/ti/clk/ti_clksel.c
107

Looks like a debugging printf?

108

It seems like this test in the #if 0 is necessary. Why is it #if 0?

120

This seems like debugging too.

122

What is this block? If it is not needed, maybe shouldn't be here?

manu requested changes to this revision.Sep 18 2023, 7:24 AM

Looks mostly ok, I guess TI loves to reimplement simple-bus like things ...
Same comments as Mike though.

This revision now requires changes to proceed.Sep 18 2023, 7:24 AM
oskar.holmlund_ohdata.se added inline comments.
sys/arm/ti/clk/ti_clksel.c
108

the whole point in this driver is to give the reg field...It should be no #if0 around this section

I'd include this link in the commit message.

One minor nit, if you fix that it's accepted (but clicked accepted already)

sys/arm/ti/clk/ti_clksel.c
109

Maybe "Requires reg property\n" is clearer?