Man page part of the change looks good. It needs a .Dd date bump when the commit happens.
Thanks for keeping up the good work on pf!
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Advanced Search
Oct 30 2021
Oct 29 2021
Change an instance of "alone" to "only" in the L2ARC description to not confuse people about adding multiple devices there.
Reply with confirmation about the L2ARC vdevs question.
Two minor fixes.
Oct 28 2021
Minor comma nit, the rest looks good.
Looks good. Make sure to bump the .Dd for these content changes.
Oct 27 2021
Update with some of my own replies.
Yet another update addressing some of @pauamma_gundo.com's comments.
Sep 25 2021
Sounds better now, so the man page looks good to me now.
Thanks for implementing that feature!
I found two things worth "exploring".
Sep 21 2021
Just a minor nit, the rest looks good, doc-wise.
Sep 16 2021
OK from manpages.
Sep 6 2021
OK from manpages.
Sep 5 2021
Update including the lastest suggestions to the lower last part of the chapter.
Another big update, including both @ygy's and @pauamma_gundo.com's comments.
I should have kept the diff much smaller in retrospect, sorry about that. We're getting close to the final piece now, thanks to your efforts!
The line breaks were caused by my editor trying to be smarter than it should be.
Sep 3 2021
New version that includes suggestions by @pauamma_gundo.com
Phew, a lot of changes, most of which I concur with and changed. Thanks!
Updated patch follows.
Aug 31 2021
OK from manpages.
Minor typo, the rest looks good.
OK from manpages.
Aug 30 2021
A few comments, mostly agreeing with the suggestion.
Another fine set of changes, including most (if not all) suggestions by @pauamma_gundo.com
In D31707#715615, @debdrup wrote:In D31707#715576, @bcr wrote:Maybe one more reason to use dataset more to avoid this ambiguity? ;-)
Calling them datasets introduces new ambiguities, because a dataset can both be a filesystem and a volume, and it's possible that it's definition will be expanded in future versions too.
Aug 29 2021
Update diff to incorporate changes from @debdrup and @pauamma_gundo.com . Looking forward to the second half of changes. I know it's tedious and I should have kept it shorter. Will consider than for future changes like this on other chapters.
Thanks for your suggestions, @debdrup and @pauamma_gundo.com . I incorporated a lot of them into the next set of changes.
I looked at our current docs for the word list on how to write "file system" versus "filesystem". It seems like it does not exist in the FDP primer anymore. It used to be there in the old one: https://www-legacy.freebsd.org/doc/en_US.ISO8859-1/books/fdp-primer/writing-style-word-list.html . Maybe one more reason to use dataset more to avoid this ambiguity? ;-)
Aug 28 2021
Updated diff incorporating suggestions by @ceri
In D31707#715385, @ceri wrote:Running out of battery so submitting what I have reviewed. Generally speaking I think the shorter text works against the intent of this being a guide, I'm afraid.
This one uses git diff --no-prefix -U1000
Aug 11 2021
OK for the manpage part of the change.
Aug 5 2021
Yes, this makes sense. Approved!
Aug 3 2021
OK from manpages.
Jul 22 2021
OK from manpages.
Jul 11 2021
Approved!
Separate issue found about the use of you.
The actual change looks fine to me. Thanks!
Wow, good work. Nothing to complain about.
Jul 9 2021
Minor question about which keys are valid to press.
@imp: No more work done since then. If you want to take over, I'd appreciate it.
You can keep me in the list of reviewers for any textual changes you're making. Thanks!
Jul 2 2021
OK from manpages. Looks like a nice feature.
Jun 24 2021
OK from manpages, too. Thanks for addition this feature.
Jun 17 2021
Looks good to me.
Manpage looks good.
Jun 16 2021
Minor nit, thanks for the update.
Jun 14 2021
OK for the manpage part of the change. You need to bump the .Dd for this content change when you commit.
Jun 11 2021
Cool, I like this addition of language servers. I added some language improvements.
Jun 9 2021
Cool, I like this.
Jun 7 2021
Manpage looks good. Thanks for yet another driver!
Jun 1 2021
May 28 2021
OK for the manpage part of the change.
Minor nit in the man page.
May 27 2021
Good to go, thanks!
OK from manpages.
May 25 2021
Ok from manpages.
May 24 2021
A textual suggestion, the rest looks fine.
May 18 2021
Manpage looking good, pending .Dd bump once approved.
May 17 2021
Manpages is also fine with the change. Thanks!
May 15 2021
OK from manpages. Thanks for the update!
In D27668#680170, @ygy wrote:In D27668#680060, @bcr wrote:I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file@bcr Interesting... It is fine on my end, no errors. Where did you see this message?
OK from manpages.
I get the following exception from Phabricator upon loading this review:
Found unknown intradiff source line, expected a line beginning with "+", "-", or " " (space): \ No newline at end of file
A few minor nits, the rest looks fine.
Looks good!
May 13 2021
OK from me as well. Thanks!
May 12 2021
OK from manpages.
Looks good to me. Thanks for the update.
Only found these now. Looking good otherwise.
May 9 2021
A few suggestions for wording improvements in the man page.
May 8 2021
Adding Sergio, as I think this might interest him.
Having a way to build our docs on other platforms is nice and might bring in some new contributions.
May 6 2021
OK for the man page update.
May 4 2021
Other than this small nit, I'm fine with the change.
Right, I thought it was the other way around, but this makes more sense. :-)
May 3 2021
Manpage looks good now.
I guess upstream will incorporate it, too.
Minor man page nit.
Is this one still active?
Has this change been committed yet?
Is it OK to abandon this revision now that we have a new website structure or do you think the new site needs this as well?
OK for the man page part of the change.
Apr 30 2021
Minor man page fixes.
OK for the man page part of the change.
OK from manpages.
Looks good, thanks for the addition. Can you bump the .Dd when you commit as well for this content change.
Thanks!
The manpages look good to me.
Apr 27 2021
The text looks good to me as a first version. I think the change to the relnotes is unrelated?
Apr 23 2021
Looks good to me, with my doceng hat on (but ENOPORTSCOMMITTER).
Apr 20 2021
OK from manpages.
Apr 18 2021
Ah, no. I thought the submitter could do that/had a commit bit.
You can do it if you want, @0mp. Thanks!
Apr 17 2021
In D29788#668512, @bz wrote:Don't forget to bump .Dd on the man page when committing.
Apr 16 2021
Good catch, approved!
Apr 15 2021
OK, great! Good to know this EN, btw.