Page MenuHomeFreeBSD

ldconfig(8): update manpage to reality
ClosedPublic

Authored by kib on May 15 2021, 5:16 AM.

Details

Summary

ELF ldconfig only maintains the search list, there is no hints

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kib requested review of this revision.May 15 2021, 5:16 AM
kib created this revision.
kib added a reviewer: manpages.

A few minor nits, the rest looks fine.

sbin/ldconfig/ldconfig.8
51–64

s/configure set/configure a set/

126

s/directoriesf/directories/

kib marked 2 inline comments as done.

Grammar/typo.

The new version doesn't mention what is the limitation on shared library names.

Normally they are:

libXx.so -> libXx.so.A
libXx.so.A -> libXx.so.A.B.C
libXx.so.A.B.C

but is this also allowed?:

libXx.so -> libXx.so.A.B
libXx.so.A.B -> libXx.so.A.B.C
libXx.so.A.B.C
In D30272#680344, @yuri wrote:

The new version doesn't mention what is the limitation on shared library names.

Normally they are:

libXx.so -> libXx.so.A
libXx.so.A -> libXx.so.A.B.C
libXx.so.A.B.C

but is this also allowed?:

libXx.so -> libXx.so.A.B
libXx.so.A.B -> libXx.so.A.B.C
libXx.so.A.B.C

New version is quite explicit that ldconfig does not care about libraries or libraries names at all.

In D30272#680345, @kib wrote:

New version is quite explicit that ldconfig does not care about libraries or libraries names at all.

Ok

sbin/ldconfig/ldconfig.8
5

Portions of this documentation were written by

51–65

maybe

.Nm
utility is used to configure the set of paths used by the dynamic linker
.Xr ld-elf.so.1 1
when searching for shared libraries.

85–86

I'm not sure we need to keep this text at all - "the shared libraries which are found" implies we are building a list at ldconfig time?

88

additional shared library search directories.

112

Are they printed?

126

-r also performs a search and prints the libraries found?

144–145

should this perhaps be "only load shared libraries from paths found in the hints file"?

kib marked 7 inline comments as done.

Handle Ed' notes.

More editing, remove "line 76".

Big improvement overall, thanks for cleaning up after my a.out removal change. One little note inline, but we can iterate on it in the tree etc. later on.

sbin/ldconfig/ldconfig.8
55–58

IMO we don't really need this either - for someone unfamiliar with the history of a.out this seems like we're telling them that they don't need to do something that they wouldn't anyway. But not a big deal.

This revision is now accepted and ready to land.May 21 2021, 4:26 PM
kib marked an inline comment as done.May 21 2021, 4:50 PM
kib added inline comments.
sbin/ldconfig/ldconfig.8
55–58

Mmm, no, this does not have anything to do with a.out. It is about -rpath (actually ELF feature, I do not remember anything similar in Sun 4.x/FreeBSD a.out so).

This revision was automatically updated to reflect the committed changes.
kib marked an inline comment as done.