Page MenuHomeFreeBSD

pf.conf: document syncookies
ClosedPublic

Authored by kp on Sep 25 2021, 1:06 PM.

Details

Summary

Obtained from: OpenBSD
MFC after: 1 week
Sponsored by: Modirum MDPay

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

I found two things worth "exploring".

share/man/man5/pf.conf.5
552

Something sounds odd in this sentence, maybe a missing word or letter.
Is it
s/share/shared/ maybe or
s/answers to each/answers that each/
maybe?

563

Capitalize tcp here?

  • capitalise TCP
  • simplify 'each and every'
kp marked 2 inline comments as done.Sep 25 2021, 2:46 PM
kp added inline comments.
share/man/man5/pf.conf.5
552

It's perhaps a slightly awkward sentence, but it reads correct to me. I've simplified the 'each and every' which may help a bit.

It correctly states that just like synproxy syncookies have the caveat that connections may seem to accept connections which get dropped later.

Sounds better now, so the man page looks good to me now.
Thanks for implementing that feature!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 29 2021, 1:42 PM
This revision was automatically updated to reflect the committed changes.
kp marked an inline comment as done.