Page MenuHomeFreeBSD
Differential D32137

pf.conf: document syncookies
ClosedPublic
Actions

Authored by kp on Sep 25 2021, 1:06 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 13, 7:52 PM
Unknown Object (File)
Feb 12 2024, 6:52 AM
Unknown Object (File)
Feb 12 2024, 6:52 AM
Unknown Object (File)
Feb 12 2024, 6:52 AM
Unknown Object (File)
Feb 12 2024, 6:52 AM
Unknown Object (File)
Feb 11 2024, 9:42 PM
Unknown Object (File)
Feb 11 2024, 9:30 PM
Unknown Object (File)
Feb 7 2024, 6:26 AM
View All 27 Files
Subscribers
bcr
imp

Details

Reviewers
None
Group Reviewers
network
manpages
Commits
rGab14a9ac18e5: pf.conf: document syncookies
rG45a2a438f1f7: pf.conf: document syncookies
rG20f015f08d66: pf.conf: document syncookies
Summary

Obtained from: OpenBSD
MFC after: 1 week
Sponsored by: Modirum MDPay

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kp created this revision.Sep 25 2021, 1:06 PM
Herald added a reviewer: manpages. · View Herald TranscriptSep 25 2021, 1:06 PM
Herald added a subscriber: imp. · View Herald Transcript
kp requested review of this revision.Sep 25 2021, 1:06 PM
kp added a parent revision: D32136: pfctl: userspace adaptive syncookies configration.
Harbormaster completed remote builds in B41753: Diff 95713.Sep 25 2021, 1:06 PM
kp added a child revision: D32138: pf tests: Basic syncookie test.Sep 25 2021, 1:06 PM
kp updated this revision to Diff 95716.Sep 25 2021, 1:10 PM

Fix typo

Harbormaster completed remote builds in B41756: Diff 95716.Sep 25 2021, 1:10 PM
bcr added a subscriber: bcr.Sep 25 2021, 2:08 PM

I found two things worth "exploring".

share/man/man5/pf.conf.5
553

Something sounds odd in this sentence, maybe a missing word or letter.
Is it
s/share/shared/ maybe or
s/answers to each/answers that each/
maybe?

564

Capitalize tcp here?

kp updated this revision to Diff 95723.Sep 25 2021, 2:43 PM
  • capitalise TCP
  • simplify 'each and every'
Harbormaster completed remote builds in B41758: Diff 95723.Sep 25 2021, 2:43 PM
kp marked 2 inline comments as done.Sep 25 2021, 2:46 PM
kp added inline comments.
share/man/man5/pf.conf.5
553

It's perhaps a slightly awkward sentence, but it reads correct to me. I've simplified the 'each and every' which may help a bit.

It correctly states that just like synproxy syncookies have the caveat that connections may seem to accept connections which get dropped later.

bcr accepted this revision as: manpages.Sep 25 2021, 7:02 PM

Sounds better now, so the man page looks good to me now.
Thanks for implementing that feature!

This revision was not accepted when it landed; it landed in state Needs Review.Sep 29 2021, 1:42 PM
Closed by commit rG20f015f08d66: pf.conf: document syncookies (authored by kp). · Explain Why
This revision was automatically updated to reflect the committed changes.
kp marked an inline comment as done.
kp added a commit: rG20f015f08d66: pf.conf: document syncookies.
kp added a commit: rG45a2a438f1f7: pf.conf: document syncookies.Oct 6 2021, 8:48 AM
kp added a commit: rGab14a9ac18e5: pf.conf: document syncookies.

Revision Contents
Changeset List

PathSize
share/
man/
man5/
30 lines

Diff 95933

View Options

share/man/man5/pf.conf.5

Loading...