Page MenuHomeFreeBSD

porters-handbook: Document FLAVORS_SUB
Needs ReviewPublic

Authored by bapt on Oct 18 2021, 3:27 PM.

Details

Reviewers
mat
0mp
Group Reviewers
Doc Committers

Diff Detail

Repository
R9 FreeBSD doc repository
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 42234
Build 39122: arc lint + arc unit

Event Timeline

bapt requested review of this revision.Oct 18 2021, 3:27 PM
bapt created this revision.
lwhsu added inline comments.
documentation/content/en/books/porters-handbook/makefiles/_index.adoc
4104

typo?

Two minor fixes.

documentation/content/en/books/porters-handbook/plist/_index.adoc
60

s/arefiles/are files/

68

s/lines only/lines is only/

English LGTM other than that.

documentation/content/en/books/porters-handbook/plist/_index.adoc
68

I agree the sentence is iffy, but I'm not sure bcr's correction is right either, depending on the intended meaning. Perhaps something like "In [.filename]#pkg-plist#, use %%X11%% in front of the lines that should be installed only when the flavor is enabled, like this:" (that is, what gets installed conditionally is the rest of the line, not X11 (or %%X11%%).

imp added inline comments.
documentation/content/en/books/porters-handbook/makefiles/_index.adoc
4123

.endif

4127

.endif

This comment was removed by trhodes.
documentation/content/en/books/porters-handbook/plist/_index.adoc
68

Maybe “preface any lines enabling the installation of the flavor with %%X11%%” just to be more clear?