Page MenuHomeFreeBSD

dumpfs(8): add option to only print superblock information
ClosedPublic

Authored by rew on Jun 24 2021, 3:20 AM.

Details

Summary

Add an option to dumpfs, -s, that only prints the super block information.

Diff Detail

Repository
R10 FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rew requested review of this revision.Jun 24 2021, 3:20 AM

This looks good. And I rather like it, since I've wanted something like this in the past.

Strictly speaking, dosb should be a bool, but that's a bigger change because dofreespace, domarshal, and dolabel are not yet bools and should before consistency. And that's well beyond the scope, unless you really wanted to follow up with that. :)

This revision is now accepted and ready to land.Jun 24 2021, 3:31 AM
bcr added a subscriber: bcr.

OK from manpages, too. Thanks for addition this feature.

In D30881#694691, @imp wrote:

Strictly speaking, dosb should be a bool, but that's a bigger change because dofreespace, domarshal, and dolabel are not yet bools and should before consistency. And that's well beyond the scope, unless you really wanted to follow up with that. :)

Would you rather see a follow-up done as part of this review or in a separate one?